From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07BAF27A476 for ; Sat, 11 Jul 2026 14:53:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783781590; cv=none; b=G8oiOdWTBGlE51sqaWgLUzkKvGMSsrNHA2PYPRndCQ2KAk6DuzhGcJgFRI8OwtA4uzi6ZogR6fJ5oC4DKTgNJkNWfG7isncfgClIZqy7z/YGwQZy6aOBmCdIV17tqEFFTVUraBACgJK0fSqoAemR5snDLJM7i/ZNBAD19S9XGjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783781590; c=relaxed/simple; bh=maBxh30Ot5sGG+NXT7NhtFKTb4zNy9lYAwyOnjvsjX4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RN61+5no82UyBgL1Yvl9u4ordMt5phJSU6c3y2TVpQd43I/gHisaqhe+pJSVIY9smJ6EEamXVejIqkTSh9bJU26NJPmjqVx+T4H0nRK15SPEgcwFTqrn7cNjeHAxz7EUo85lgNypstJy4mKsOxwsagpfYjwyTa7iZEq9zLQhQ4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GTGQSiQR; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GTGQSiQR" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-381891a9525so2197854a91.3 for ; Sat, 11 Jul 2026 07:53:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783781588; x=1784386388; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=VInIyLRCaI65EOZkEY6bHUdgAExKI+1x+V4m7DQD6xQ=; b=GTGQSiQRmvswBYRLKioF4RkxcwprpXfElY0/SEg+3AoMJBKnhmluvLUa9MsbMSugfy bvCq0vWplMF9QgRLSxduSE3vS+vp8erwXKoc3kKE0WINW5wav8EOaO4MsDJ9JNz7/TXR yrnug0hdMboVjIXlnsUV/m1KMISkoy4kRdYa/PRlEgEhwevsvY69OBKf+mOURFuOAbhi XTbU0SAtgMStWuQXIxjjRW3zNSQhtHtdn4Z8svZGmut/e3LC+ZA6LIHO+QN5Roar5kYh NetxqEJP3D0meaIhws6VLtZECYO1tRPNOFoGxCbcHsFJJv0t2/kciy1Vt0LvO/y+nYkD eR0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783781588; x=1784386388; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VInIyLRCaI65EOZkEY6bHUdgAExKI+1x+V4m7DQD6xQ=; b=qFlKwQ2+vFusKXh4SXPGgLAqkYDgG2b3M3G6g7btCA5rgTKZnS0zP4yDKcQR+tJVaa D/bc7RMMY+LB9N3szfu/uHT4gXU8KX0W68ztmIrLFv/dSp26uXO1rv5DLD2BFasF394H LVEtFdqJJ7H6YgHqF0AWaQIYWxTNrj7Ngp0kptejPh5wnDQz4Aum7Ico5LdGmaNaFh3a oY73QEUJGJJjQ1+DLrI507XcnwDJnlWnY1ThfDCgWy6H5uDiTtoU25THFJVYewl6ny7x NF55FxqOBH4sagytkC1DuzMqYXe0324LnPWFJi71P1GbDY+djtBOfRN1eaYjWEwH0o6L /GIw== X-Forwarded-Encrypted: i=1; AHgh+Ro+Sp1fuv+FyS+23qFugk/iY1jxxCq0vIDpWgG5TcFbpeyKkTBoYpZ2mLvWbIdC8GAjMgYgVqYpk30Adf8=@vger.kernel.org X-Gm-Message-State: AOJu0Yze+H5S6CUfgym8QQ5S60apP6fp93vFBUIJDx2D63U7sVt1NVSC fMEX5fHf6zXoCjJZGekTPrpYVa0dEoFSkwjn5cGRD873pxWWmkMaJTzl X-Gm-Gg: AfdE7cllEGwpfpN8Bhnbk1b9wwUn1NPyx3VaWoB93h4u6YMYiASDg/rUENH95Zau0oX vxrUdMpZ4SssRTJTnO483E1sN3/bspi+RTt6s8GewHZtF6Y5IL5zYxTMfa/4AaD1YmgaM0RZbrv L6LGaeMx9mr9WN0wesdvqW1UJPQnQx6R1xbNxEBhmLvPUb+fH8zHxK1I0kidPiqYGLztI8zAivr yPtdmJH0VrKgrxmRP3mWKhr+ygn4cHkTCXmY0bxGEiyDTrBUmfnKNMo2Epo5rtMBFBdHk2uMpsK oxOK5K9JsJ7atCJdfIOsGqTdpHuMxjYzqo8D+J4uv6p6jVvCT2yDl6NQ8KUyRnCF4vXkVG8kt7g sQ3LhlNEh9nyw0WSXpJtp4+9G9mm0cvW9/hBKH/Z+8i4E1yi1fgG30UcA6mbCWY+vpHsGNAPiiV 5r3e0x9335K2TE8PP1SYU7UA7+d1fSBWGfuizSpHzhMjRQzXZUliaNLpo5 X-Received: by 2002:a17:90b:164d:b0:381:21ea:912b with SMTP id 98e67ed59e1d1-38dc74c4c37mr2726543a91.1.1783781588260; Sat, 11 Jul 2026 07:53:08 -0700 (PDT) Received: from fedora.mrout-thinkpadp16vgen1.punetw6.csb ([223.181.49.193]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3117483dec6sm53449794eec.11.2026.07.11.07.53.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 07:53:07 -0700 (PDT) From: Malaya Kumar Rout To: bgeffon@google.com, rafael.j.wysocki@intel.com, linux-pm@vger.kernel.org Cc: mrout@redhat.com, skhan@linuxfoundation.org, me@brighamcampbell.com, Malaya Kumar Rout , "Rafael J. Wysocki" , Len Brown , Pavel Machek , linux-kernel@vger.kernel.org Subject: [PATCH] PM: hibernate: Fix memory leak in snapshot_write_next() error path Date: Sat, 11 Jul 2026 20:22:45 +0530 Message-ID: <20260711145246.8625-1-malayarout91@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When memory_bm_create() succeeds for copy_bm but fails for zero_bm, the function returns without freeing the resources allocated for copy_bm. This results in a memory leak that includes radix tree nodes, zone structures, and page lists. Fix this by calling memory_bm_free() to release copy_bm's resources before returning the error code when zero_bm allocation fails. Fixes: 005e8dddd497 ("PM: hibernate: don't store zero pages in the image file") Signed-off-by: Malaya Kumar Rout --- kernel/power/snapshot.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c index d933b5b2c05d..4a73927cc55b 100644 --- a/kernel/power/snapshot.c +++ b/kernel/power/snapshot.c @@ -2797,9 +2797,10 @@ int snapshot_write_next(struct snapshot_handle *handle) return error; error = memory_bm_create(&zero_bm, GFP_ATOMIC, PG_ANY); - if (error) + if (error) { + memory_bm_free(©_bm, PG_UNSAFE_CLEAR); return error; - + } nr_zero_pages = 0; hibernate_restore_protection_begin(); -- 2.54.0