From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 587D94C6D for ; Sat, 11 Jul 2026 15:06:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783782375; cv=none; b=mz4rscNFwDSNNcDcKAtZUZTQyBn7XUXgLQB2r0PQpgPexnuF3Pq5XqkjUIYX9wvaHlptZm0QEogFsUKMiEdkaXR9p9e2DKirxQRmQHUvMvt5yjuwqlcW6U+bWkyQRGqL6viXqAel55x/f860ltvNbXl1/HAoHjm7PSmIWS4OfKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783782375; c=relaxed/simple; bh=S4tnd3gU6E0U7OZ4HKFPKwlMp4QR6VJmRDUS5NtF2D8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=e4UgxqUD+GVUQA6j2ZrqKKYoFltnOwR/kGDuRjKxWAvu1nFliXMLsIyXehhblgy0obKEemaP6e3G157U77zQCclO71VsIb6V44C4IxW8XD+qg25GXQbch5VLY/64j5NSyn69HX2CFsiqqm25wJKP8+nmP273/AKuHawNMYDfumo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IaIB+0pZ; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IaIB+0pZ" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-92e5cb052edso144611985a.2 for ; Sat, 11 Jul 2026 08:06:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783782373; x=1784387173; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=/GKREJqWw2SSprYGaRAlQGLw7OTwwGCr4lR4AMIblRM=; b=IaIB+0pZtIMq3YKkGd0S+QkIuAOPdidHFry21OP5ESYPHMH7gu/kXtHD5te/fBI78t prey7qedh2k9DUhZzTWJVQvmyQoX9RtoR7hCIWq2eba09EPg+1C2Wvs9+T5xc5xXFVYi nBpf9LG6TuZ4jkXfA5xkLOMhdRMSCVEmhhkIlBy+o9RKG1uQ4t8Kj3cLtdvU8jPwqL3M 2kUZHcgIpuHgElt3VoREgDNCdEG/iiP0IoGDvEHpXV7TyHiXXrtYwUEd/8PKZRKcD6dZ XkK4Ae4KP8QBmBs/oYN6h52VzH9verACr65WuA0CsAA8TDrgIIjdanfYDxJxIyBMnMZr oRmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783782373; x=1784387173; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/GKREJqWw2SSprYGaRAlQGLw7OTwwGCr4lR4AMIblRM=; b=kOFNcx2AWt4AnpUQa2r9nKPKTRTUG+0+9+aerK4Xc+1HSvb58vkbENQ+uJTkX7j0gZ AIb7ZX2N/Su4jNzl2913hRMU0sG07vWhrmKOM5j+aUU0EtKJCetqSsGgGXf0JmqXk7D7 GuHM7rqrapUSo23A0PrshoFC1GurluQ1eP+4fmSorRgEKWLj/tpb+ccTKEjG7yAo6bmQ jQh1hNqJlGrfxzjmZ17CM6Xl1e6MDBv5vkbEo9z/Eb+86cfvAqDePxrVNLghSPZgmu36 DUIH+/gBU4ykTVjKqBaRKlRfnZ7EUHWxuGhGsge40tQR9uwM1udZuPLEEmYyan7QHqCq PERw== X-Forwarded-Encrypted: i=1; AHgh+Rr1mtSJ/tPr6KxJzjxZ36H4I9L06Vh61kHU6nN3dRI+asT6STglavvuybGXFwjbuSgFC20BuBuduL1wtQA=@vger.kernel.org X-Gm-Message-State: AOJu0YxKVvR9H6ZtV2/lcQ3EJpcbaIA4EzJNrq3vIYNS07bo7qwWHnOg tScffRBI2UNrHF+gdQtrkuoECvM6LNCdw6yiiNfH3gyWUbc8leHy2yAz X-Gm-Gg: AfdE7clHc8PEYaK84WNU8k5JAQ1Co6X/QUe/O1+UzfwL2ctTDzTQndIbJfk5wShawa9 LfWYD+BniSAUCkeGP+5zK88XpZBrsd1KtMnr1GnFvqWfgXeGkYR7woK478jhAyFiiKRL566bwf6 /M2xEjTS9g/jVKq55G5HbnC2Ej1L1n0DqzZdISWkyIO2+07uwCkdqKsMH3l0vpbIeDZ5IufxBkh nxaVqMah5a6p2hIOG9KXtkN/0wlxePl6oZRw5+GGotfL3lkBgLrZYLLCrgjVnTuYMcSntW9T7MK aSQ2V7fXYDvA4vQSFPUlls+y5KGwxizpDbeiPtu+ZU029dL8+Mt+0615bZG6YniYNxtAgvHdgQK 4ScNEudF5SWMCasqxWdtUBz2g8eMff7xp7/Ku/W9Xqtq0tUaw0oSy2Q9eugytdTZ3lnMq4GXzLo iNAWOocG6O6Es5/qW5uR7KBUw7COuslvzvdc5BWbphvyc/pH8fuvu+9CsSIN2n5TBZRUas1z/k9 VQyR1gAoQ== X-Received: by 2002:a05:620a:3941:b0:92e:6864:b83 with SMTP id af79cd13be357-92ef2c131fcmr396322685a.69.1783782373374; Sat, 11 Jul 2026 08:06:13 -0700 (PDT) Received: from server0 (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92ee5d68e5fsm464578285a.43.2026.07.11.08.06.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 08:06:12 -0700 (PDT) From: Michael Bommarito To: Miri Korenblit , Johannes Berg Cc: Emmanuel Grumbach , Benjamin Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 0/2] wifi: iwlwifi: mvm: bound BA-window station ID Date: Sat, 11 Jul 2026 11:06:09 -0400 Message-ID: <20260711150611.2913332-1-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit iwl_mvm_window_status_notif() extracts a 5-bit station ID from the firmware's BA-window status notification (values up to 31) and indexes mvm->fw_id_to_mac_id[] with it without first checking it against the firmware's station capacity. A firmware/backend notification carrying an out-of-range ID reads past the station map. Patch 1 validates the station ID against mvm->fw->ucode_capa.num_stations before the lookup, matching the existing MVM station-lookup helpers. Patch 2 adds KUnit coverage: the malformed out-of-range ID and a valid-ID/ null-station control that must still pass. Reproduced with the KUnit test under UBSAN bounds: the malformed case reports an array-index-out-of-bounds splat on stock and passes after the fix; the valid-ID control passes on both. Cc: stable@vger.kernel.org Michael Bommarito (2): wifi: iwlwifi: mvm: check BA-window station ID before lookup wifi: iwlwifi: mvm: add KUnit coverage for BA-window station ID bounds drivers/net/wireless/intel/iwlwifi/mvm/rx.c | 4 + .../wireless/intel/iwlwifi/mvm/tests/Makefile | 2 +- .../intel/iwlwifi/mvm/tests/window-status.c | 77 +++++++++++++++++++ 3 files changed, 82 insertions(+), 1 deletion(-) create mode 100644 drivers/net/wireless/intel/iwlwifi/mvm/tests/window-status.c -- 2.53.0