From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4770F2C21E6 for ; Sat, 11 Jul 2026 15:06:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783782394; cv=none; b=H441VejIX08+z8E/456I+zIlLa/hNTS+h/f9eDireudhCwOvvN5yWH8nOIFzq4jlub7dcFjtQ3R4VptjTd8koNDHGn0BlNWec30o2fwcb+L8Hh96UjCnxejiFPiUXZ621ZjkKEc0OztwfajLhn7cuD69SjkQ1kXUnHChWUp6/1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783782394; c=relaxed/simple; bh=xfd1Qij55WSKgMYmH/iULiROavfzelZy0Gq6Ktbvt4s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=X7LD5972j379NNLn/iLrzepqMi+nl73pKT2IxfsfiZKZ79CeT8fshS5vKuM8uZ+shiBPsRG+njdhZPiQATTvIwpjQ8DlkjcfnP9HmaAUulzrQY/7EF8wcxS0AJkFd1psjEAgR+Ogw24uNA2riQ6AdBwnyPTzg4N7Z6IQbOKtuuE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RdER+N6g; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RdER+N6g" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-92e6a434cabso95172785a.1 for ; Sat, 11 Jul 2026 08:06:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783782392; x=1784387192; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=XSPQ4s327xjju3OZzaMxfnUi+7xam88AtuluAZAKUPI=; b=RdER+N6ghm5RpSKKvj+gqtJxRBfPmMkBL8fMv4K6APpV1kKcCcxbKfb5/4cKDFpTtg FwCU4a/ts9PUK1uxOiASMqHWAPZBj7oCY5/VG2TDLeMgcFI0F3pmM6OehTWfJxlWvWmA ah3CqWm3AK/jmu2R6lJVPtlaj0PmN8hka8eK+DXUa/pVcf1fygS69HwuV4pENMFmziC/ xROgyWzftvniM5Q86qCuKbjsmDvx6lx9HgEXP8eicWeLYRGBw3muIhXTNrn1ja2P5Q29 q7vDzGqm5U8rmfAtaCRZJOwQdyAKP+Mx1n2TTczKw2aLxJHKKOem+CC31ZLhAyYd/enM slUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783782392; x=1784387192; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XSPQ4s327xjju3OZzaMxfnUi+7xam88AtuluAZAKUPI=; b=sebAOqhNcA+ZyhinOVqx3bJ88oVOyg+TYfpnp0vQSRTE2wOUB8bu80kj74qnQ9S+Kv Mj947oZkvL/na1he3BQ4J6kvq7OgbwC/UP0gKyzWSlJ7+K2Ve0fA3lVNDyD38oaR1/26 8Y2JOmg8wbxkBEeK3pgTslCAXq8pWXNPRgFjNRQjjU7wrFIg0H4GAQ+FPkL6dmtl+/bK NVxoofVSMbaXWX4BqcQwGA3eYEw7amBrjz8wL6wFRfGlE+PG5BQJtamv+hTSXNAO88zP YremCIS+gLgeu8e3px8mnCSdhe3pdEC3Fa4G73mQzPQVRZJHhQ0lmTOXtv5zUtPOTGGF XSSw== X-Forwarded-Encrypted: i=1; AHgh+Rr34IOqnep/hQofGNcKIE4dZS+i/TTVzbcZ44EiigLDwPmxIjxoj7lbUfjJ+u7xSC6rW49ZsFcz8wBJ0Ow=@vger.kernel.org X-Gm-Message-State: AOJu0Yyn4sLs+BLPhSZjI3fjHApfUQigCokv4+dIXK6oSYE+pT+iIzHL whS+/rY+TszsGZpcQ5kx9lZ4hSDi2lVQTt0NOeKIMN1cW6O18a3CiYfG X-Gm-Gg: AfdE7ckqh/JYRWxEfu4rhyKbTuui/8qOE0fFvISb4QSE3cy91wL+k9zw6kmVSB0iADh vUJ+h0X7SXgmFP5opSnYvn3xHDWhZ/v1gUu4fJfNyTQ4VPBfpcOpkPlnOkt9fRNFb6SazV2SELW to0ktpbiZ8zjg1WGDH9UWOD1qO1+2O+Fn7lbNJn2EGD7RCRXQCuZy0kT5BTK6I0IPFlBDaEMbab hM6WESCxIQP1zerjsPIHlC0l0+GzpaDd07lSwoyN5bRe0D5Po2jMfTCAt3f9k/+EfB046TbWqTR /zvS9KmdDl4u45bLt3yghpV4UtFMl798Gr2jjHhIz+jc4jljOAtXCZRUBG0l9vurIT+89bVX0gl uErj4f42aN/QFl7jGBEZ5QSusRqx4ejzhq0D/r5+KMa1Iq/Lrbm+iPAyBzMQ/5gXP01rWSb5j3S qaK6IlTnkLJ37fKH1bnDSHb9LsyS2pYpCvcez92zedte7PEtxYMZ3c7feAFHvv+Np/IVa45Z0wR so6FZtF7g== X-Received: by 2002:a05:620a:28c9:b0:92e:8e36:32a7 with SMTP id af79cd13be357-92ef2c7289amr321690985a.68.1783782392025; Sat, 11 Jul 2026 08:06:32 -0700 (PDT) Received: from server0 (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92ee5b88a38sm465793285a.12.2026.07.11.08.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 08:06:31 -0700 (PDT) From: Michael Bommarito To: Haiyang Zhang , Dexuan Cui , Long Li Cc: "K . Y . Srinivasan" , Wei Liu , Andrew Lunn , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] net: mana: cap HWC init max message size to HW_CHANNEL_MAX_REQUEST_SIZE Date: Sat, 11 Jul 2026 11:06:28 -0400 Message-ID: <20260711150628.2914205-1-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit mana_hwc_init_event_handler() in hw_channel.c stores device-advertised HWC_INIT_DATA_MAX_REQUEST and HWC_INIT_DATA_MAX_RESPONSE values without bounds checking. mana_hwc_alloc_dma_buf() later computes the DMA buffer size as MANA_PAGE_ALIGN(q_depth * max_msg_size) in 32-bit arithmetic. A malicious device returning a large max_msg_size causes the product to wrap, allocating a small buffer while laying out q_depth request slots at the unwrapped stride, placing slots outside the allocation. Impact: a compromised hypervisor device model or malicious MANA PCI device can cause out-of-bounds DMA buffer writes during HWC channel initialization. A reproducer is available on request. Clamp both values to HW_CHANNEL_MAX_REQUEST_SIZE (4096), consistent with the cap already applied at the channel-create callsite. Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Michael Bommarito --- drivers/net/ethernet/microsoft/mana/hw_channel.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c index 48a9acea4ab6c..a0916b50cffce 100644 --- a/drivers/net/ethernet/microsoft/mana/hw_channel.c +++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c @@ -152,10 +152,14 @@ static void mana_hwc_init_event_handler(void *ctx, struct gdma_queue *q_self, break; case HWC_INIT_DATA_MAX_REQUEST: + if (val == 0 || val > HW_CHANNEL_MAX_REQUEST_SIZE) + val = HW_CHANNEL_MAX_REQUEST_SIZE; hwc->hwc_init_max_req_msg_size = val; break; case HWC_INIT_DATA_MAX_RESPONSE: + if (val == 0 || val > HW_CHANNEL_MAX_REQUEST_SIZE) + val = HW_CHANNEL_MAX_REQUEST_SIZE; hwc->hwc_init_max_resp_msg_size = val; break; -- 2.53.0