From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BE8E239085 for ; Sat, 11 Jul 2026 22:46:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783809975; cv=none; b=WYL3Bw8zX4LvStLon4Xx8KTjVXwPRSzIxSBAjBm5oDgutuXVGj9I6sm+oF72un0wfeYC+uJBu17K12HSBH2LnhMFLBaZWmQDWdaKguwXpak/t6+ml69kOaVwFfmyye/MMTZbJKjUDbxQ9gwqmLpuGj1XVYSGO0n9DpJPhUY3l5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783809975; c=relaxed/simple; bh=JYkNJMYJm9V95OUQaZleNIWO2yB9VyUf6m85m8oIEjM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VNSx5w7lLl3aJ2rQY0WO6NFSdnDYAUk1x45uYfzUnYTF1z9ZfKEkNdbkVsTAqvMLnbofjiVQu1bZFCapSHgH0zbY13dK2Fpyld5Ddx7rqs3gs9uYVTqYWCm4rDHLY6rjEQdt5WTMEkKoxhS4tK5wdnc4AjuCkZWayfNGj+I040Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hgJAYp54; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BS+UJZvM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hgJAYp54"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BS+UJZvM" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66BKwU1J777449 for ; Sat, 11 Jul 2026 22:46:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JYkNJMYJm9V95OUQaZleNIWO2yB9VyUf6m85m8oIEjM=; b=hgJAYp54wD7xltet p2B22jokqrzdwocSLZKmhbFIhlCDYbcyX9ZU9YqlahBvmZOwKnNupxCqedoZbNwP EDW+orwMKwV4d0YiUI1MmFwbXvgpQgJb1x1UWiWUKP03dio5X9RGQeJNaNN9SOGI aRqtzp1GK41G7zM2MSYxcYrav/Bv3P2MWDnFSkyuM7StHDLcNDZeqtnw9UXxBK37 m2+G7RoYRHsIU2g6hcAFZz6wKZZcayWg0Y/s73Cc1Y/eS6QtcdDQjiopKjL5w6B/ OvrA7ONybwWxjznWo5EJ8lv0P+oe4j0ccDo4r7qGkFEbsL8io1tbbR5iPphQ5PoB SAsoIw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fbeaf9pv6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 11 Jul 2026 22:46:12 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2ccafc5e82cso22096535ad.3 for ; Sat, 11 Jul 2026 15:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783809972; x=1784414772; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=JYkNJMYJm9V95OUQaZleNIWO2yB9VyUf6m85m8oIEjM=; b=BS+UJZvMCRzMCj5Jneyd5JszWQifkqXFzmrZpe5Dkn3Rxya16jIvd+ZwhHg1+/B+FE 2ZH7p/5WTGpsp2oICNe07N9daMsGnsAAFsz5M9oLzD23ogTP89dykZ7RHlXqlIoLDSEE 7dxMDk3grUGAFiBtbHBry+mZnIgWgAkqXSj5/clXjXO1N3y+YlJ3sKRBHrwG2zE0RoIW QbNmEU3p7j7nhqWtHDjVFPupRisEi1zNHPYKK/4sdNpzWDnj067UCito4vwkVmFisBFu 70Zc73rA/UX66/SjTqb175AiHG4hXFvngN6ewe4RuNRXS0IGzeerwN34qHsvdi954x0D WjnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783809972; x=1784414772; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JYkNJMYJm9V95OUQaZleNIWO2yB9VyUf6m85m8oIEjM=; b=j1yPQwtKKb9fO1fCFxd57S3hjzUdbfPlucNv+LaWF5wpLBz3B2/SUUPEKIzKa0qG53 UJxRQJiL+UCB/zva+QcQehrLuf4Muw0HNFPMFKzOyPow4kiwlSIF5hfwN0wtQ9a/E6rO MBhM6/2BmjoJ+IGpTn9HPBsc8H4VuubNPL0GB1jmuKwtu3M7w64+TSzMbT7qPg36oZeu 5i4d21ULDde4UVKv1IincQEJVL9RmmBbH8GnHHD/0BLHg3Rz0IVn2TiJCfZhbh6t1D+N /b3Ass5v/0EPtuz9S8tY65euT0GacwPhMuAOQ1cWKKleUumq9DNsGKQUosgdTrkkfnSE n+5g== X-Forwarded-Encrypted: i=1; AHgh+Rr7PFOIIAECvhUbZUr41BsjfAFsvcj1ZcBTwCxPA5LM3ck2MUe9KcbkKPcMgwFFqPEiQ91vK8pwGFHG95c=@vger.kernel.org X-Gm-Message-State: AOJu0YxRHU1e1OqB4HLcH0YhJ3a4RVIYmlX4pZgFF0YaF5+fLFE9Mx7/ rsBRnBFLxQWoksofv3bPGZZyIp/e/oziCxQjcoW02Dl5JWAQ0825D1pFF5xCWpTxIQU/dZPzQju EIYb6gzuuQtwmIpadPlYDaU2jsWGLMA0TygPLcmJzso6ChwcecCsU3APRu13DYE9ZefQ= X-Gm-Gg: AfdE7clVRA6WFZGZee/OHRhPSAAiI5ctV4olANvWEA+b8H/UF/clU/q0F/wWCpLSWHT FxuiOvIsP9ETxNbwbka60YcDcg82z/x7uk9nIMvhiR1QdS2tBfqXrEP1U5bnXmexhsV3uKl6g1J vFJqRUPmZanfuSdbBDp4vG5UdvwAatZUDO0uDjCpwN8iotVILcMnFnHci+2OEf0ABsmXi4zkRH6 AXa50b4nXV7YwQwirQM/cAhu0PqWPen3moQ6QM7hxbIT3j5sXosgMNDgOW0uS/r5LE77s3cqkGi IYUwcHkgUjS+7kgTOBnOcZ6QPqWgunURAw2XoxIgr3rAcgn9QsptIa3zCozCbW2cS5UiPh2Dfxv hVhfmvvXJKgt6iEhS7GbRQs+ovb4= X-Received: by 2002:a17:903:468f:b0:2ca:eea:eb5c with SMTP id d9443c01a7336-2ce9e9ad7c6mr45041655ad.18.1783809972039; Sat, 11 Jul 2026 15:46:12 -0700 (PDT) X-Received: by 2002:a17:903:468f:b0:2ca:eea:eb5c with SMTP id d9443c01a7336-2ce9e9ad7c6mr45041535ad.18.1783809971591; Sat, 11 Jul 2026 15:46:11 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9bf8f26sm79358595ad.27.2026.07.11.15.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 15:46:11 -0700 (PDT) Date: Sat, 11 Jul 2026 23:46:07 +0100 From: Jonathan Cameron To: Linus Walleij Cc: Laxman Acharya Padhya , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: light: gp2ap002: Disable regulators on resume failure Message-ID: <20260711234607.2eca985f@jic23-huawei> In-Reply-To: References: <20260704083412.43145-1-acharyalaxman8848@gmail.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: uyt0ShRzMoJSd-eGOfLCCHCPSJOXKF4K X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzExMDIzMiBTYWx0ZWRfX0fucqRTIQBM5 H/yl56ZzrrLKB/wIngBs903s5ZhkWRY8PyDu7SITmrMcOZTv2EHtBOCBMZn51FpawFTezO1I9bQ 2c851Si6Ehv9pewT5VYro0fQm27cHAAiSoICvQSx208popq3K2o+TI1InZZgsXcvcVJQCJo7x60 vJUriQ7oKKoYVLpV0nARZp3XqHPI9aE39pdC2e9gPNh296NCXdquhruvvC8GyJcQ3R4yv9emLFy 0HSrlsQHwzgYgjXVsP5sqN4iGP6ExdvU3tJXlML+nq/y0dpXs9c5K1bwdVZknVzSEGsjrw2YFpO yPTJLGlmvLNgnVVh5w5gCoCdSnqWJuoPWr9mV+hSVsqzmN+PqSKmsS7SPjc+aoy54+GG6Wey2dA 5mUNDLqJ0TqDypZzADOEqlCBiF3Q0vqTuvrrAjd9nVbcUh87W5vShUmLEHt9LP8zf3US1HnRKNZ YecRS/uOTBAkwbyD3dQ== X-Authority-Analysis: v=2.4 cv=O5MJeh9W c=1 sm=1 tr=0 ts=6a52c7b4 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=4M_2WnJjjLYkfDCoBUQA:9 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: uyt0ShRzMoJSd-eGOfLCCHCPSJOXKF4K X-Proofpoint-Spam-Info: AW1haW4tMjYwNzExMDIzMiBTYWx0ZWRfX3v/v8vpT8z9t fykHeIWCAkV+q18qrwIN/yp9jsn1XtXGatfw8IQj9fadY+mfBpuLURtX9L0p4WQ8TytKvBqnjO0 u9IbVdk/Rmk4cMoH6UZcfezgeQz9J7s= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-11_06,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607110232 On Fri, 10 Jul 2026 19:40:50 +0200 Linus Walleij wrote: > On Sat, Jul 4, 2026 at 10:34=E2=80=AFAM Laxman Acharya Padhya > wrote: >=20 > > If enabling VIO fails after VDD has been enabled, runtime resume > > returns without disabling VDD. Likewise, if device reinitialization > > fails, both supplies remain enabled. The runtime PM core keeps the > > device suspended when its resume callback fails, so the supplies must > > be restored to the suspended state. > > > > Disable the supplies enabled by the callback before returning an error. > > > > Fixes: 97d642e23037 ("iio: light: Add a driver for Sharp GP2AP002x00F") > > Assisted-by: Codex:gpt-5 > > Signed-off-by: Laxman Acharya Padhya =20 >=20 > Looks right. > Reviewed-by: Linus Walleij Applied, and marked for stable. Jonathan >=20 > Yours, > Linus Walleij