From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A446F366DA5 for ; Sun, 12 Jul 2026 02:25:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783823126; cv=none; b=ntLS6uFfpNuSDeYshMdUWFla/DKAJa7MBDnmNkhfgR40pn6ztwsQOgjdrBya9SEoYmtPnl0Od1ImQOVarRl+qlZx3ASc+TBgBCj3Fr0O7i4x0Vl9qMr9Xi1Y8z9AdMlZNStkF+FL89tkbgeOIe3TEIIB8ty6nffxuppE5pESUhc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783823126; c=relaxed/simple; bh=JJ+d0rT8eu+CFW19LY64aYRS/dGQq0+3I2i1YebFK/E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ExKQ7zcsAh1RiaGM8ThIxkdi+ncxh35xmx0PWLPj/QxtFOkZ99PMQ154TnaRP7pgKdAie199FKF6SKAQUBzJ5t3niPSjX52jNWVn1vMncooVvpRmVEH9ULDJEROGOF+L2a494I389NvzCEa/rMSX/mKABFV5qxjg1ZOAdMq0Ss0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=pass smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=Bs7rDmvO; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="Bs7rDmvO" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c9c26a5fb98so1249444a12.0 for ; Sat, 11 Jul 2026 19:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1783823123; x=1784427923; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=P20skrUm4HZS8JTk5TGJZTP7YmJdI0Mg5/mxR9z/xBU=; b=Bs7rDmvOXlBbLKD2uudF78ZFszPUCtACDm6nZrhinIYBRD0A+VNwQh6Di1YOlkwAy8 6N9tPSwTbwBd9VCEPbRIC8ebYHvcMwI+iDy2MvT/ThU5b3i+VDUMYirjW7X7w6NmK4FP vhAmy6tfI9jaE9rBk2uSdk7sZFaIhdDDpWttJVz5NZP8UYFM7djAuiJ+rnkhmryAgoc/ hnrI53KJfjg6WUQf6dpmFw8dQqN1n/MxCV4Nmyugh4Kb/uami156egSBTOAUdipmHuVq EA3EMU+uHN6X++HNXylyR215DxSLNIHlAFeR3CgV6lw8DkLKosBit5FN/GexYIz+5pnz M6cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783823123; x=1784427923; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=P20skrUm4HZS8JTk5TGJZTP7YmJdI0Mg5/mxR9z/xBU=; b=YGSzk5PHOCWQN5veHdh20zMCHdgO6r++Go1q7F6a3/DnFWxAo7wJLQKZdmGaXKY10B URERz+wMniqMazWgdI09/8eZCSdL2Dmf7CGrqw7OCfQo591jH+c5fuQL/kPluujZ76VK B3arhSMp/21KfH92BkI6BALPMcYjrZJUtkTF5nKl8T11IczxjB1InT/PqtwST8fS8imq EtNaimlYnjYvpC0nwVxrA0kxggLx2QjnpcWAHtTK75tGbE2IjBafZ7KqWKT6whL+3HZE oX7PPYbTnLSVPRu81lsQzrc8LTU+05nTaeXEiBZuvPAJfQ/0w8W1lvFbrjJKsL4SeFct 2R+g== X-Forwarded-Encrypted: i=1; AHgh+RoWC+9nc7eFdoJjxKoMxKgJhth0uN4qEHpYh41wk94TN+9Y33Iu5VI6Ar0erFNMSGrQhyOwrZNmhf+UxmY=@vger.kernel.org X-Gm-Message-State: AOJu0YyXHpLxQk7o4+iWYmew7s2zQU3Iwglvlp2TQmjPTiUhPkwNdktg WAsP7bmuNoIT7EL/DROVNWuXjc8FzmGATcJAzRBgiTGm/ApgTNTuRQRrgdwv6qxNuEU= X-Gm-Gg: AfdE7cktYW9SNEeyL8Cpcs1C925PqNPki0UvXoRQMT4JXydf4HPCuaWsfXj/KyF5vzk 5Pp2RhAbUH6kDB3Z/Zyoi1FhT9y0eXf+SuQoLmDOeqtcnbISYhWKpS53qRmJivzQgJwm5v19IbO mMQPk+owBNy0GnBHtD+PrccFXEhTHNYbPiQ52xUEaxVWR7dImLIBkRWUswcZa45uIoWC5EpSC/q k4f1qw+e6K0To75DCHmVoyHnhUnRpZUK2oY74wkCUfa+YRg/rt5Uqq0AZ1ARdJDlkV5X2RyohwA N8lxEBXboNnesj3LzCGBLHqQqtnpvBFjIg8+stYQ2iGbzDXOEZvJ5CsTdgn/EYJVy/yU7zNp9Yl UBNeHpAnzmDaDoKHzHFZZW6tk/PFKbLbqpyzpEHVFip1iuy+SgouDy/hqHr1WhweWOuLZMoUwqi omNiqu X-Received: by 2002:a05:6a21:6115:b0:3bf:aa54:4cbc with SMTP id adf61e73a8af0-3c0f0b6fda4mr9262734637.26.1783823123312; Sat, 11 Jul 2026 19:25:23 -0700 (PDT) Received: from ceto.lan ([2607:fb90:9c20:2264::1c31]) by smtp.googlemail.com with ESMTPSA id 5a478bee46e88-3117462f5c7sm60704693eec.0.2026.07.11.19.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 19:25:22 -0700 (PDT) From: Mohamed Khalfella To: Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , James Smart , Hannes Reinecke , Randy Jennings , Dhaval Giani Cc: Aaron Dailey , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Mohamed Khalfella Subject: [PATCH v5 04/16] nvmet: Implement CCR logpage Date: Sat, 11 Jul 2026 19:23:25 -0700 Message-ID: <20260712022437.3743117-5-mkhalfella@purestorage.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260712022437.3743117-1-mkhalfella@purestorage.com> References: <20260712022437.3743117-1-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Defined by TP8028 Rapid Path Failure Recovery, CCR (Cross-Controller Reset) log page contains an entry for each CCR request submitted to source controller. Implement CCR logpage for nvme linux target. Signed-off-by: Mohamed Khalfella Reviewed-by: Hannes Reinecke Reviewed-by: Sagi Grimberg --- drivers/nvme/target/admin-cmd.c | 44 +++++++++++++++++++++++++++++++++ include/linux/nvme.h | 29 ++++++++++++++++++++++ 2 files changed, 73 insertions(+) diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c index 1b97e1bafa30..ea2566a9b83f 100644 --- a/drivers/nvme/target/admin-cmd.c +++ b/drivers/nvme/target/admin-cmd.c @@ -220,6 +220,7 @@ static void nvmet_execute_get_supported_log_pages(struct nvmet_req *req) logs->lids[NVME_LOG_FEATURES] = cpu_to_le32(NVME_LIDS_LSUPP); logs->lids[NVME_LOG_RMI] = cpu_to_le32(NVME_LIDS_LSUPP); logs->lids[NVME_LOG_RESERVATION] = cpu_to_le32(NVME_LIDS_LSUPP); + logs->lids[NVME_LOG_CCR] = cpu_to_le32(NVME_LIDS_LSUPP); status = nvmet_copy_to_sgl(req, 0, logs, sizeof(*logs)); kfree(logs); @@ -606,6 +607,47 @@ static void nvmet_execute_get_log_page_features(struct nvmet_req *req) nvmet_req_complete(req, status); } +static void nvmet_execute_get_log_page_ccr(struct nvmet_req *req) +{ + struct nvmet_ctrl *ctrl = req->sq->ctrl; + struct nvmet_ccr *ccr; + struct nvme_ccr_log *log; + int index = 0; + u16 status; + + log = kzalloc_obj(*log); + if (!log) { + status = NVME_SC_INTERNAL; + goto out; + } + + mutex_lock(&ctrl->lock); + list_for_each_entry(ccr, &ctrl->ccr_list, entry) { + u8 flags = NVME_CCR_FLAGS_VALIDATED | NVME_CCR_FLAGS_INITIATED; + u8 ccr_status = ccr->ctrl ? NVME_CCR_STATUS_IN_PROGRESS : + NVME_CCR_STATUS_SUCCESS; + + log->entries[index].icid = cpu_to_le16(ccr->icid); + log->entries[index].ciu = ccr->ciu; + log->entries[index].acid = cpu_to_le16(0xffff); + log->entries[index].ccrs = ccr_status; + log->entries[index].ccrf = flags; + index++; + } + + /* Cleanup completed CCRs if requested */ + if (req->cmd->get_log_page.lsp & 0x1) + nvmet_ctrl_cleanup_ccrs(ctrl, false); + mutex_unlock(&ctrl->lock); + + log->ne = cpu_to_le16(index); + nvmet_clear_aen_bit(req, NVME_AEN_BIT_CCR_COMPLETE); + status = nvmet_copy_to_sgl(req, 0, log, sizeof(*log)); + kfree(log); +out: + nvmet_req_complete(req, status); +} + static void nvmet_execute_get_log_page(struct nvmet_req *req) { if (!nvmet_check_transfer_len(req, nvmet_get_log_page_len(req->cmd))) @@ -639,6 +681,8 @@ static void nvmet_execute_get_log_page(struct nvmet_req *req) return nvmet_execute_get_log_page_rmi(req); case NVME_LOG_RESERVATION: return nvmet_execute_get_log_page_resv(req); + case NVME_LOG_CCR: + return nvmet_execute_get_log_page_ccr(req); } pr_debug("unhandled lid %d on qid %d\n", req->cmd->get_log_page.lid, req->sq->qid); diff --git a/include/linux/nvme.h b/include/linux/nvme.h index 7e6150d9494a..70dd0770e032 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -1440,6 +1440,7 @@ enum { NVME_LOG_ANA = 0x0c, NVME_LOG_FEATURES = 0x12, NVME_LOG_RMI = 0x16, + NVME_LOG_CCR = 0x1e, NVME_LOG_FDP_CONFIGS = 0x20, NVME_LOG_DISC = 0x70, NVME_LOG_RESERVATION = 0x80, @@ -1466,6 +1467,34 @@ enum { NVME_FIS_CSCPE = 1 << 21, }; +/* NVMe Cross-Controller Reset Status */ +enum { + NVME_CCR_STATUS_IN_PROGRESS, + NVME_CCR_STATUS_SUCCESS, + NVME_CCR_STATUS_FAILED, +}; + +/* NVMe Cross-Controller Reset Flags */ +enum { + NVME_CCR_FLAGS_VALIDATED = 0x01, + NVME_CCR_FLAGS_INITIATED = 0x02, +}; + +struct nvme_ccr_log_entry { + __le16 icid; + __u8 ciu; + __u8 rsvd3; + __le16 acid; + __u8 ccrs; + __u8 ccrf; +}; + +struct nvme_ccr_log { + __le16 ne; + __u8 rsvd2[6]; + struct nvme_ccr_log_entry entries[NVMF_CCR_PER_PAGE]; +}; + /* NVMe Namespace Write Protect State */ enum { NVME_NS_NO_WRITE_PROTECT = 0, -- 2.54.0