From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE975367B89 for ; Sun, 12 Jul 2026 02:25:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783823129; cv=none; b=Q84wcfbgdmDv6+q0IE5Fb7pvvyAIoVKoDoNsGqlvM3W3Kdi6xG+052i4BLa4fChuJBt+Nuvibg6WE3ZoGVjbmbeSmhIxT/jRxOk/y5roaGMeotKoAukMR7vchQH+o3zN8oSCPcSGBaum8Aw0BvOVuDAFWk8eHdQpbuPNZetCfZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783823129; c=relaxed/simple; bh=pY4cn64kyD+lHfYXGmKvHDXhgI+b16Mx5EmMGalia3w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jS1fm0kXpC6VKw7X/kFW9JYm/J1pc4+FrG9A7FzteIyDb+4TU3KaBSP9jCLY348JmRJuvlpfftjUNToq89GYmXqCpL8/2O5hwjjJ9ZnsyumAJ87enREbgUGpWHIsodES0SwnJ73Tf1hxulIBzStBGUdXKIH8SzjODA9hP9jZSAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=pass smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=ZEfJlk4M; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="ZEfJlk4M" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-ca7c1176317so1545939a12.1 for ; Sat, 11 Jul 2026 19:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1783823125; x=1784427925; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XL1bNu+U9GqDErYJpXpnJDbFEHkKBxgfcViduksku88=; b=ZEfJlk4MlWioKLk6AFv7uyaFInT6xfAMw+hQDogh6Wic8dJa3gMaclCUsE/5H9Jnws uWFfNyaUyL/2FF2CerRSpHks2/90SgZAqEtvWsYsHgCBXwnRwWcBtJLoN6p5nUPnkxtS JjJPLxlSmmfh76dzGF1+HMmfWgHn5g9zfJYAqNXWdxm4+LOXlaWhLfhYZssDmeR1K8Ye 0uuxXaHOx80a3OD7+d8URekTaJS9ItIbbi9h3kzsFT/zb6UGGfUNJR4AIhckgjfBOXKy mxKa54KHp7tvv0W17E0WXsJ8PmL1u+WwatwdIjgKe0Q5V0vNjO7rOEw7l8R68ECK9OPY PWcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783823125; x=1784427925; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=XL1bNu+U9GqDErYJpXpnJDbFEHkKBxgfcViduksku88=; b=flgoef2jX+6y4SjVxhy7U9K2r8Ug2mnXtmuQTKYLqm1+fm+s+QlUn7MfXJntQvUY7i p96qHBkuwWpYXIJJlsbhBc+jhvxFPLMeZxbYq1wS5TLWU/eP4cVKQhBAcqCQiaEAj4oT vo+AhDcWbkcdPyodN2SUoSLwra2IjGqrYznRFmxDEfmHNf8glTXQZ2FAdFEdugaOBJXG 9UsKeXIQrQlBGSNUGmv2ysIi/rX3Kvi5hR8sf6P495uUUQ7ETSQOF4i2pCAPur9y0uYv bKd6dsRhW9lm/AtxgEGaSEYHL3Qx3ho+GoyZKVh92ZzC78JImfgeCo8tHSMRK4ZMpgLg HIcQ== X-Forwarded-Encrypted: i=1; AHgh+Rru27CH8+2+7weSJqzEagz+vUrKa70TJODnmNXZBAmeFm7ZVQf65Gw+VbdmoLeDzLTtdsecRqx5BbcqEvg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw310iCHOo+qIeANyugrSU+DkUmT99sSaLdlfB6czkOgUDEWsRw hPcIYckQgohrkk2x11JJCTdd79YJU8V0FTZ6lMzNNMcfuK2xX4q61Xbz8uDMHG3/v/g= X-Gm-Gg: AfdE7cmM5WreNxrRZRRhTrQBXK8uyhgWfeddMJjYPu6T0XTp93bmMGUD1blHpwcsH9T fnP5SCx+jUoWrZAlffVBuSdM8tbN58k05/wwAwwnHd2vbsZK23CRwlKr0DTpHra4s+arrEN6Jzw RSJU0fql2lgiIVAv0tAO9pcmBG1j9ht8/zQppInQuyzMBqXSVCrPeamsCcmD99vTNaOcQYCIcSH kLcQM8vKkgcqZ0ZkPgvUrLNjTvSJjNpbGRFqrUi8aTAYVd9qIzWEiEiOKEk+69Cgo+6Kd9jd0Qe DfQesb+/Cjv2aKPhtFGyQdC3ZYW61vMVwia1UkPAKDsd8RRBlA0kmaQs2p41qIhu9Vpxg/KHhIP AChn5yZchR8zMd4AJwTuB/jRE2BLU3apGBBZOYdD2EuLjwb27yD+E4/xvTK7b+BRQLcC3CYjGev kfLNJf X-Received: by 2002:a05:6a20:72a5:b0:3c0:9c19:65bb with SMTP id adf61e73a8af0-3c110a6e389mr5138000637.67.1783823125107; Sat, 11 Jul 2026 19:25:25 -0700 (PDT) Received: from ceto.lan ([2607:fb90:9c20:2264::1c31]) by smtp.googlemail.com with ESMTPSA id 5a478bee46e88-3117462f5c7sm60704693eec.0.2026.07.11.19.25.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 19:25:24 -0700 (PDT) From: Mohamed Khalfella To: Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , James Smart , Hannes Reinecke , Randy Jennings , Dhaval Giani Cc: Aaron Dailey , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Mohamed Khalfella Subject: [PATCH v5 05/16] nvmet: Send an AEN on CCR completion Date: Sat, 11 Jul 2026 19:23:26 -0700 Message-ID: <20260712022437.3743117-6-mkhalfella@purestorage.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260712022437.3743117-1-mkhalfella@purestorage.com> References: <20260712022437.3743117-1-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When an impacted controller that is the target of pending CCRs is torn down, send an AEN to each source controller that issued a CCR against it. The notification points to the CCR log page that the source controller can read to check which CCR operation completed. Split nvmet_add_async_event() into a locked helper so the AEN can be queued while ctrl->lock is already held. Signed-off-by: Mohamed Khalfella Reviewed-by: Hannes Reinecke Reviewed-by: Sagi Grimberg Signed-off-by: Mohamed Khalfella Reviewed-by: Hannes Reinecke Reviewed-by: Sagi Grimberg --- drivers/nvme/target/core.c | 25 ++++++++++++++++++++++--- drivers/nvme/target/nvmet.h | 3 ++- include/linux/nvme.h | 3 +++ 3 files changed, 27 insertions(+), 4 deletions(-) diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index 5b4312227222..9b16b15f5093 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -205,7 +205,7 @@ static void nvmet_async_event_work(struct work_struct *work) nvmet_async_events_process(ctrl); } -void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, +static void nvmet_add_async_event_locked(struct nvmet_ctrl *ctrl, u8 event_type, u8 event_info, u8 log_page) { struct nvmet_async_event *aen; @@ -218,13 +218,19 @@ void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, aen->event_info = event_info; aen->log_page = log_page; - mutex_lock(&ctrl->lock); list_add_tail(&aen->entry, &ctrl->async_events); - mutex_unlock(&ctrl->lock); queue_work(nvmet_aen_wq, &ctrl->async_event_work); } +void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, + u8 event_info, u8 log_page) +{ + mutex_lock(&ctrl->lock); + nvmet_add_async_event_locked(ctrl, event_type, event_info, log_page); + mutex_unlock(&ctrl->lock); +} + static void nvmet_add_to_changed_ns_log(struct nvmet_ctrl *ctrl, __le32 nsid) { u32 i; @@ -1796,6 +1802,18 @@ struct nvmet_ctrl *nvmet_alloc_ctrl(struct nvmet_alloc_ctrl_args *args) } EXPORT_SYMBOL_GPL(nvmet_alloc_ctrl); +static void nvmet_ctrl_notify_ccr(struct nvmet_ctrl *ctrl) +{ + lockdep_assert_held(&ctrl->lock); + + if (nvmet_aen_bit_disabled(ctrl, NVME_AEN_BIT_CCR_COMPLETE)) + return; + + nvmet_add_async_event_locked(ctrl, NVME_AER_NOTICE, + NVME_AER_NOTICE_CCR_COMPLETED, + NVME_LOG_CCR); +} + static void nvmet_ctrl_complete_pending_ccr(struct nvmet_ctrl *ctrl) { struct nvmet_subsys *subsys = ctrl->subsys; @@ -1819,6 +1837,7 @@ static void nvmet_ctrl_complete_pending_ccr(struct nvmet_ctrl *ctrl) list_for_each_entry(ccr, &sctrl->ccr_list, entry) { if (ccr->ctrl == ctrl) { ccr->ctrl = NULL; + nvmet_ctrl_notify_ccr(sctrl); break; } } diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h index de088986cb4b..da80377c3795 100644 --- a/drivers/nvme/target/nvmet.h +++ b/drivers/nvme/target/nvmet.h @@ -44,7 +44,8 @@ * Supported optional AENs: */ #define NVMET_AEN_CFG_OPTIONAL \ - (NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_ANA_CHANGE) + (NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_ANA_CHANGE | \ + NVME_AEN_CFG_CCR_COMPLETE) #define NVMET_DISC_AEN_CFG_OPTIONAL \ (NVME_AEN_CFG_DISC_CHANGE) diff --git a/include/linux/nvme.h b/include/linux/nvme.h index 70dd0770e032..3757d11ffea3 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -871,12 +871,14 @@ enum { NVME_AER_NOTICE_FW_ACT_STARTING = 0x01, NVME_AER_NOTICE_ANA = 0x03, NVME_AER_NOTICE_DISC_CHANGED = 0xf0, + NVME_AER_NOTICE_CCR_COMPLETED = 0xf4, }; enum { NVME_AEN_BIT_NS_ATTR = 8, NVME_AEN_BIT_FW_ACT = 9, NVME_AEN_BIT_ANA_CHANGE = 11, + NVME_AEN_BIT_CCR_COMPLETE = 20, NVME_AEN_BIT_DISC_CHANGE = 31, }; @@ -884,6 +886,7 @@ enum { NVME_AEN_CFG_NS_ATTR = 1 << NVME_AEN_BIT_NS_ATTR, NVME_AEN_CFG_FW_ACT = 1 << NVME_AEN_BIT_FW_ACT, NVME_AEN_CFG_ANA_CHANGE = 1 << NVME_AEN_BIT_ANA_CHANGE, + NVME_AEN_CFG_CCR_COMPLETE = 1 << NVME_AEN_BIT_CCR_COMPLETE, NVME_AEN_CFG_DISC_CHANGE = 1 << NVME_AEN_BIT_DISC_CHANGE, }; -- 2.54.0