From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2723033A9FF for ; Sun, 12 Jul 2026 16:05:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783872326; cv=none; b=QaGFca3cN+MDvpOVibb8hRI1YpxpJyTl6EOEdf8rylNvhsf98i9bRMLt1dvMDVJYWJ0zxYD0EpH9MLbQWI2atZl6I5y2EbQ6bagpwACwJybn/M2zp4xRknXSe3Ql1lic4k3CxKXm/lLEVT/FSbDPA9bu+0066ZK9P1QFY4877nQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783872326; c=relaxed/simple; bh=HYdCz1xlLgU2B4rg61F8c5q4VwIZtY9jojDIygIHVSA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=g4DjaY5CC2EdRl9f6V/h91hkftXYb8Mnoj6NwfesMiK3UJFwCuxony7WcwmnVSNKrOvDmyoYCPCPB9NrwhDjLDF151FcGjHJlAAw83H7v9MEzWEB0IOhBOComgd+eAMgrYLn/sQ8nCeLWCaUpgoeu/P/zjCOSZGL1mbxFWbV98Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c89636920a3so1217793a12.1 for ; Sun, 12 Jul 2026 09:05:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783872324; x=1784477124; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qGY7taiLnmCSVR1KjiFJzcvjfx5XvByeFDnx9S/k8nE=; b=ArSpcTIHiT71qMfDxYBu9u+7i7GxQolr8qLMHCms2aly643GEA8RRdDZgktfr2v5UV rF5Cl3aRqPoQvQM2TbxAqiqoX9KNY1YZBoCDQzxQAbXs4Q3qo7j/Ev5tl0qXsGC671qI rMPcra8A2z2BFJqxpSqppvck6MKMEVcgQ0AhC2KUn1yr5pjCwKy414vBsbK+gmjc1ecM pKbZIs+lhJFOMvQEBZhY2a0PyJloXkbDCmsfYOTvJjkV9PMZMZyUsW1hhgrRk/8enA4J 3HcWumB6KXnHIi7L/PCdnI7jinXOBMVGcMMd2ZPHp/zoGeRxkW4tT7X+5Eiy0/BJYp70 NSpw== X-Forwarded-Encrypted: i=1; AHgh+RoexV0hoc3I67UrtDemBVm9B1QK+TkaeMlZ/a2IS2lZfVEObrEYHnxrn6Is7LxuPeAX4JwhGe/Rt7/lcV0=@vger.kernel.org X-Gm-Message-State: AOJu0YxkuwMWq6kx3soQf7ZCloTSyKhvyRB9VY3wZD5MGEkqHoxvCh+p J5lUDswCDuoRPkRJjrY84dR2wEafVmJS7hZgfwt2R98gXCOElHboEdM= X-Gm-Gg: AfdE7cmY57qXL8wjP2ezlaKdIq1OA5no9nLd+glENKNu0s4IuBOfQjFX9ZtV4AQvIKJ rWUvyy14LD/zkdg4EsHFBhKy4GMKwRfXxMXz/QFDJYbmesjPl+TdWZ4ToRGfdVTTW5E4WV81s2h CBaFcH1Fs/EPhBGxWqk38L6NEcUoVBrA5QcOMjMLMimvxxVxYcKjiA8i2DHDpmRdXLPPPXOD+Tv avFh7898UMy+G/AZ46TL/yPOSvrN5bbQ0+cXCV3oH1zGqYisAA5FLgEbnyh/wGKJrDU8+HVJMuR QaliJAvM1Uk+UrzRLDJKSs0gnh/sIykTytQ6Q6jj3v81apWhgkYTVJhgBm5gADWiGZ0SG5LmXFh I1scLFyEjDVqObQEpP26ZRmpwPePrwGD9iN9Ex7KQYSfNe16tM4AmGebKXKc8Dxrp+ml/iloNIi pFclV5aC/Yy9FBOSRRRgIFMJsBT3gR05liXggosLrWGN9brcCeAwoazvSw1eVb70FqStAyCSHG0 bmIRVvPyc9K/+l9w+a1yUuMHj7Doo7bqduLCR/A5xIzX674qg== X-Received: by 2002:a05:6a21:4cca:b0:3b4:8a40:85ed with SMTP id adf61e73a8af0-3c11077686bmr6203955637.7.1783872324462; Sun, 12 Jul 2026 09:05:24 -0700 (PDT) Received: from penguin.tail0a1999.ts.net (61-228-44-142.dynamic-ip.hinet.net. [61.228.44.142]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3162a49sm7156667a12.15.2026.07.12.09.05.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 09:05:23 -0700 (PDT) From: Shih-Yuan Lee To: Dmitry Torokhov , Mark Brown Cc: linux-input@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Shih-Yuan Lee Subject: Re: [PATCH v5 0/3] Input/SPI: fixes for MacBook8,1 DMA timeout, UAF, and NULL pointer dereference Date: Mon, 13 Jul 2026 00:05:16 +0800 Message-Id: <20260712160516.7265-1-fourdollars@debian.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260711055247.5412-1-fourdollars@debian.org> References: <20260711055247.5412-1-fourdollars@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Dmitry, Mark, and the linux-input/linux-spi community, Thank you for all the feedback across v1 through v5 of this series. During further testing on the MacBook8,1 hardware, I discovered two additional issues that change the scope of the fix: 1. The LPSS SPI controller (00:15.4) loses all private register state across S3 suspend/resume. Restoring only the SSP clock on resume, without de-asserting LPSS_PRIV_RESETS (0x204) first, causes a PCIe Completion Timeout and a watchdog-triggered system reset. Additionally, the IDMA block (which shares the SPI interrupt line) needs its registers restored to prevent spurious interrupts from masking real SPI transfers. This is a generic LPSS fix in spi-pxa2xx.c, not specific to MacBook8,1. 2. The applespi_remove() teardown has a use-after-free race between the drain_writes/drain_reads calls and the GPE handler removal. Given these changes, the patch series has grown and now spans two subsystems more cleanly than before: [input] Input: applespi - register touchpad device synchronously in probe [input] Input: applespi - fix use-after-free in applespi_remove() [spi] spi: pxa2xx: disable DMA and fix runtime PM for Apple MacBook8,1 [spi] spi: pxa2xx: restore LPSS private and IDMA registers on S3 resume I will submit these as two separate series to linux-input and linux-spi respectively rather than continuing this thread, to keep subsystem boundaries clean. Thanks again for your patience and review. Shih-Yuan Lee -- 2.39.5