From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: driver-core@lists.linux.dev, "Danilo Krummrich" <dakr@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lyude Paul" <lyude@redhat.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Zijun Hu" <quic_zijuhu@quicinc.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] driver core: faux: Move a variable assignment behind a condition check in faux_device_destroy()
Date: Sun, 12 Jul 2026 16:09:34 +0200 [thread overview]
Message-ID: <2026071217-fruit-uphill-eb0d@gregkh> (raw)
In-Reply-To: <1fe66c80-dfa5-4ef1-aec0-8f7fc3f2fe21@web.de>
On Sun, Jul 12, 2026 at 03:56:09PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 12 Jul 2026 15:45:19 +0200
>
> The address of a data structure member was determined before
> a corresponding null pointer check in the implementation of
> the function “faux_device_destroy”.
>
> Thus avoid the risk for undefined behaviour by moving the assignment
> for the variable “dev” behind a condition check.
There is no such "undefined behavior" here, sorry, please fix your
tools.
next prev parent reply other threads:[~2026-07-12 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 13:56 [PATCH] driver core: faux: Move a variable assignment behind a condition check in faux_device_destroy() Markus Elfring
2026-07-12 14:09 ` Greg Kroah-Hartman [this message]
2026-07-12 16:23 ` Markus Elfring
2026-07-12 16:39 ` Greg Kroah-Hartman
2026-07-12 16:54 ` Markus Elfring
2026-07-13 4:44 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026071217-fruit-uphill-eb0d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Markus.Elfring@web.de \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=quic_zijuhu@quicinc.com \
--cc=rafael@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox