From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D99F43438A0 for ; Sun, 12 Jul 2026 16:38:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783874311; cv=none; b=tyrvrYZ7VygHmBjHc3ZWdnRd3ess2oJLdwc53tA7Hv6V54SumrZhGCLjC9S1WYJi6v/1QLZKK6BVI+0lmFo/7/Cslq9r/ePGETztaJ2QeX1Q64QFZngX/pt1k675my8D6DyyQ9HUG1Gq+Uv+GjjCrgmjDwBMb9AZsFu5LKzNKoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783874311; c=relaxed/simple; bh=WgpVXf8J119QoGJHXRfX5ufe5hIxEJOs0qPmFfcdhPs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fCOVjkQ/lHtyoZHqUWWRsnq9/33O7I8X3q6x3jE3X05oiu0Sg9arVxf6BQgtqsfRn1jA5/epZ6ndakZGlcTTHZ/ROHZ3mNk3zx2NSSRkQWfY9MuGssdP0wwJTjvmyJy1HN7HWaItA2/z2YJq7kVANqWGzq4zF1s/IwbzrKncnoU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K1VG+rcQ; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K1VG+rcQ" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-493f45e206dso10552835e9.1 for ; Sun, 12 Jul 2026 09:38:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783874308; x=1784479108; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=oBeqD+zoXhOUQV1xacnEku0uxvNUMotgOTqmmTw8mQQ=; b=K1VG+rcQ38wNJFOMXNezIxl0ioUheUbNzcgI/y37rOZTT97VnDT5NQXpKByPAkTD0S DADqLFhpI3Nj9jFSP5V6AUyYmZmX2Pv//GiManGFGV68mpGIF4eKKec58UdInRvEermq cdNYAhZkvGhjAwj5rEoQFhtehHxv9UCXQ5vsVCgQCL9/VbNAy0OBnFSIfyk7eie25dVx /VkdXvnXt2hci6g+tptIzMjHfy2Vn6nZrbqWIpQ10IIx47K/RkhEfm4Tmw3Upjo2uLbl olMk0jwhCUdB17GMiUeQTFbi7sOrucwuuV8hrjr114GlTAJqICS3HypRgFckbUHT22mX +tyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783874308; x=1784479108; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oBeqD+zoXhOUQV1xacnEku0uxvNUMotgOTqmmTw8mQQ=; b=ec9QjWV4qsyh6byqdGW7G/B4bPxv22mGVT74XXINHLw35fCztE7vb3P2N2paNs0T8A XF3xqGgmJjeNaEX6IbgkhvEY2D+aIE5lEDVCdlB9VBQpfL4/cujmJaulcOkwJyYeUR6S IKjUuGluOmsg4sEivGRw6LaSFn0ux1bsfJ18d0VpHjy6RRjPbYxN61pieczD+Hdw8xHX 0XFtl3hUHVrgGfplfY8Mpk1bwSm8VpEizmcHRh60RaWPzHpRMvdwAr7huSaoR3AVm2eY ZoPFh9GqSb+wAW3FWEQTuzteslabzJa03luwsgWeHD8Bm7GqjcbiRpToiQ1V1q8SSGqC 9P2A== X-Forwarded-Encrypted: i=1; AHgh+RoGzx7WEutynQ7Ay9tfJNAVDxQiOcT9bZOvRmbark4v3ToQvDD9pj4nCrCzoGGr785Ts/WGLP4Tiwp12gU=@vger.kernel.org X-Gm-Message-State: AOJu0YyMWEbt/K1IZZZIsjHH6cHavwzq1NzxeUhbzn2lj/kTXJpEgaP+ UyCP4zgWTcrBRIxEi6hQnqIXGjusF5RIFMkdq+Oo3wlqZhdre9Mbrjde X-Gm-Gg: AfdE7cn/Cd4jKXS+pWuOlp6d/g81pv6ukij2DcdnMnOZ7pybosk0SS8908GOOSbprPW roM+zgyDDpHA+2Djy21gUqepCqkR6ktojUZplc0MeUhMmLLZ55+G7Mj/nQKzIPamdK3GCI9N4hN GJIjGZ4caM8YhY1JlbraSyElU1ZBUhGVUyy0d3v2HTpXDki//gMD49mjDZpzs4XHgpQTu+APwax d/5N7Umk1243qmMl8vhASu7YJ/TB+UJwrFHEcwsNzXyWWFnzhve/+kNZnWNa/+MhGGlEaN/pSwH 7z3isi8bowbFzO+ACAXQ8NiT/NVwWLX63DSTuWroI3hygT1JThayVVydua3H/3BY3/zrUiU7vGM NhOU1ZPwmMgm1aBK2xv1rfy1JBBCBi79XXQRMTYQJl3FG5+aHEhIC5CaEsZRo9MWOHLhNi18A1U u6qmAYs1abLQlcPReHeKrSRYL0RKSQlMNdAN3Zu0mwACOP4n07TWjvTbsSfnkqjvNkIS3xrddgt NvX01Lqgh79Si2LWhVYCZ7LYFJNq7FlHRT6gIk7bpjFvQ1jbQKnDNZcr09PJF/mz38Y4YzigJ+T gOy6pY2moAjS07+vjbaKsqIWUIBEvqgPHQKe1RannSOfCLmeaw== X-Received: by 2002:a05:600c:1391:b0:493:d117:18a8 with SMTP id 5b1f17b1804b1-493f88bd849mr68661845e9.9.1783874308011; Sun, 12 Jul 2026 09:38:28 -0700 (PDT) Received: from systembl0wer ([2a02:8308:4092:11f0::f9f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493f2a2e499sm227660225e9.0.2026.07.12.09.38.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 09:38:27 -0700 (PDT) Date: Sun, 12 Jul 2026 18:38:25 +0200 From: Joshua Crofts To: Andy Shevchenko Cc: Jonathan Cameron , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] iio: light: opt3001: split opt3001_get_processed() logic Message-ID: <20260712183825.1f3dcf30@systembl0wer> In-Reply-To: References: <20260712-opt3001-unwind-cleanup-v3-1-5fa336876b08@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 12 Jul 2026 16:58:55 +0300 Andy Shevchenko wrote: > > + ret = wait_event_timeout(opt->result_ready_queue, > > + opt->result_ready, > > + msecs_to_jiffies(OPT3001_RESULT_READY_LONG)); > > + if (ret == 0) > > + ret = -ETIMEDOUT; > > ret is int and for holding an error code, with the above ret is rewritten > with positive number and might lead to subtle issues. The recommended way > to handle is > > if (wait_event_timeout(opt->result_ready_queue, opt->result_ready, > msecs_to_jiffies(OPT3001_RESULT_READY_LONG))) > ret = 0; > else > ret = -ETIMEDOUT; > > or something like that. Sure, I can do that. ... > > + if (ret < 0) { > > + dev_err(dev, "failed to write register %02x\n", > > + OPT3001_LOW_LIMIT); > > + return ret; > > } > > > > + return 0; > > Also can be simply > > return ret; > > in both branches. Yeah, I agonized over this since I did the change you describe in a different patchset, and I was advised to do it the way as I did in this patch so that it's more readable (i.e. we know which path is the successful one). I'm really indifferent to either change and it doesn't cut that many lines. -- Kind regards CJD