From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F377A343892 for ; Sun, 12 Jul 2026 16:52:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783875162; cv=none; b=p890bF7McuPv2momjm2SlLYv28l/2t9w+EXyKflJ/OSeR7NIQMTkjKURIknLiKZUeq+Tbn4t/Rjd+oD4378eUzyPWqDdhl/QAUkTrHxFpsqkJrGW7lApCliAVHJsH5WkYwAg73hIpdXTuTQX16rZxOzvYL7tXgvsAlIXbzVUo8g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783875162; c=relaxed/simple; bh=UTKGHyqJokQ3z0ueIulz6onYQgIIDqByTP14Kr6nXpk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fsKDNuRZ7LSYLkqmB7w6AG5hxDT18EXKqpSbHdDELhnk7oi1TEmJk4SMnZHloSymEu24/+RcX8BK0kz9XFVep43zT51VwqG/GCM3R2P5rnfRB6N5oFrxz0QIJFQwek+U5vqYr++3jWK/5ViN3Za3fh5keMbnXzyDz7PP+33g1/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E72D9sZX; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E72D9sZX" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-493b27c7451so41770245e9.0 for ; Sun, 12 Jul 2026 09:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783875159; x=1784479959; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=W3IGUctqSRJukmRUvJ2jjgPy3v1eQvtxkdxkcO/xYck=; b=E72D9sZXFALzNbtUUtBPLD5AWd6T9yG0kguwKHqVxDZlksI7ZylGv8JXndnaCJd/HU Mql4Hgv9KJtoN6osqXJtZWjVAZlUvPfwnOlx0ykyt8m8pQRAhB1XXYu/AJTmYsjZPv3a NWEoIz2TDo6LtTyf9/84WH36Vst+xcfj23pf9Kn9bFieDl0qtqrdWt0IRMVKSgnG2TJq 6cWaoflE8PZDcCjNt3ukM4tBXpwKsFOradtdcSZkFF9SZA2ErTl3hVbSbXnayMFuJjvz y851n/SEfBkdb8QhSFsU2cX5sqdRaR0E/1+1W9tJRJoGbshGa1YBuy4q+urK/n1wDe1Z UUaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783875159; x=1784479959; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=W3IGUctqSRJukmRUvJ2jjgPy3v1eQvtxkdxkcO/xYck=; b=P6kgzWgbQiKXSqbE6rBA3U5QTHIbHMHTymTzye9h7qy1vVf4AzrnBDXrSMKZt1SRTL 20Pq/d7/SBHn98ETYm4GSNyimsGHRHCmzJU6sOQz9NgtDmCVJOLBZ5kmPiQGd5x+XVkN WEAK6IxUusrc6Huhtpdirafc7BYihL/HQD0AaMxlpa/n06fJy6wtV9VptR73fphQXjwr FT/GN6qJOiHY4b44c3b7jt/CE51Q3tg91R4n+jRWRI5eTzcHRG9hVnq0QD7Mi/sH/0g9 m9BeU5JgofygTTcv7XcxJg/tmskZbYcfaRWPdtxl1yN2mWgVqjyOqXlpQfZiqiLfiGgj Sl3w== X-Forwarded-Encrypted: i=1; AHgh+RpB6aLc3tM5HsGCVw8H1mVjCW1Rv7h7RRQR+CexlSov5TqE4xlai681Ux6d+lvMBDGlY/1okQMpazkh6Jo=@vger.kernel.org X-Gm-Message-State: AOJu0YwLMVoE7JOxg7QBaeZABZRoCNRlft7kjYtbIy1fONaGlgKZMGU6 YHkFxOmTO+v47cpY8KTHQrlnRdg2kf+2Pff08Ml3D5U7sPLSIPrgxZmg X-Gm-Gg: AfdE7clK+2uILZzozXOxQ2+LonkQYlbvg5UrL8VQlw07CRtCUTVE9utngJw66zM9ash kFmryu4JH8NXPs/2FoWMaQ5a6YzlINHrbY84YGXtWIVis3/0zsbaPXnxA9Fg1qhrLib9wEdqJMv WDsIMKlycaq/7OyyClP55cx5Mytn5cxGzTDuH08vBkShWfnkRWF53cJGltxTt13ZNP8O1Zpramw p0PysP1oz6+aVAip7b1DKgWKBOFOrH4A0GHA6d3QCYnF6fPuhntLj/NE0BOMbziKuBppk7rrW3E q8GOCMKvOPHA2xu/aWOYYpO9Pwd8OyS2MNzI9Fxn+UBIy759iD2eGC/dBuOdO2m/UuoN344De3U nzbh9ZIwDYpnz6PShReGI/+bohzHa93wtSGaHZZNrA2auOymEZyf4lCynZi0/dxIewyW/UmxFi/ 3P5qLZg0F8l3a2DKoHSlb36DEt3BX3Sru8tbMeOVdGMEkwxt42uQDgy2yLLBmhYgsdPEEbNJtpS X/pEPklzqEKYXsbGxI8CvNmOaXy+aIm9NSgD+nDlYCpZ2DvUfOLXrPA5Wo5saaMFZzLIuBuzggj h7Vjz/R9F/R9K84U6cH6gLVG+UPY4ZkUuHLEKwIrLuEzSvMVsw== X-Received: by 2002:a05:600c:8b65:b0:493:f478:4c71 with SMTP id 5b1f17b1804b1-493f8885308mr62186295e9.7.1783875159109; Sun, 12 Jul 2026 09:52:39 -0700 (PDT) Received: from systembl0wer ([2a02:8308:4092:11f0::f9f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493f2e0f165sm163251925e9.0.2026.07.12.09.52.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 09:52:39 -0700 (PDT) Date: Sun, 12 Jul 2026 18:52:37 +0200 From: Joshua Crofts To: Maxwell Doose Cc: Jonathan Cameron , Tomasz Duszynski , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH] iio: chemical: scd30: remove kernel.h header Message-ID: <20260712185237.6a60e112@systembl0wer> In-Reply-To: <20260712164225.358852-1-m32285159@gmail.com> References: <20260712164225.358852-1-m32285159@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 12 Jul 2026 11:42:25 -0500 Maxwell Doose wrote: > kernel.h is no longer recommended for usage because it can cause longer > build times and pull in transient dependencies. In addition, it's not > being used by the SCD30 driver. Remove it. > > Signed-off-by: Maxwell Doose > --- > drivers/iio/chemical/scd30_core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c > index f85cdd8bd84f..40bbf26a667b 100644 > --- a/drivers/iio/chemical/scd30_core.c > +++ b/drivers/iio/chemical/scd30_core.c > @@ -23,7 +23,6 @@ > #include > #include > #include > -#include > #include > #include > #include Since you're doing IWYU stuff, you should also remove errno.h and add err.h instead, as the code uses IS_ERR() etc. and err.h includes errno.h Also consider grouping the iio headers and asm headers separately. (separate patch though). The include list looks overwhelming! -- Kind regards CJD