The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Jahnavi Nitheesha Mandava" <jahnavimn@google.com>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Todd Kjos" <tkjos@android.com>,
	"Christian Brauner" <brauner@kernel.org>,
	"Carlos Llamas" <cmllamas@google.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Tamir Duberstein" <tamird@kernel.org>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"Onur Özkan" <work@onurozkan.dev>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v2 0/7] rust_binder : Implement dynamic debug logging mask
Date: Sun, 12 Jul 2026 09:00:21 +0200	[thread overview]
Message-ID: <2026071234-untidy-ruined-c98d@gregkh> (raw)
In-Reply-To: <CAH5fLghOSPYA+uYmUB18VfPhc9PtDWaH0Khc=7EAN7DQt=8L4w@mail.gmail.com>

On Sat, Jul 11, 2026 at 12:42:11PM +0200, Alice Ryhl wrote:
> On Sat, Jul 11, 2026 at 12:29 PM Jahnavi Nitheesha Mandava
> <jahnavimn@google.com> wrote:
> >
> > On Fri, Jul 10, 2026 at 8:31 PM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Fri, Jul 10, 2026 at 02:32:51PM +0000, Jahnavi MN via B4 Relay wrote:
> > > > When a user-space application sends malformed data or makes a
> > > > lifecycle mistake, the driver rejects it with a generic error code
> > > > (like -EINVAL). Without internal logs, the driver acts as a
> > > > "black box," forcing developers to guess which check failed.
> > > >
> > > > In the legacy C Binder driver, this issue is solved using a dynamic
> > > > debug_mask module parameter that toggles verbose logs for specific
> > > > subsystems. This series brings the same critical capability to the
> > > > Rust Binder driver to provide developers with clear, real-time
> > > > feedback.
> > > >
> > > > Instead of rebuilds, reboots, or guessing:
> > > > - Developers can enable logs instantly on a running device by writing to
> > > >   `/sys/module/rust_binder/parameters/debug_mask`.
> > > > - It prints the exact reason for failures (such as alignment errors,
> > > >   mismatched call stacks, or invalid handle references) directly into
> > > >   `dmesg`, reducing debugging time from hours to seconds.
> > > > - It protects system logs by keeping logging off by default and only
> > > >   enabling it when developers are actively troubleshooting.
> > > >
> > > > Based on top of:
> > > > https://lore.kernel.org/rust-for-linux/20260707-upgrade-poll-v6-0-4b8fae7bf1d9@google.com/
> > > >
> > > > Signed-off-by: Jahnavi MN <jahnavimn@google.com>
> > >
> > > Patches 5 and 7 did not apply to my tree, can you rebase against the
> > > char-misc-testing branch and send just those?  Other ones are now all
> > > queued up, nice work!
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Hi Greg,
> >
> > Thanks! I will rebase and resubmit only patches 5 and 7 as a new
> > version (v3) of this series shortly.
> >
> > Regarding the feedback I received on Patch 1 (using the BIT macro
> > and Atomic<u32>), since Patch 1 is already queued, I will send those
> > cleanups as a separate, follow-up patch. Does that sound good?
> 
> Since it's only queued in char-misc-testing and not char-misc-next, I
> don't think it's too late to change the patches themselves. So I guess
> you could also resend the entire series based on top of commit
> f8d269390cd2 ("rust_binder: update Process::node_refs to use
> SpinLock") from testing?

Yes, I messed up the application of this series to my tree as Alice
pointed out in another email.  If you could just rebase and resend a new
version, that would be great.

thanks,

greg k-h

      reply	other threads:[~2026-07-12  7:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 14:32 [PATCH v2 0/7] rust_binder : Implement dynamic debug logging mask Jahnavi MN via B4 Relay
2026-07-10 14:32 ` [PATCH v2 1/7] rust_binder: Add " Jahnavi MN via B4 Relay
2026-07-10 14:59   ` Greg Kroah-Hartman
2026-07-10 16:37     ` Miguel Ojeda
2026-07-10 17:03       ` Miguel Ojeda
2026-07-10 16:51   ` Gary Guo
2026-07-10 19:47   ` Carlos Llamas
2026-07-10 20:27     ` Gary Guo
2026-07-10 22:12       ` Carlos Llamas
2026-07-12  8:31         ` Alice Ryhl
2026-07-10 14:32 ` [PATCH v2 2/7] rust_binder: Implement BINDER_DEBUG_USER_ERROR for freezer-related operation Jahnavi MN via B4 Relay
2026-07-10 19:55   ` Carlos Llamas
2026-07-10 14:32 ` [PATCH v2 3/7] rust_binder: Implement BINDER_DEBUG_USER_ERROR for refcounting and death notifications Jahnavi MN via B4 Relay
2026-07-10 19:56   ` Carlos Llamas
2026-07-10 19:58   ` Carlos Llamas
2026-07-10 14:32 ` [PATCH v2 4/7] rust_binder: Implement BINDER_DEBUG_USER_ERROR for transaction parsing failures Jahnavi MN via B4 Relay
2026-07-10 20:07   ` Carlos Llamas
2026-07-10 14:32 ` [PATCH v2 5/7] rust_binder: Implement BINDER_DEBUG_FAILED_TRANSACTION Jahnavi MN via B4 Relay
2026-07-10 20:15   ` Carlos Llamas
2026-07-10 14:32 ` [PATCH v2 6/7] rust_binder: Implement BINDER_DEBUG_DEATH_NOTIFICATION Jahnavi MN via B4 Relay
2026-07-10 20:20   ` Carlos Llamas
2026-07-10 14:32 ` [PATCH v2 7/7] rust_binder: Implement BINDER_DEBUG_DEAD_TRANSACTION Jahnavi MN via B4 Relay
2026-07-10 14:35 ` [PATCH v2 0/7] rust_binder : Implement dynamic debug logging mask Alice Ryhl
2026-07-10 15:01 ` Greg Kroah-Hartman
2026-07-11 10:28   ` Jahnavi Nitheesha Mandava
2026-07-11 10:42     ` Alice Ryhl
2026-07-12  7:00       ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026071234-untidy-ruined-c98d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=arve@android.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=brauner@kernel.org \
    --cc=cmllamas@google.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=jahnavimn@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@kernel.org \
    --cc=tkjos@android.com \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox