From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E7B828850E; Mon, 13 Jul 2026 12:35:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783946132; cv=none; b=VQuPkSMlPBNxMLNIZ7FvK89PjoEzSMiEukEuSdvz5mqISgyEYKAhgF3iGO36hx9cl++jMms5qzv8C2O50T/XXGgkcm7oVGvH44PNHmrVyJ5HHF/LhgCLr/ai/3T52X85DLRKo4cic5sEQWRQvtCiXzC0GNSHB4zrRQF0X54ed4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783946132; c=relaxed/simple; bh=1GsRhcQuZOmNv+24J/UZlUcTMXIDaKrmHqo4yj7OcvQ=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=Eeyon7d8pT1Pr/LSjjT3epQ/UgMZ8rm38FU/KzYW2c0jrnWWYGqdJtLUJCn9zBSTrRlHkhApXNK0u/wVWD02uqyu5sGYYF3CcEG5m6t6J1HRIwktvXYiSemRJ4VZOgnK4d/wWoAXZt4GlYFbLxDnEtPW+QIGsQvp41xFXQbIBG0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZmV7+5Yt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZmV7+5Yt" Received: by smtp.kernel.org (Postfix) with ESMTPS id 0161AC2BCB8; Mon, 13 Jul 2026 12:35:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1783946132; bh=1GsRhcQuZOmNv+24J/UZlUcTMXIDaKrmHqo4yj7OcvQ=; h=From:Subject:Date:To:Cc:Reply-To:From; b=ZmV7+5YtI4BgaZhy51F4YcU6txsyeOcL8i7sNVIb/95badfqx6XVvJ7dMyqyvFDuO nNzVrvIluD1wB7sv6LfwUW0pVPO6G7oETKnWXWEpBTk9Ft8q5pNGHoQeBU3PVV1D05 SIZf1jy6XaWJSmR4yfKC3aiElRrOUkHntjbZoEgphnWo7Zs43yfC7EgpcvT+EBX0pW 9WY7kpKKB/Cd3YQ4cJ5z9Di252nKuK7ptIehJZrPwqEbnlyG/up77ors7C5mYNDhsR 8O/YkIkJBm9ermctL9a3oVZ4gQ2siA4aj2SZgzU1Ug7BO+M3PwKcP/GkdQ6I5o8UvK ZmMhSBVaESmDg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D12D7C43458; Mon, 13 Jul 2026 12:35:31 +0000 (UTC) From: Jahnavi MN via B4 Relay Subject: [PATCH v3 0/7] rust_binder : Implement dynamic debug logging mask Date: Mon, 13 Jul 2026 12:35:22 +0000 Message-Id: <20260713-rust_binder_debug_mask-v3-0-0de91bbbbf69@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAIrbVGoC/3XN0QqCMBTG8VeJXbfYznRWV71HhDh3nKN0sekox HdvCkFdePn/4PzORAJ6i4GcdxPxGG2wrk8h9jtSt1VvkFqdmgADyQoG1I9hKJXtNfpSoxpN2VX hTqWQhSgYzyVkJB0/PTb2tcLXW+rWhsH59/on8mX9kmKLjJwyelK64aByAXl9Mc6ZBx5q15HFj PDjcLbpQHLgmMmMMxQVyj9nnucP8ke9AgUBAAA= X-Change-ID: 20260702-rust_binder_debug_mask-636737015624 To: Greg Kroah-Hartman , =?utf-8?q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Christian Brauner , Carlos Llamas , Alice Ryhl , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Jahnavi MN X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783946130; l=4169; i=jahnavimn@google.com; s=20260702; h=from:subject:message-id; bh=1GsRhcQuZOmNv+24J/UZlUcTMXIDaKrmHqo4yj7OcvQ=; b=arQzLK0EuW9wRnxXNwq8v4zhO4vNOUiR3ipcPodJOcLmSjQMebYDRX1t+uyiL7fvBcgAUzNKZ xoNlSDZvE1wC+LglGVjBT6og78+Fi0C/Tzs8KU1X3kdx/Fd8IJv02Ym X-Developer-Key: i=jahnavimn@google.com; a=ed25519; pk=9aLfw3FepTOJwTS7jRXm7pDH87eBeZMXBPrqwU0//RE= X-Endpoint-Received: by B4 Relay for jahnavimn@google.com/20260702 with auth_id=849 X-Original-From: Jahnavi MN Reply-To: jahnavimn@google.com When a user-space application sends malformed data or makes a lifecycle mistake, the driver rejects it with a generic error code (like -EINVAL). Without internal logs, the driver acts as a "black box," forcing developers to guess which check failed. In the legacy C Binder driver, this issue is solved using a dynamic debug_mask module parameter that toggles verbose logs for specific subsystems. This series brings the same critical capability to the Rust Binder driver to provide developers with clear, real-time feedback. Instead of rebuilds, reboots, or guessing: - Developers can enable logs instantly on a running device by writing to `/sys/module/rust_binder/parameters/debug_mask`. - It prints the exact reason for failures (such as alignment errors, mismatched call stacks, or invalid handle references) directly into `dmesg`, reducing debugging time from hours to seconds. - It protects system logs by keeping logging off by default and only enabling it when developers are actively troubleshooting. Based on top of: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git Signed-off-by: Jahnavi MN --- Changes in v3: - Rebase the entire series on top of the latest char-misc-testing tree. - Define `rust_binder_debug_mask` in Rust as an `Atomic` and export it to C as `extern u32` to avoid raw volatile reads and FFI UB. - Use `kernel::bits::bit_u32` instead of raw bit shifts. - Simplify `binder_debug!` macro rules and remove the redundant `raw` helper. - Wrap the raw mask in `DebugMasks` to use type-safe `.contains(mask)`. - Link to v2: https://lore.kernel.org/r/20260710-rust_binder_debug_mask-v2-0-2846410e3ae6@google.com Changes in v2: - Defined the debug mask categories using bitflags (impl_flags) to resolve potential Undefined Behavior and match Rust idioms. - Added a tgid helper to rust/kernel/task.rs to expose the task group ID and optimize default "PID:TID" prefixing. - Implemented the BINDER_DEBUG_DEATH_NOTIFICATION mask to log OOM failures, lifecycle updates, and async delivery to user-space. - Added pid fields to ThreadError, DeliverCode, and FreezeMessage to ensure cancellation logs show the correct process PID instead of background kworker PIDs. - Removed duplicate PID printing across workqueue, transaction failure, and stack unwinding logs. - Refactored log formatting (e.g. formatted BinderError with {:?}, used "strong"/"weak" strings, and improved message wording). - Fixed logic bugs (restored missing update_ref block, moved manager lookup warnings). - Cleaned up spurious newlines, corrected indentations, and adjusted all commit titles to be shorter and more meaningful. - Link to v1: https://lore.kernel.org/r/20260703-rust_binder_debug_mask-v1-0-9bdf12b5325c@google.com --- Jahnavi MN (7): rust_binder: Add dynamic debug logging mask rust_binder: Implement BINDER_DEBUG_USER_ERROR for freezer-related operation rust_binder: Implement BINDER_DEBUG_USER_ERROR for refcounting and death notifications rust_binder: Implement BINDER_DEBUG_USER_ERROR for transaction parsing failures rust_binder: Implement BINDER_DEBUG_FAILED_TRANSACTION rust_binder: Implement BINDER_DEBUG_DEATH_NOTIFICATION rust_binder: Implement BINDER_DEBUG_DEAD_TRANSACTION drivers/android/binder/debug.rs | 76 +++++++++++++++++++ drivers/android/binder/freeze.rs | 64 +++++++++++----- drivers/android/binder/node.rs | 24 ++++-- drivers/android/binder/process.rs | 56 ++++++++++++-- drivers/android/binder/rust_binder_main.rs | 16 +++- drivers/android/binder/rust_binderfs.c | 3 + drivers/android/binder/thread.rs | 117 ++++++++++++++++++++--------- drivers/android/binder/transaction.rs | 15 ++++ rust/kernel/task.rs | 7 ++ 9 files changed, 309 insertions(+), 69 deletions(-) --- base-commit: f8d269390cd2a7a9fb5a31f153e7c7b709defea0 change-id: 20260702-rust_binder_debug_mask-636737015624 Best regards, -- Jahnavi MN