From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CBA33F482A for ; Mon, 13 Jul 2026 11:58:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783943936; cv=none; b=gKdQsluh7/0pnPVXPGS7oMaBGXyK9/RcZRHclvjYGn8x+ftJRZzBoBIaCH+WdZsXZc3Di3G2JnbSvDnfxYuH25BNXMAQQFlmxYc2zMntpvEzX3P/nkIgSsObuNXuyxX3dWO6P8tApB8R4aITVAhHZlleNtg3iHwaWwLgBodgeeU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783943936; c=relaxed/simple; bh=tuUhSWsXBqBlAORq9TsPaWcw9THuG6DmItaa24bC9j8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=U9yYPgJcOW+OHjXXTG0GEbSKqzdZcGCWl3Tl53rCJgmGBRUNVs+JemUVYt5mkMvGlfDAhzLnCr5i4lg1GvHV0T4YOhmcsOS2+sxvJK2FL95IdoOPWNf2tR5wKKOQm0E/PsubQDh9no1TXs36b4IuDny/TzkeT8xpGd4i+1vZ4hY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oQ3koeVZ; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oQ3koeVZ" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2cacd69a9c0so31520595ad.1 for ; Mon, 13 Jul 2026 04:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783943935; x=1784548735; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=KMCqb0ZisPZZmgRadRDvZ258fCl2AulK6nt/+PSX+EE=; b=oQ3koeVZm2Uhecwla8mFrrCalllMBVjNw5s6yHgY5AbXHCaVTHFeOKBG5Q7ARQjazP otuQBww6bvPbbkOAWW5XszWjdbJp8cjc3GCNZ2lqoV/ME6q1YaZlcf/bEa6xIS4GYp5y wObkYTzLgqJcwopsFSmtrS3SlUu2Gzgq6sfPMfCieknesCoiYViAe8COZFwo28RfFFr4 tCiKY2bqBJ+rxmcOpeBWFYCvqfMmvsTc1ImPnyKR8E4bF+F0A/u+osxZzRl74DkQxY/M gJKjiwhEBVtDzR/GIQOFAuzuYF4s7JXAWfxEH+ku+zK6yYO0rnjCEGImTGJsII0m6ddx AmCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783943935; x=1784548735; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KMCqb0ZisPZZmgRadRDvZ258fCl2AulK6nt/+PSX+EE=; b=ov1ao32ohCtYraUQwOctvUM2FB0osyewQVfWanGxM/gDYGXHUX+U2UL6+ngVzG1HOO /IU2NLtubpzI3oXHw+m/5S1t4Adu5vFG1ot90yOknRMBg3Rig/fQ6SMky2saYch2Kr87 IuhOzXGTewg95CoB1x/kbD8gEDwi5QfpC7ZJnrLO9RctXr9r8OZZ3rt8loJTSgkdKVzQ wyZUKRDojNm8xvlhurzdC97aPHxyXMtIvXC+sbC5d3hwqQ75dEzxWSDjQAd2A7DNwX8G uUjnNe3ikN5iVmfOkmksqZkrWKScoJAU0P/hL42CdOZCcuOoChRyvErn88MPkodmwMg7 JRhg== X-Forwarded-Encrypted: i=1; AHgh+RrVJtnpqtjY7IZ7m2rvxylfXE4MeTlxhsUQH1cpPESTEpNCxsiULaafdw7uKap0K5YtUDxcefb6MVQtKDQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzqv/vrLWSATgKsvL1XrehMOOmAe/6GqLZZ8wx9ig8BUWmUIbao o8Asw6pyDAKS7PSl9N4znORwQaK4UwFQsxXN/FDWPtvm/PJA+TtAJywT X-Gm-Gg: AfdE7clhV14UwmEyJt4Im4tZzVCh4OXWoiBzD+w6PosBBDkQeKIICmQu3x4mQUhxDHO PNZCYpQIKym0X6UCL0bIta2PeVdH9u0clc651Y3J2dheQpGLgGMCJ79F7DwAbVhgIFOztuIR8Yg BXhr0MwtTHpTJ2b1b9Y4+t9S6EjtlsBXtCVBE4fypiSpGZ12i6hqY+jnSmApHrnGv5JkQiUEpG+ a/Z32pqeF4fu/y952lDn4eeYW6U2QjVJNLXlNllbTDCOx8pMrsrlfx9t+IRg9qDBbFPVJ5Pioxk UuZXH1Y5tjVdUNqbu3UvMVDwpZj1uR3IKXt8+m3X/Xt2X/SnCffbdwrkwsfgAbabJNtih0thbs/ UQVbgobxpIOKKZKR4SW0zWkfHfwoFrl6gPwP2Flw/IoZxw11UE5YgJjZSFuFkglh5QXWe10roSN AXh6lMQanB9qXfL/lVNuTuUJWdGJ8CqUAumrYd6zNGE4a0EU31AA== X-Received: by 2002:a05:6a20:a11c:b0:3bf:a698:ce4d with SMTP id adf61e73a8af0-3c110b6e09bmr9547183637.54.1783943934740; Mon, 13 Jul 2026 04:58:54 -0700 (PDT) Received: from primary ([223.181.22.8]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659d87a2sm63668369c88.13.2026.07.13.04.58.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 04:58:54 -0700 (PDT) From: Vidhu Sarwal To: jic23@kernel.org Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, shreeya.patel@collabora.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, Vidhu Sarwal Subject: [PATCH] iio: light: ltrf216a: fix runtime PM reference leak in error path Date: Mon, 13 Jul 2026 07:58:29 +0530 Message-ID: <20260713022829.234370-1-vidhu.linux@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ltrf216a_get_lux() acquires a runtime PM reference by calling ltrf216a_set_power_state(data, true). However, if ltrf216a_read_data() fails, the function returns immediately without dropping the reference. This leaves the runtime PM usage count unbalanced, preventing the device from autosuspending after a failed read. Fix this by releasing the runtime PM reference before returning from the error path. Fixes: 83f0bcd40d5c ("iio: light: Add support for ltrf216a sensor") Signed-off-by: Vidhu Sarwal --- drivers/iio/light/ltrf216a.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/light/ltrf216a.c b/drivers/iio/light/ltrf216a.c index 3f34ddc911b4..3ec239eb5831 100644 --- a/drivers/iio/light/ltrf216a.c +++ b/drivers/iio/light/ltrf216a.c @@ -247,8 +247,10 @@ static int ltrf216a_get_lux(struct ltrf216a_data *data) return ret; greendata = ltrf216a_read_data(data, LTRF216A_ALS_DATA_0); - if (greendata < 0) + if (greendata < 0) { + ltrf216a_set_power_state(data, false); return greendata; + } ltrf216a_set_power_state(data, false); base-commit: a13c140cc289c0b7b3770bce5b3ad42ab35074aa -- 2.53.0