From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 752083859EF
	for <linux-kernel@vger.kernel.org>; Mon, 13 Jul 2026 06:45:04 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1783925106; cv=none; b=Bz2EtgLP//EHhMe3ldYXCbGg0YuE3HvWc/i3OtpmrUpxL34994L/bdD8wXA1XdQ/wlv4Ekxg4XDcP340baUdiZqxEUhEBKQ0tGmLI2fZp38JQxpQ8ICZZpyoyvW1VUti5Bo/cEAXq/XmLC5JH2lbn9yGaDhKxmgszvHrJ92c/Dc=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1783925106; c=relaxed/simple;
	bh=zS7jIwsCqDaxHB6q+aYjrahzBLRaObGfRqnsfL/bRKQ=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=qmRX4l20bsXp1/MdYagV4B342qgoPUYrg2eaGJo+oEhFwAqEbqvqQ6jayBc+jdwzfmth+gsdtcN2A//5Pi0jf1QIh7/EhGxswJP/BZqEg6KtXuNHc+6crxJM8kXxIKKizYZHtNNeDkN0GuSgHKgYXK4qPRkRXZS6mGrX1AvrVD0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id 9F65068BEB; Mon, 13 Jul 2026 08:45:01 +0200 (CEST)
Date: Mon, 13 Jul 2026 08:45:01 +0200
From: Christoph Hellwig <hch@lst.de>
To: guzebing <guzebing1612@gmail.com>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
	axboe@kernel.dk, sagi@grimberg.me, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org, Guzebing <guzebing@bytedance.com>
Subject: Re: [PATCH] nvme: make firmware activation poll interval
 configurable
Message-ID: <20260713064501.GF29416@lst.de>
References: <20260627010610.47768-1-guzebing1612@gmail.com> <20260709064233.GA18381@lst.de> <7ae65361-f601-4fd9-8eac-5dfb9f6bb7ea@gmail.com> <ak-5QnI_lc-EwcNU@kbusch-mbp> <12726bc4-33ce-4602-b2a9-46885f2af1fe@gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <12726bc4-33ce-4602-b2a9-46885f2af1fe@gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Fri, Jul 10, 2026 at 05:20:56PM +0800, guzebing wrote:
> > nvme_wait_ready() has a similar polling loop on the csts register, but
> > it does a udelay_range for 1-2 msecs no matter what the ready timeout
> > is. Maybe just do the same for consistency?
> 
> Keith, using the same 1-2 ms sleep range as nvme_wait_ready() looks
> simpler to me as well.

Let's go for that then.