The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Nilay Shroff <nilay@linux.ibm.com>
To: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: hch@lst.de, elver@google.com, kbusch@kernel.org,
	sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org,
	gjoyce@linux.ibm.com, Nilay Shroff <nilay@linux.ibm.com>
Subject: [PATCH v4 10/20] nvme: remove redundant initialization of delayed_removal_secs
Date: Mon, 13 Jul 2026 17:24:11 +0530	[thread overview]
Message-ID: <20260713115444.465704-11-nilay@linux.ibm.com> (raw)
In-Reply-To: <20260713115444.465704-1-nilay@linux.ibm.com>

nvme_ns_head is allocated with kzalloc(), so explicitly initializing
nvme_ns_head::delayed_removal_secs to 0 in nvme_mpath_alloc_disk() is
redundant.

Removing the redundant initialization also avoids a false positive from
Clang's context analysis once nvme_ns_head::delayed_removal_secs is
annotated with __guarded_by(nvme_subsystem::lock).

Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
---
 drivers/nvme/host/multipath.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index 282cd8abd0b7..698d79a97045 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -738,7 +738,6 @@ int nvme_mpath_alloc_disk(struct nvme_ctrl *ctrl, struct nvme_ns_head *head)
 	INIT_WORK(&head->requeue_work, nvme_requeue_work);
 	INIT_WORK(&head->partition_scan_work, nvme_partition_scan_work);
 	INIT_DELAYED_WORK(&head->remove_work, nvme_remove_head_work);
-	head->delayed_removal_secs = 0;
 
 	/*
 	 * If "multipath_always_on" is enabled, a multipath node is added
-- 
2.53.0


  parent reply	other threads:[~2026-07-13 11:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13 11:54 [PATCH v4 00/20] Support Clang context analysis for NVMe host drivers Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 01/20] list: introduce LIST_HEAD_GUARDED Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 02/20] list: Permit context-unguarded access with list_empty_careful() Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 03/20] nvme: update nvme_passthru_end() signature Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 04/20] nvme: add context annotations for nvme_passthru_{start|stop} Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 05/20] nvme: add context annotations for nvme_ns_head::srcu Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 06/20] nvme: remove redundant initialization of nvme_ns_head::requeue_list Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 07/20] nvme: add context annotations for nvme_ns_head::requeue_list Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 08/20] nvme: add context annotations for nvme_ns_head::current_path Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 09/20] nvme: add context annotations for nvme_dev::shutdown_lock Nilay Shroff
2026-07-13 11:54 ` Nilay Shroff [this message]
2026-07-13 11:54 ` [PATCH v4 11/20] nvme: add context annotations for nvme_subsystem::lock Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 12/20] nvme: add context annotations for nvme_ctrl::ana_lock Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 13/20] nvme: add context annotations for nvme_subsystems_lock Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 14/20] nvme: add context annotations in fabric.c Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 15/20] nvme: add context annotations for nvme_queue::sq_lock Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 16/20] nvme: add context annotations in rdma.c Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 17/20] nvme: fix context analysis warning " Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 18/20] nvme: add context annotations in tcp.c Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 19/20] nvme: fix context analysis warning " Nilay Shroff
2026-07-13 11:54 ` [PATCH v4 20/20] nvme: enable context analysis support for nvme host driver Nilay Shroff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260713115444.465704-11-nilay@linux.ibm.com \
    --to=nilay@linux.ibm.com \
    --cc=axboe@fb.com \
    --cc=bvanassche@acm.org \
    --cc=elver@google.com \
    --cc=gjoyce@linux.ibm.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox