From: Greg KH <gregkh@linuxfoundation.org>
To: demiobenour@gmail.com
Cc: Russell King <linux@armlinux.org.uk>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Eric Biggers <ebiggers@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] drivers/crypto: Mark QCE as BROKEN
Date: Mon, 13 Jul 2026 06:47:07 +0200 [thread overview]
Message-ID: <2026071312-uncover-refining-8cac@gregkh> (raw)
In-Reply-To: <20260712-qce-broken-v2-1-b2dfff47f7f5@gmail.com>
On Sun, Jul 12, 2026 at 05:31:31PM -0400, Demi Marie Obenour via B4 Relay wrote:
> From: Demi Marie Obenour <demiobenour@gmail.com>
>
> This driver is harmful:
>
> - It is much slower than the CPU [1] [2].
> - It Has a history of bugs [2] [3].
> - It does not have exclusive access to the hardware [4], causing races
> with the secure world.
> - It register its implementations with too low a cra_priority for them
> to be actually used [5].
>
> Therefore, disable it to ensure that nobody builds it into kernels they
> intend to ship.
>
> In the future, the driver will be used for processing restricted media
> content. However, the kernel does not currently support this. Since
> the driver will have future uses, allow building it if COMPILE_TEST is
> enabled.
Why not just delete it now, and then bring it back when it is needed in
the future? Otherwise this will just trip up the static code checkers
who will attempt to "fix" things in it.
thanks,
greg k-h
next prev parent reply other threads:[~2026-07-13 4:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 21:31 [PATCH v2] drivers/crypto: Mark QCE as BROKEN Demi Marie Obenour via B4 Relay
2026-07-13 2:57 ` Eric Biggers
2026-07-13 4:47 ` Greg KH [this message]
2026-07-13 13:07 ` Eric Biggers
2026-07-13 13:19 ` Greg KH
2026-07-13 14:42 ` Demi Marie Obenour
2026-07-13 15:31 ` Greg KH
2026-07-13 19:49 ` Demi Marie Obenour
2026-07-13 19:56 ` Demi Marie Obenour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026071312-uncover-refining-8cac@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=demiobenour@gmail.com \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox