From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E5923F6C48 for ; Mon, 13 Jul 2026 12:11:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783944684; cv=none; b=TmkoKE4mUaKtH1drgu6+wLUEj3XGqKuqikDpBGTDYn2uxaYgac1EAG1hppEgfa6yGEUhQEZFgUU7cB9zX2/Cc75OMz1yaqJYMDGVKJw9EymoGz+GYzniv/pRstVvZ4UKdKDJE9owrrXyWyW71DvrF38wUTHWzRejG62nlXxG86s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783944684; c=relaxed/simple; bh=G2NQafJclYTeJRa5vR4Nkq85FyLNUI0JvtBWv+71DF8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EeTi5PkHo/PgoOD2/v1SiDR5vqg3wyWdWSDrZfEnHXCjHfttD3xfQqBX8QgG92GMXY5mLTx7e9tQnHojy0Vhy+hFDMnpPwFRrytbdfF3qFTsRtipbZpEYspqRM9zG8BkkobI7xfkWp3E7lIL38juHU0UQlhPZaRn76RjyPGUU4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fcozDjaz; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fcozDjaz" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-84864086bfeso3028982b3a.1 for ; Mon, 13 Jul 2026 05:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783944682; x=1784549482; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7nfm5E5YVw8Xk7Gt9ejcJe2nuIHpfZQPsIGFP/AIC7g=; b=fcozDjazFI/WUVc0BmHdQAQvM4spN0oJ9XlZLfElRLv4JT3GeeD7D5LQi7FGRoWlh+ Iqfl11+DFcJBk+LqcHVZGverbbXqiJJdjBdSSLD7pyULmurii+Do/R5CGKPCmXr70M+/ U9tMzOl+XMBityX623Sky1ZJ0wg7ozcnUohKb9GeEzkoJDWlQ+swCpWV8TB9JMkfAhKg JWSsS+b8El410LL/rkZvJTLt+cHHsl9bxarsiBYlJ1I7gSU/heipccqYdYtQs5Rl/+ZW uF/55/3JSWbS4WdOxoFZnyQlDbRgp6VrCXPq5DiXPlJq9PzbIXIGBOGHbQhEZN9PN5bW IFOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783944682; x=1784549482; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=7nfm5E5YVw8Xk7Gt9ejcJe2nuIHpfZQPsIGFP/AIC7g=; b=aSqO+ZD8pfGlAT76zcdTTbsAz/7Cms5f7Hy0JmGWHbyeHHFiJuGyBmxDrRVl7WpV7V fXdyqzP/RBfaoe0ivROUc2PIj96TfBgbqcxuVVPQ9Mo7t2iwCdejdtgssfvLHeKd1Ji8 DxVVXALZcGEEG3HFY/yne7xYk3ci5ojZhMQN2vtaOUnCbUlqfL910reNPfft+TRYwZYm eSrz3IKP4TQIdSAPGNNEwxstKbECcspg9sAw3BXHpir+4scPysyL5hKBppcExIOGTkN8 D40W+f0zkRiyyeu32QjQC76t2vqOxtSmZEJ3Vo3OPrintB6iYlGei2nnxGfVQxZZeTv/ 9zUg== X-Forwarded-Encrypted: i=1; AHgh+RovVsy9q9DvUyX84fum8uqAqYbKwHG+++UlEmFstFBe1FKHo9flpCKoX5o9uNUTLPeASgv0VrcdmG5Qte8=@vger.kernel.org X-Gm-Message-State: AOJu0YyAJjFg4Jx2FHnGTWKSYye//+dZevXDhI3I2lMPPFr2/2jjICU4 g3aFSmT0uElYa3sEw3q9CsMjLqtniDIqz0V1+vdK3SB/Km/oMlP47/hW X-Gm-Gg: AfdE7cmCDbA5igWYAO28dWnP6ZDMuv8d1LAG/zDVeB/MXGlHkV+J9bOVT9TJXWj1GTp EvTwfL6UzMMSSnYO4kk9iyjkJS0AcErijsmnVaDQRHhwIpUB7Fy2Nywb9+m2s5TeFJOZ349GVnA 99cStWOC/P6tyTcFba02Ks5/NXLtEaG+mC/LT8+lEPqLePjX55Ss/KBDYDNkaqTvPeMW/1/qO9v PEZFpXGryPXzxCDNLJ9na7EXljzRdqqw3xY6/q1jlSCEyz4R8qZMl3GKEitQfRv8RumDae6lDEt GQPM1bZ8wt2d+vxQs2HlhXlk4ddJtFQdiPZPuRtdjhrqxJPeRyIS3+BDUoawEe9RjmoRc2f90/h 20Ga3bs0GQh+OM2xpEIZMkpa8hpDfjSbt3IF6Q4rSUg4EU5HPMmP29tgN/wAqNFza7qoTcK/6tN fmDhkkjPhGkQ== X-Received: by 2002:a05:6300:220a:b0:3bf:aab1:cc8b with SMTP id adf61e73a8af0-3c110b436f6mr8836067637.46.1783944681879; Mon, 13 Jul 2026 05:11:21 -0700 (PDT) Received: from rockpi-5b ([45.112.0.180]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f7293sm67756935eec.3.2026.07.13.05.11.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 05:11:21 -0700 (PDT) From: Anand Moon To: Neil Armstrong , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Mauro Carvalho Chehab , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR AMLOGIC SOCS), linux-amlogic@lists.infradead.org (open list:DRM DRIVERS FOR AMLOGIC SOCS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list), linux-media@vger.kernel.org (open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS), linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM) Cc: Anand Moon , Doruk Tan Ozturk , Nicolas Dufresne Subject: [PATCH v7 14/19] media: meson: vdec: Correct atomic counter placement in dst_buf_done Date: Mon, 13 Jul 2026 17:37:09 +0530 Message-ID: <20260713120840.17427-15-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260713120840.17427-1-linux.amoon@gmail.com> References: <20260713120840.17427-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix an end-of-stream (EOS) boundary condition logic flaw in dst_buf_done() by relocating the atomic decrement helper to execute after state evaluation. Previously, decrementing sess->esparser_queued_bufs at the entry point of the function corrupted the conditional checks for the final video frame. This premature decrement tricked the driver into flagging the second-to-last buffer as the final frame (V4L2_BUF_FLAG_LAST) during teardown sequences, which cut off the true final frame and broke compliance validation. Resolve this by moving atomic_dec() to execute immediately after the EOS conditional tracking block finishes evaluating, right before invoking v4l2_m2m_buf_done(). This ensures accurate stream termination signaling. Cc: Nicolas Dufresne Signed-off-by: Anand Moon --- drivers/staging/media/meson/vdec/vdec_helpers.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/media/meson/vdec/vdec_helpers.c b/drivers/staging/media/meson/vdec/vdec_helpers.c index f02c21d5a9c18..303236f0647c0 100644 --- a/drivers/staging/media/meson/vdec/vdec_helpers.c +++ b/drivers/staging/media/meson/vdec/vdec_helpers.c @@ -314,6 +314,9 @@ static void dst_buf_done(struct amvdec_session *sess, dev_dbg(dev, "Buffer %u done, ts = %llu, flags = %08X\n", vbuf->vb2_buf.index, timestamp, flags); vbuf->field = field; + + atomic_dec(&sess->esparser_queued_bufs); + v4l2_m2m_buf_done(vbuf, VB2_BUF_STATE_DONE); /* Buffer done probably means the vififo got freed */ -- 2.50.1