From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D88D837BE93 for ; Mon, 13 Jul 2026 12:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783945694; cv=none; b=bADqcQjqEN9o+NlatXjGiEfJCFUBcOjL8T/r5K2TL66Z1SKqDCrLWTilKsNVZD4ZZ56rbaYC7y/8oAW/uP0lsvMCfZdA68TNWQyStmuvoSlCvMV15YR6/nfa+f1IJakwVKzvq5TH080px68SmO7MV4wN/g+Bc2zWxAHJMWp163U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783945694; c=relaxed/simple; bh=fwqZN2vbqNseymtGxGIWgj1IWKR8basbYQ9EEL5R9rg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qm+jEPG92Mo4U5u5+FqglLZGMLmJeCAHw9/CfFerhoeBKUD8XxBmu8XDn00SJ+xKk98FI28i8AnOHhCBbpGYvOOflCsNSbPWavXNUrskbieLAQxCIDaPUU+LbdzXJHM0U6Y5+cJ+6r3yghYhrkbPSOykuFNcX5RiLex0YkvUWe0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kxfeimGn; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kxfeimGn" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493bfe9f886so16159325e9.0 for ; Mon, 13 Jul 2026 05:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783945691; x=1784550491; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7skRcqd0vjDN4v5wBU1b+5yQxdtAYY55BU9Ndb/1BdQ=; b=kxfeimGnt44PFZVIvGfJsH+Gh1rHM8JNqdHQdUrNTf5fVBuIS1X8h8eeP8L/6MReZP yW4NjwLAb6rwOnYt5HMRpYbAHrSxnPx057St+hEYObB6fl9L1iq3IP5slcx03Uy1h2Qs rkaraLMSSp4D1j3v+R+BAmymarIkvqRNuyC7VkwEFiz0OeWFXjwwiRVe7xtIrcCwWHUy CzNcF15HSo1wVvW0xyaImJvHkozCRJyPLRGwpvWqYE5WavRyCBJazCVRKt+E+oru2KNn YHid2XeXumcr6I94MPIwRBujA3DISnPHQdOTWyLvW4e+v/lVYpzYNr4YJ09hg4nBg/Tb jGXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783945691; x=1784550491; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7skRcqd0vjDN4v5wBU1b+5yQxdtAYY55BU9Ndb/1BdQ=; b=P3kosoW1Pp17knlXVfFhrzWk6uZXFrXE0ibMX2K5WviQ+bGBDWNdslKY7BPr4oLd7k k4LE1CQmKk82o4wsWQSoQvTi1CRslbw3rsULFZCHPsGM3D3V+77RqXPwRtjax/t9pAk4 dZ3Uw0KEJK5kXxWMBwrAGwvAQGSmPPY6kQf8ackryUbNJMboEWoSGj8HkvQZ/8svhUcn Fap+Y9uZjOJGXhjibrGScxK8V2J3Gawp0P2lS8wm5o5nO3AHjnAH/Fji4yNl1PqhIhU+ eZkd10/b6feJQfsmIhmfe4GOZypJeAyaPA8E6Z81COVPOBI41jhWBDlBmYs/einEfYIY i48g== X-Forwarded-Encrypted: i=1; AHgh+RoRixF29BnDcEKXze68nrdU+sxYNzKatGHxsfa60WHTtzqKhsyjP32nHycuXJJbTUFuvGpK5MTZeJgokmo=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc2RYKO9ZaaXAjrQjJ9fJhT3J6kWqNved1XbzLRKSSiSg51p34 lc8zAWrjLuf+CwYrUynq68zop4QcKd3M9ezGJnFLnIsiBdnc8t6oihEP X-Gm-Gg: AfdE7cnLQvDb7ncobEZDBqSvDlVm5AG1RGW/clWas3fI257uKt7scWTtNfeLwwDojFB Tebm/FADetxSue+vDdym5op/Tm49aIdUaCr1ehBWYqImwIEMy1Urj8yh7JPgIGxEFkDR0+wiFrO xN035oq8g/7oleWgoOMlbcKV8YRIJP6SlE8G21Dlq3Qd+yYP0yBR84YHbvBLYp94YzOTw4gpN2N lr5aJv8DYNEccFMs21smp+R45Z+zOYuPseaTR21KTTcw9okAxL5Al8UxAxoTFXmi/37EiZU/TRL GceTUe+2mXOmvC/0kN4sW4xbkr8HyI7FxHl0SdAh0RbkvUEqPAFCo3RoIXZweD/TUw5HBCckX8t 3LbpTgbeI5cxv5Bdu/r0nK4e7NKjU4HCT2QcDOIF/hCZBEsLBKdus0AMka1yvbDr55mC8sMMXJP oY4hKZ5jRRpDGr+Ku5cUQSBmTrxVpZG1tCfVY19TCKQRNpW9QLjSslN8iUfU/W4U24WakKUJqaU 8H4INhSngwMsSGN4Vr8kE11NhT/hZhRJJZHpjwfx+C5s/JgJSXsMt97iE3GonWrMIKOE5zLNjkC UpyQsCE6Km7CwjrNKcw3fbmqqAmhjCJ7oDEMeLWA5UqSBM6i3KTqYTtXkHvpS97zTodtwIxI4EI HgeFhmspO9LPaWsiXC3C6Gi4tCDEJBtswnw== X-Received: by 2002:a05:600c:a4a:b0:493:e9c2:ba60 with SMTP id 5b1f17b1804b1-493f8820ab3mr90094655e9.22.1783945690946; Mon, 13 Jul 2026 05:28:10 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6f16cfsm363354705e9.12.2026.07.13.05.28.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 05:28:10 -0700 (PDT) Date: Mon, 13 Jul 2026 14:28:09 +0200 From: Joshua Crofts To: Vidhu Sarwal Cc: jic23@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, shreeya.patel@collabora.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev Subject: Re: [PATCH] iio: light: ltrf216a: fix runtime PM reference leak in error path Message-ID: <20260713142809.000058ef@gmail.com> In-Reply-To: <20260713022829.234370-1-vidhu.linux@gmail.com> References: <20260713022829.234370-1-vidhu.linux@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 13 Jul 2026 07:58:29 +0530 Vidhu Sarwal wrote: > ltrf216a_get_lux() acquires a runtime PM reference by calling > ltrf216a_set_power_state(data, true). However, if > ltrf216a_read_data() fails, the function returns immediately without > dropping the reference. > > This leaves the runtime PM usage count unbalanced, preventing the device > from autosuspending after a failed read. > > Fix this by releasing the runtime PM reference before returning from the > error path. > > Fixes: 83f0bcd40d5c ("iio: light: Add support for ltrf216a sensor") > Signed-off-by: Vidhu Sarwal > --- > drivers/iio/light/ltrf216a.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/light/ltrf216a.c b/drivers/iio/light/ltrf216a.c > index 3f34ddc911b4..3ec239eb5831 100644 > --- a/drivers/iio/light/ltrf216a.c > +++ b/drivers/iio/light/ltrf216a.c > @@ -247,8 +247,10 @@ static int ltrf216a_get_lux(struct ltrf216a_data *data) > return ret; > > greendata = ltrf216a_read_data(data, LTRF216A_ALS_DATA_0); > - if (greendata < 0) > + if (greendata < 0) { > + ltrf216a_set_power_state(data, false); > return greendata; > + } > > ltrf216a_set_power_state(data, false); LGTM, Sashiko had an issue with the fact that pm_runtime_mark_last_busy() isn't called before autosuspending, however pm_runtime_put_autosuspend() already calls this function in its body. Reviewed-by: Joshua Crofts -- Kind regards CJD