From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@linux.microsoft.com>
Cc: kotaranov@microsoft.com, longli@microsoft.com, jgg@ziepe.ca,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma-next v2] RDMA/mana_ib: Adopt robust udata
Date: Mon, 13 Jul 2026 18:22:53 +0300 [thread overview]
Message-ID: <20260713152253.GP33197@unreal> (raw)
In-Reply-To: <20260713100955.3512145-1-kotaranov@linux.microsoft.com>
On Mon, Jul 13, 2026 at 03:09:55AM -0700, Konstantin Taranov wrote:
> From: Konstantin Taranov <kotaranov@microsoft.com>
>
> Enable the uverbs robust udata interface in mana_ib by setting
> uverbs_robust_udata and converting the driver to the new udata
> handling model.
>
> Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
> ---
> v2: Removed the udata request for alloc ucontext
> drivers/infiniband/hw/mana/cq.c | 10 +++++--
> drivers/infiniband/hw/mana/device.c | 1 +
> drivers/infiniband/hw/mana/main.c | 29 +++++++++++++-----
> drivers/infiniband/hw/mana/mr.c | 15 +++++++++-
> drivers/infiniband/hw/mana/qp.c | 46 ++++++++++++++++++++++-------
> drivers/infiniband/hw/mana/wq.c | 16 ++++++++--
> include/uapi/rdma/mana-abi.h | 2 +-
> 7 files changed, 94 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mana/cq.c b/drivers/infiniband/hw/mana/cq.c
> index f2547989f..a5757847b 100644
> --- a/drivers/infiniband/hw/mana/cq.c
> +++ b/drivers/infiniband/hw/mana/cq.c
> @@ -27,7 +27,8 @@ int mana_ib_create_cq(struct ib_cq *ibcq, const struct ib_cq_init_attr *attr,
> is_rnic_cq = mana_ib_is_rnic(mdev);
>
> if (udata) {
> - err = ib_copy_validate_udata_in(udata, ucmd, buf_addr);
> + err = ib_copy_validate_udata_in_cm(udata, ucmd, buf_addr,
> + MANA_IB_CREATE_RNIC_CQ);
> if (err)
> return err;
>
> @@ -105,6 +106,11 @@ int mana_ib_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata)
> struct mana_ib_cq *cq = container_of(ibcq, struct mana_ib_cq, ibcq);
> struct ib_device *ibdev = ibcq->device;
> struct mana_ib_dev *mdev;
> + int err;
> +
> + err = ib_is_udata_in_empty(udata);
You should use ib_no_udata_io() in destroy/modify/resize flows.
Thanks
prev parent reply other threads:[~2026-07-13 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 10:09 [PATCH rdma-next v2] RDMA/mana_ib: Adopt robust udata Konstantin Taranov
2026-07-13 15:22 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713152253.GP33197@unreal \
--to=leon@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kotaranov@linux.microsoft.com \
--cc=kotaranov@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox