From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91FAC33A70A for ; Mon, 13 Jul 2026 16:16:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783959403; cv=none; b=cOBJ6F7QjC3h+dp0CVM7a7XCJvWw5IyH8afkD62Fs9t3xErRpa3ZHntzmvBaWAmvkj7KSMWNlUuykYDVV9g6OiNij3sHvSexZ4XpUMTfcs6/tDoJo3Ei5RDPk02kNJdJM5GcQe6UOAR4+ReVFO91EMkuR5MaVg3mNqvRMNVxb6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783959403; c=relaxed/simple; bh=o/3X8qJfS04d5H4GJiWk4LFrZzJZM/gUAGPj9Rj5yF4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QZjANcIzlsp3vRf7pubb166gs8uhPUhNwBrEO7+2IeKWn3TVEGzr/R7S7vxGpfbjQ+bHx87VskvBQnb9noBK7vy8k7gu5dIdV1+4zBqkHVOrq2Pp1XzKiw4cZMOeCOKWbILpXxlqrHKq28M21+9mHx5C/VjRnfcU9vhIF/y19bM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=lYle7BJU; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="lYle7BJU" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-92e5c92c389so167480585a.3 for ; Mon, 13 Jul 2026 09:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1783959398; x=1784564198; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=dpixIpjcDPgpofyf+7cua6RAMpmGcsNH5+NcZZyFYf8=; b=lYle7BJUrJ4PICStfQLnUhhTCIpHEXcRpD6G8NUaxKDVeumTr5IhULTC9NM8iVpgR2 LuR96KnMOsgMh3PBsoJ6ddJx/XaaoUhgXzmofAt8JyChx+x0PEKLItUDVVSCsURoBD9n nEXHCeYGzEN2a7CO053Ri74CLM+dY1pXfFCjnCOYDpqXtxKttxLXKyyT+UKikcARb0PF AVp+xnVb/tHIpTUUnlxTe/IXRa1GLNvQzuCL16u8VXVFj2cIspYXDNdqDSMYwEtLmJ+a xV0nyt45qCvdtFPtm6Bzu/0HrAMswr5DLKXoV8hqcHfj5nkUmt9Zt0btxjt9bc6bAPck YV7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783959398; x=1784564198; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=dpixIpjcDPgpofyf+7cua6RAMpmGcsNH5+NcZZyFYf8=; b=oVQNsP1NC16ZuRpxzJGIm7oQ9ovCTRSyggw1PGMfPck3oZqf+btDlyxYD9Rr6vZ2/Q qg9mTtL7oAu6cv4et/Vd2Nb07Fx687bAI6RLzmCyzIEkLr0dniXe2uwszMwn4y0ZjkGk ko6jRLeq3ibJw1BwW9VXQ4elNGgiBvfN4ZRSXch7jV1RZ/IiovWI+9SaRNAx+Z349zg4 H+rm0mbvYaE7il/tv2/Bl2rkxkAoUoNnUYqhoe032iqKnTF7+emqhOrG8Q6TrK4D5ycv v/DSlZh0UPGgV+qVG/VaQ4kyAu0kv9kxcDZqvCEB7zXbQqfCXQM6/RRi3MEmmLYa9w73 MJVA== X-Forwarded-Encrypted: i=1; AHgh+RrezDUxYc2mokmdiFVbsKjgR8UfQGd8gRhBdE/oNBhxJydOXdoMpIuRY+khg5p/Odrsapp6QQ3cs2aVseI=@vger.kernel.org X-Gm-Message-State: AOJu0YwgW3kdr7ukidKcUH4f3LbELHaHnaeSaD0aW4Cb8gpJCv9zh7Te 1/4QJn+pJ7Vd6W3vETx3aH6JpAikQCAXoPMhzMgVhMuKrrnw/FbJCwEpVieP8Q3Q4aQ= X-Gm-Gg: AfdE7cmyyNPh9jlLI0vzXb9YOvvhlAB9eFYvSCM6RPxgLz2xi8GOa5fZemFdWeVKgZj CnxWV3BFArZbDadmVDhNF37G0afWK/UAvuTkjC9lQRyK6OvTB1Z7Ch4ZAdcjCLo4eNCtuZ7VkXh 5lxtwXQ6EjxsDLhx7VHWxYTaOZ8nL2tVZS2ad94W5oiXsTDvm8oJbPBBcXmtzVPqaaRf74uxGYo LjWprELy2kCBSZf+tVrZSnqy6YdisHhqK6xsq8NWBlzuN4d9Ke6aqxnUXqq2J//E6jS5eqsP1+0 MAimLZy97uiAFd3u1OhJ4SjPAINVmbLk/IScljIJ66UJl76X30E4XN8f724xu2+ryJIGT7s2cbA o10TN2VMiKzGH89Fm6xwdCej1yFDUP7nT4lPybqeU/vM7KA4g8l+G74Xb8WOj X-Received: by 2002:a05:620a:488c:b0:92e:f1a9:7d39 with SMTP id af79cd13be357-92ef2ca77b1mr915627685a.62.1783959398290; Mon, 13 Jul 2026 09:16:38 -0700 (PDT) Received: from ziepe.ca ([159.2.72.92]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92ee5b8b3f2sm1106407085a.13.2026.07.13.09.16.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 09:16:37 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wjJKf-0000000DYTi-0Ihx; Mon, 13 Jul 2026 13:16:37 -0300 Date: Mon, 13 Jul 2026 13:16:37 -0300 From: Jason Gunthorpe To: YeeLi Cc: kevin.tian@intel.com, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommufd/selftest: Fix dmabuf leak in iommufd_test_dmabuf_get() Message-ID: <20260713161637.GD3133966@ziepe.ca> References: <20260707030635.221577-1-seven.yi.lee@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260707030635.221577-1-seven.yi.lee@gmail.com> On Tue, Jul 07, 2026 at 11:06:35AM +0800, YeeLi wrote: > From: yeeli > > iommufd/selftest: Fix dmabuf leak in iommufd_test_dmabuf_get() > > When dma_buf_export() succeeds but dma_buf_fd() fails (e.g. -EMFILE > from fd exhaustion), the dmabuf is leaked with no dma_buf_put() called. > > Reproducer: exhaust fd table near RLIMIT_NOFILE, then repeatedly call > IOMMU_TEST_OP_DMABUF_GET — htop shows unbounded memory growth. > > Fix by calling dma_buf_put(dmabuf) on error and returning directly. > > Signed-off-by: yeeli > --- > drivers/iommu/iommufd/selftest.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) Applied thanks Jason