From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AE2D35AC01 for ; Mon, 13 Jul 2026 19:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783971623; cv=none; b=Dlt7EKsQM4E8XZayN0IdatItB9B9Tm7qNwVYsJAsivnbUXEvoxLiorK0FZp9JHDTqjGGH/y0yOBTZ0Oxb1jaAO4daukaYM6vY49Z9QCnIWZNTDoUbv+TlwDNKMNUkBMsKDQoPbM1qZhUjYLGd+X7Y9DhYWxRGBWLD/jzC2JahkE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783971623; c=relaxed/simple; bh=Qb2HIoMSqWqjQCWpGfmBQN/eCpG6jcj8qiqVtJGiIdc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R5rlgfkB9FTxNkdyjGbyTyj1WlBWUqn1luaGkR6dXAqFilbai0g1M7g1VFceW/IVlvFAJgj1a08P3bcbBsU7uoqdgviyFeOHBZPUtiIJqe9re26Sxob319yeoN6KEhyAR7+Z8QvXmifJylO2g9XIK9IQwXeIK37yo53cvp+EvpE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0sec.ai; spf=pass smtp.mailfrom=0sec.ai; dkim=temperror (0-bit key) header.d=0sec.ai header.i=@0sec.ai header.b=Rt0Okg/R; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0sec.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=0sec.ai Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=0sec.ai header.i=@0sec.ai header.b="Rt0Okg/R" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-47640541585so1683255f8f.1 for ; Mon, 13 Jul 2026 12:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0sec.ai; s=google; t=1783971620; x=1784576420; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8SE6mH/eebwrYuJdjdXRg/YfI81pgkyA3KxLJxVspBM=; b=Rt0Okg/R7m2LYzMem/ylCjKCEzz69c8dLbMOcZti5wRcXsg1ktmSA7lar8vT1POltc eA/DCf7sMTam6DmzQZ/uEG2ycSY6mvUcI4pFSQ0BCat8nNIZKSEZDAYqO29MgEKL7meO 1jCh+8ortx6Q5Z4RMUuxOsoyX4yl5iHU+ST0bVip6L2s+VseD+vroJwrM0SVba7N1hlP Y2g6GRcfneRw45jJH8hU29kg2YDHdPXmIqHdMnSCLSZlvXHPuhDbTWFG33wlqeLNGhUI fmt9B2yuuAk74yNuvkCKFGFWNVYwvqsoQTr098cRgvM8Ilcb9jQsQCXblbI6Bj2EnJm9 grrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783971620; x=1784576420; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=8SE6mH/eebwrYuJdjdXRg/YfI81pgkyA3KxLJxVspBM=; b=WPAMa6WK2Gzc+kGwZvcYWJ2EMFofmyHdPemhkTOQO03Esh1NvIaPhdEpl/Y2NKbPHe kNASDpWubwvO9+nXA+SWb0yRYUEuXzuEgpU7xxAEwAyTnnGGhaDMcoVMHOtkaACoM6Ag 2+MHYfTfDbJRtdh+gNB0V3jypjJoVNRm9GDF5kK+hRPdJ6DJevFeU/6UXnV0pRIrwKUT J7R2qKbQ6f+L2KSEnkpcrOez/+RX3TH/7bW1zTN7n1dp+O9TXhV5IJa3vd4sVpUhbRpm oSIaAF9GPoRqeKDPXlULiwyZV2YcVRa15VBiMTnleQQqsbnDGibIeH5G8AOnXPX8ShTb a3TQ== X-Forwarded-Encrypted: i=1; AHgh+RqMLeldoJ+VW7bGcz9KPlwsibM3x9pPRvAsomvorKacm1YyDZiZqfYpvzhJKPp4no+QOb0mCvnpkJko1co=@vger.kernel.org X-Gm-Message-State: AOJu0YwRTQV3KVtoLx1UiNkg1wA/TJ9GGYv62/TdM4HKHKpT6uEje8qH twax2BMe49157LqDidMXt5zk2f6j4sox1kbMUIFkEEHZsFUA3zOLoJrkR3edFXL+G4xXEhLM5HI rLk3y2BlQ X-Gm-Gg: AfdE7cklUJW/474o/VTowAy2HRuUDf8cb15IXW355EQY8Dg/wBw4XiRtNyqluySQjIW V1zNZyV/FQon145Rvc/kbY7NVPhG0fJFApDib99az78Truf1ovnGBCuEHnuZ3HkW+kFnDi07L0b 16AlvsYoh7Huy2fZ5cXlRPQb2ihOe66WYoqOou2DlF9+Mo8lRqAbz6ZktnjfNfR7Gfmoc9yNSqr I6pJLvEyiAgXrG0qqafkpHSw1sAV7TwKoXoVweHvW9Lm9tUAdDJMysodBVFlpsnmkUj9M/7+6Mi bJvxBI3rXWlYtP3ro7pvQ1w5JPRgtO0WeTXMQYhr4RgtTcY+Vozb/wpivYEhPW/461P51UoqkqY /+8mzGXupagc/HNuso14zq5ybY9cIfbZpZXNNwplrBWQR6qgF+sBxsaYwldUCQIG71SREh89I3m ThbL1qK3KidHZk9i21EJxiPcms9lpZEnAhPg7tmfIeUP7EbmqMgscbGblrmHilEG1HcU3Ztg2jK SbU8qyUrIChmvBwfFTh+Ie4HT/fiCR50Lg= X-Received: by 2002:a5d:5846:0:b0:474:9002:c74a with SMTP id ffacd0b85a97d-47f2dced169mr11560342f8f.35.1783971619960; Mon, 13 Jul 2026 12:40:19 -0700 (PDT) Received: from PeakBook-Mini.tail8e484.ts.net ([178.197.218.188]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f464c4320sm1648928f8f.32.2026.07.13.12.40.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 13 Jul 2026 12:40:19 -0700 (PDT) From: Doruk Tan Ozturk To: Vladimir Oltean , Andrew Lunn , Florian Fainelli , Woojung Huh , Nick Child , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Sabrina Dubroca , Arun Ramadoss , UNGLinuxDriver@microchip.com, Michael Ellerman , Doruk Tan Ozturk , stable@vger.kernel.org Subject: [PATCH net 3/3] ibmveth: don't read an unset MAC header on transmit Date: Mon, 13 Jul 2026 21:40:10 +0200 Message-ID: <20260713194010.54642-4-doruk@0sec.ai> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260713194010.54642-1-doruk@0sec.ai> References: <20260713194010.54642-1-doruk@0sec.ai> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ibmveth_is_packet_unsupported(), called from ibmveth_start_xmit(), reads the Ethernet header via eth_hdr(skb) to test the destination address. On the AF_PACKET SOCK_RAW + PACKET_QDISC_BYPASS transmit path the skb reaches ndo_start_xmit() with the MAC header unset, so eth_hdr(skb) resolves to skb->head + (u16)~0 and the read is out of bounds. On the TX path the L2 header is at skb->data, so use skb_eth_hdr(), as done for the same class by commit f5089008f90c ("macsec: don't read an unset MAC header in macsec_encrypt()") and commit 96cc4b69581d ("macvlan: do not assume mac_header is set in macvlan_broadcast()"). Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor") Cc: stable@vger.kernel.org Found by 0sec automated security-research tooling (https://0sec.ai). Assisted-by: 0sec:claude-opus-4-8 Signed-off-by: Doruk Tan Ozturk --- drivers/net/ethernet/ibm/ibmveth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 73e051d26b9d..88e8bdfbcd11 100644 --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c @@ -1218,7 +1218,7 @@ static int ibmveth_is_packet_unsupported(struct sk_buff *skb, struct ethhdr *ether_header; int ret = 0; - ether_header = eth_hdr(skb); + ether_header = skb_eth_hdr(skb); if (ether_addr_equal(ether_header->h_dest, netdev->dev_addr)) { netdev_dbg(netdev, "veth doesn't support loopback packets, dropping packet.\n"); -- 2.43.0