From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 553613D47A9 for ; Mon, 13 Jul 2026 23:38:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783985892; cv=none; b=o7/tytzAjjXv+cEaOCvBXtGOfGYYLkw8Jvqsupr862YI8f44HKBwo+IcRBYATHN2QG2gblvYgbc0wooEa3LYtPQQB+ut2Q1ZjyUQakEGSeABaDTCdodtNzMFUYoFEdeqH3bQwBxS6efasMAgKQK6EyOjDSChZSFvf8hJUaUGS1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783985892; c=relaxed/simple; bh=/00cRYn0DsZnB/nldo8mYbZIQeKonyJgnletLxrLHdM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BAkb8mAjSwwiH7s4rRgLnGFXcKihTY8x9NC2P3fw2p4pkFvUy4BpiaO/tSkfdZBIHA2hDx1Pem/uybUNHhWFrA50XanHbWhcrAwV2HDnA20y3gNJ6eWyo5M2Su5sIax+Fpwtqq+R5LR6qlEFadeca/9RUfrfNNYrUU4mfeN8iTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gPNvv/ET; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gPNvv/ET" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2ceb096e675so25144955ad.0 for ; Mon, 13 Jul 2026 16:38:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783985890; x=1784590690; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C11haklYJCflJ7xXpeAfmRSpmnlxr53KIUoMp0xcj0A=; b=gPNvv/ETN90xq8gdeNumk2D4vY1kefQlOTUE7WfODCKTp93U7E9Ld9U0LWAxQipWuA ywE6m7GUv1iDxOB29vu1fbcXzaoJOVFiDaqocap/UymoO9GHpuCWs9N8Kzqw7F3Z9QQ+ 0cOmW5l/jTFhvOem1LrM4KmlxVe3Y1UVe5ALnYqBNF+5wbyxEFNt2D5fIPxwXye8eAxr YNAtbt9TDMLELlOXHZVJ474diDmaIHtZTvmO04hAiY19HOOm4OhLQfoA44Bg3Zj73nOd D1DFBRIwmtpzKOhULeoSiubs0BQa9ZYOd87ph62PWz8L98P51AfgbPPu8Fi663JKxawh DL8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783985890; x=1784590690; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=C11haklYJCflJ7xXpeAfmRSpmnlxr53KIUoMp0xcj0A=; b=M0WDyNcmPV5vkOsj0ed5yuXacYblpW+D2rULYixfejBIkFHCTFd0Wn4DrhgKpIyruN +fcCbL+kUnpW1pghi6EAaGGYifKyel8KcqUdK+/gVNlKQEqhpFbjzEzNoDUjd/XI9d1O QXhAafyjTscY/BApADEmaNjI/dfJd7ifxIzPeRzTPDHNiCrYf5+LfR3r4O9u0bNAr1kq w4TGzGhGrXRr+6/CuQnT97zBlqwUPQQVIz084tfGV/YgaiRHiVejPHEd9IM4z/J9V7qa EbVdIQy/Vp7mt7J+UedQwcgRsm/Luu4ED7bYYJKGv5JP2il2wSLhoHqtj64Y4Yc7A7xY PzMA== X-Forwarded-Encrypted: i=1; AHgh+RrS7j9jqvpeY+XZtyxMx2IOsM0gLi8baXQOZy0jYz5WuMC/rDu3NqGnlNM4M/wBHnFvtUJlQNp9IGKentU=@vger.kernel.org X-Gm-Message-State: AOJu0YzyM85ND/DPyN3rxGpM8ZD68DxfX82xF8tBNPmYI2o3KAI1ILv1 M3IClFP6VLRGT1oaIG2d5ekqP44LqrnglKt/CEOT3yHbmqyNmPLOh7Ze X-Gm-Gg: AfdE7cnAIZo6NSO03QB+1HD6/ZSLGYyHQ5TE3Ly00aefUJI6C5VGPHKncgfSUJf54e7 OOniEyDv4PUpnM7WoPRKXgpKkXbFrDUcFqAZ1LvoA5T2UfP/p4coGEinFduDIJ7bT/PPW6WRj7C K7tmEwLt+etnWyl5fvgjGP8cRU8FSHJ+/Bhg9xkvABK9ildLW676nJxTIzg8kJOXWDAy5InH2w0 cW2WAVUzxF37Dv/xio7Pd00UDi/4rVX6tFcUuQLmx6XtGVCop/X7iv6lNApyk5d0i4E5YfUUN+V +aW51PKxp+5w1/u1lZmRhUwtEDfKfN0RxEKzn0dQChL+ZcvPya6I+o5s4EGSLmBOnjSiYSuf5i6 dbOgaxkqy7FhwrIVui9WbPkCHo4UDDYVSU4uFGOItCK0Ti/oXx3ROfZzKSUa3MLpQFqTqZK0znb IOX7Oeb0htQsKJYf5rJ3jU/JdUNBFtgVbEZA3DGiFelRjAKWhoJ/R2nTySUCtimVoGHXb/TWyOl Id6Lxcxvso8S+Km0aiCr1tiNT6LPlE+z4Mrpw9CaeB/3uIQqW1yP4n1CRMoxtQ= X-Received: by 2002:a17:903:4b2b:b0:2cc:76fd:6537 with SMTP id d9443c01a7336-2ce9e7a53edmr99065725ad.2.1783985890419; Mon, 13 Jul 2026 16:38:10 -0700 (PDT) Received: from bloom.localdomain (S010680dac2bce256.cg.shawcable.net. [174.0.186.197]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d1eea1sm107151175ad.46.2026.07.13.16.38.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 16:38:09 -0700 (PDT) From: Ivy Lopez To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ivy Lopez Subject: [PATCH] staging: rtl8723bs: use kfree_sensitive() for key material Date: Mon, 13 Jul 2026 17:37:53 -0600 Message-ID: <20260713233753.50816-1-skunkolee@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260713233401.48262-1-skunkolee@gmail.com> References: <20260713233401.48262-1-skunkolee@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The set_stakey_parm struct contains a 16-byte encryption key. Use kfree_sensitive() instead of kfree() to ensure the key material is zeroed before the memory is freed, preventing potential information leaks. Signed-off-by: Ivy Lopez --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c index b932670f5d63..a34ee407285b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -899,7 +899,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 unicast_ if (enqueue) { ph2c = kzalloc_obj(*ph2c); if (!ph2c) { - kfree(psetstakey_para); + kfree_sensitive(psetstakey_para); res = _FAIL; goto exit; } @@ -907,7 +907,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 unicast_ psetstakey_rsp = kzalloc_obj(*psetstakey_rsp); if (!psetstakey_rsp) { kfree(ph2c); - kfree(psetstakey_para); + kfree_sensitive(psetstakey_para); res = _FAIL; goto exit; } @@ -918,7 +918,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 unicast_ res = rtw_enqueue_cmd(pcmdpriv, ph2c); } else { set_stakey_hdl(padapter, (u8 *)psetstakey_para); - kfree(psetstakey_para); + kfree_sensitive(psetstakey_para); } exit: return res; @@ -958,7 +958,7 @@ u8 rtw_clearstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 enqueu psetstakey_rsp = kzalloc_obj(*psetstakey_rsp); if (!psetstakey_rsp) { kfree(ph2c); - kfree(psetstakey_para); + kfree_sensitive(psetstakey_para); res = _FAIL; goto exit; } -- 2.55.0