From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83CF3371887 for ; Tue, 14 Jul 2026 01:52:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783993923; cv=none; b=QNAetWe7BG8hQJ6A0+crdMs0Og5TEtyhG5En4iA4hnqZzX6Y3VewBepsYKmSYKWua/H2OgfwpcCGt5VffXIV/x9wig/ins7IUlG/OQpX/0Pz/Q049ZOSmPZqICMopU890GxODXHQfwUq1nJqrLW6dK+x1SuHqPjxSmz5+hjfQ84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783993923; c=relaxed/simple; bh=7FBU8wLQenp8S4RfUBTR/9Bb7RAV7+7hhhc02OaqVjo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c0xzUNnpSkPGuEdMelpkmb1We3451kJMTO+3I3+M4H2U/qDM4EU0fz7312lf91yl7a8t6LRvVboib1dds/vNE7oI/Q5gOZDLzZF+qLtUYcIv4Ac7mg60C7tcc1DlI/Q5feQPKCKJ+3fT/Py/VKdnVDvRruYH8ij1dJM/WKp1m7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=NDmwAxeg; arc=none smtp.client-ip=91.218.175.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="NDmwAxeg" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783993919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hMPk4xo0goYwl32b+O7Fi24CGRO5SYSFgHPQLi10p/I=; b=NDmwAxegFBJvW/6KgfXr4KpsbluuEfl37QztIvImDOCXBwM6S92epmL0lEqi23eWeuKpVD LgcTfRq5yd/8NVj/p4r1y6TMB7m/4DCbMstBe8+Ad2cLvNmRkvkAi8LVmX47LD78QOAjN3 yB0Wv6BkCFxgHguaP9h+rP9wiPsKaog= From: Ye Liu To: Andrew Morton , Vlastimil Babka Cc: Ye Liu , Zi Yan , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 5/9] mm/page_owner: add missing newline to count_threshold format string Date: Tue, 14 Jul 2026 09:51:04 +0800 Message-ID: <20260714015117.78351-6-ye.liu@linux.dev> In-Reply-To: <20260714015117.78351-1-ye.liu@linux.dev> References: <20260714015117.78351-1-ye.liu@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT The DEFINE_SIMPLE_ATTRIBUTE format string for page_owner_threshold_fops is missing a trailing \n. simple_attr_read() uses scnprintf() with the format string, which does not append a newline, so reading /sys/kernel/debug/page_owner_stacks/count_threshold produces output without a terminating newline. Add the missing \n to match the standard debugfs attribute convention. Signed-off-by: Ye Liu Reviewed-by: Zi Yan Reviewed-by: Vlastimil Babka (SUSE) --- mm/page_owner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index fe2bf2274d8a..7520718f63f1 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -974,7 +974,7 @@ static int page_owner_threshold_set(void *data, u64 val) } DEFINE_SIMPLE_ATTRIBUTE(page_owner_threshold_fops, &page_owner_threshold_get, - &page_owner_threshold_set, "%llu"); + &page_owner_threshold_set, "%llu\n"); static int __init pageowner_init(void) -- 2.43.0