From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C851A23AE62 for ; Tue, 14 Jul 2026 08:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784016148; cv=none; b=KGhfmqt1MPHnnE5uaul3/CNx+cMTfXXdniLl+/3K+zcoUjiO6uqpD96bxZVe7V+ZaTAV6bx0hPdjXNwGbwCqonbMlTe5/FqrwPzaog6iMNbNOlnC3i5xEQsWEraw/HV2gui4Q5GcUar35MFFP4hIKpZsgxMoP6iSzGATMBXckDM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784016148; c=relaxed/simple; bh=xn6FRjCb7BaLOzN9sSeZMxB95itrGogr8EEGOjZL6C0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PGvMmzRKrMNRPorq5Wf4a/KHisSVwzFjP3gDLMs6H+MebeiY97GppFypviety+nnXiboJ/3vYVmxspKRLz3Sw4s68ELJYntQAs99oXTA0laf4Yr5Vmhif0oqhRvRy5BiIwlqyoKSnUjcpmk7TU7871zJrCSr5H6oWGFWwG8OMT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PXGCn1HU; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PXGCn1HU" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47c2b362ee2so3537976f8f.1 for ; Tue, 14 Jul 2026 01:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784016145; x=1784620945; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=zVvBJ4SkbeNu5Hhcf3lSf/7F1/qZ3Gn5ctGfd77mXz4=; b=PXGCn1HUgPa3uQsE9w0QBvdOigOiqThLQBJqS1O2zeA8v1K2b9kBqA1+lBPVG4xzKL OsKBAgJM2vHIPmDZzlhh7q3lrPeAxExwIsN0JVqHjO7clcryc6nyGAtCoVnxlAao6wp5 xqJpkZiMnx2N/wLfu50KD8JUaBLOkXrbNugjk7O4ygeRwYwCOGRM3M70IsC+8sf9U4hs GkzflnCTvZcj8qLaeOoJAOsPWSfJuDOADu4w4cSckJGiwtW1slqqj0SuZvmlcfQHy3JO 3aPFlzv2IyxZ8KoLJGpKxBYwRiVsU/t2feZ8FKOT/UEqnrnoHU4V31cxHym7dFsKzVgI kVVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784016145; x=1784620945; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zVvBJ4SkbeNu5Hhcf3lSf/7F1/qZ3Gn5ctGfd77mXz4=; b=fJvfuxFgqo0OeQNNLLC2cv796GL9224DjAT9pw/0Mv5n/5tafTop3ujoa59fcwz3Ge GguAt38xqRAsnNVna/42HXh18UPcWDASgp17hiXgZFXETXzd7aLyiNSbDAxCiam5V06f TjxN4YoslxWt2v77/or7DRAinP2K1Y2vqK5SZh3vfIWL5uuiC+8phFtASjpAcTjiMQSj LFvZkZYZnflA44UVBi9LyXAC3Vv4nYM1tArfjHn0Wc4Lv2cbg9HEiutFJV/+sbcII5Sp KwlpFFRPdMFnxCodnmSpJcqsXpHt0+IxGUteBnlRTCtgc8uS2ezGlXAQX056hlmvsGGy j81A== X-Forwarded-Encrypted: i=1; AHgh+RphFwHkroHZMbDzZcJgiiLxyWZMbD0UmgNC9ZURduHiFhYnsdrGinDcc9nnr7Nhc6revm9wKNZm6oL17bo=@vger.kernel.org X-Gm-Message-State: AOJu0YzZP77QV+s45QaQ1J3gLl6ZU2sMRneqfdsoArHPR1/nfrG9yxiM dIr4pijYgu5ITgcT89R7Fpjf4DXxelIoQwJGwlpXAJEAY5TR8TcBRjZ7xXX9c6do X-Gm-Gg: AfdE7cntZIF7RNO/tpZibYi1mV656VXh6aEO1vushEsiSHipJknuwIJQfritgXEomXK YgpYeUzVTpS3mVmuEFuSbNh74T/alLpUN4amrPln34PHWatIetKcvLuPQY9CoqQ+Ynz1Cik+4HR 1U1gNvhk2wq4bA/h8MM/GdM3bTQe87R76HgULiCfj+K3dCMv9CYOMRewgcDNTs+wlX+KXt+zS3H sx8Xx2tVeGofh+oWYsnGQus4BnIZ2CrcJ2ZOq3OFu8nHgN+LD4DYH1tcuXi8gc/f+dtoc3B3TvY 0x0rmHoYeiMkscZHoQIbfy/quTx0mMj+fqeXN/4P6ZFcNEpftcRpN+wdjoj9dklaKK07Ex7f3Nw 4A0j/oq3VnLtGQ25U8ZoZOjsfYbMO0i2pPCFPYEDJxxytF1ELp+sCTDpeBjmHHGKRgJPMdIcXzD m53KXDqY5XBRQsexEZfrxQX+lCAf4QogNIhxqqZVE9SV1LKVvL2A== X-Received: by 2002:a05:600c:6b17:b0:492:4a56:690b with SMTP id 5b1f17b1804b1-493f8834e5emr87474225e9.35.1784016129734; Tue, 14 Jul 2026 01:02:09 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493f2a38b19sm243600725e9.0.2026.07.14.01.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 01:02:09 -0700 (PDT) Date: Tue, 14 Jul 2026 09:02:08 +0100 From: David Laight To: Eric Biggers Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/33] lib/crypto: aes: Add CBC and CBC-CTS support Message-ID: <20260714090208.6438dfa4@pumpkin> In-Reply-To: <20260707053503.209874-4-ebiggers@kernel.org> References: <20260707053503.209874-1-ebiggers@kernel.org> <20260707053503.209874-4-ebiggers@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 6 Jul 2026 22:34:33 -0700 Eric Biggers wrote: > Add support for AES-CBC and AES-CBC-CTS to the crypto library. > > These will be used to provide streamlined implementations of the > "cbc(aes)" and "cts(cbc(aes))" crypto_skcipher algorithms. Most users > of these crypto_skcipher algorithms will also be able to switch to the > library, which as usual will be simpler and faster, e.g.: > > - block/blk-crypto-fallback.c (for AES-128-CBC-ESSIV) > - fs/crypto/crypto.c (for AES-128-CBC-ESSIV) > - fs/crypto/fname.c (for AES-256-CTS and AES-128-CBC) > - kernel/bpf/crypto.c > - net/ceph/crypto.c > - security/keys/encrypted-keys/encrypted.c > ... > +void aes_cbc_encrypt(u8 *dst, const u8 *src, size_t len, u8 iv[AES_BLOCK_SIZE], > + aes_encrypt_arg key) Does embedding the 'u8 iv[]' in a structure work? It gives better type-checking for the length of the array. David