From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AA2A44A71E for ; Tue, 14 Jul 2026 12:25:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784031948; cv=none; b=SD/eShbWsRWzsocTWjNQ27gaC+aVViPuwCJ8ZTi92u4h8Dt9gthi0wbrfrHkF7h+323UCCbzy/WiRKceHYhABILeYxDcXpe8qRDDbdzanVQqsiQXnUacF/vEEPnjLh5Lf8wFDAWznQVtMiO9J5LFek8znZ/w8xx4inse7qh6keI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784031948; c=relaxed/simple; bh=2XIf2zfYO3IoU3eABkYodwdH1x5Y0NfwkpbkBroNnIg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eypVdWtkDhHmz6W66DzLEuHA0+z5oskHe7wmofLk5FHI1zVkkXroYOMsYKKbm+dIPucQD7MS3DAsNYrgVyl5Y0YYFEysafDzIaDI3RAEHT4zj8jIyhp+wY4Sk3D4fgsXhY8iVnwLVgrtQPeu3gdtbPEJfghDAXAvPr7+sATUSGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BozY2Nax; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BozY2Nax" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-8486ac3f347so1003129b3a.1 for ; Tue, 14 Jul 2026 05:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784031935; x=1784636735; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ItGCzJLW6JEeGXBfKzcF2ZY989b2KQOyoFBWKsuqIT0=; b=BozY2Nax9hcstPXSQ4k18MwJGVwa+Z8TIzW9LEHzBEJ/ETC7Kdrq2wU859TA9zGODK XJqKgknkvNhVLY3MZnIDMRpNmyBdBsienSNp0MFc3m/XcsR5Xg5H5xv71dVXj/Z6i87o OI2Ip085U76SW5BQTvnP4aEcPrgye+x+We5Ze0QimaS26cdmeVMpzNInzkfW/PvBYtRP kFy88RdvmF+9E6lOnHHz/rDrZU+6WhTlnUVJVeoPXmJXNUzu94pxK8BQwb5fffoNS6t6 /XhwHUF6w/KTEJFGpBIpzwD9SfGsZ0u8FR8AJcaej7kQt/cuGai2xAnACule00Icvo1t X4pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784031935; x=1784636735; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ItGCzJLW6JEeGXBfKzcF2ZY989b2KQOyoFBWKsuqIT0=; b=WmrFLht2U0FoJb83nqFpH2nGESpUZXPqAPoZjmOkRWIM2QyPgXSDJky+eXRPBrC6Z4 tI+N7toU8Vokz1pET3icfFMAYaA6FmCdx89bSkFB+TijwgBrLt5qiSGwCf5k/0xlsMT9 1wrjRo3OJqwtoDh4YhFIB0/zcTowG/vyeK/ATqv6kR6cKrcWbGet3Q5dC7XswXRfaWYg FoFly8A6pVfeTZWOQxtUY+7aUD7/0uyItDrcMcEOs8X9OdEBBymqiye4bCKwB31q6vTY Q2EkuYYvCR+bDc5WScP9pMWSCVo7qUs9g1Bd/bmEj00VxIsYqCaGNfM+kccwWsentNPq gXmg== X-Forwarded-Encrypted: i=1; AHgh+Rq8bNHR/pg1TC3KLOFDuVoZOVfMHFlyVBfjgNDcO+TcnvJDqtx6fNX7AMfbMRPqhmvAeJQuQFWxcLGFVFQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxMWS6kQBVMPoSsZOa49a0PsudnHB1DFDM9AtCMJvmpY53CaXdJ vb6nBWEU5BQfgQ2TpJWF89lr/gZ38at0sy3K9yGujhn30jdXf6rXqU7T X-Gm-Gg: AfdE7cmqwwe+UucO/zrK9vHPzv24+kFIekvp0dQHwwNiZFo9n6RiO+dksULCw+lW3Fy UZR9kf5XCjWCMU3AhfcfNTq4IkKntYiF0RLiJ2ujbBRbCx7ol1vhk1mVcxfqJJpalEFwYi7En2r 2IwiEEI4F/OaQLdhJtiREOWmFwljbg/a36N53kwTvWjsP7dPiDlug2dO2sGboul905ygsBXBx0O 233vWfyWLYN3QwhmKHoyynM4sh1oeVwOT/+g4RNtxm79YHc76LgVLmqh3eNceysxiSOr/xrAptx F7yKcMRwlRxIF8WB7QEANJ3+vlutZLcfM1rATwm5KsE9P/ngkGMTdmImTWIYgL87+sG4lcJy0c8 c8+Z+sj3Zlt/SWP5Uf5m66g39ipSm/lfbfrLoRXK10mAbQvisZL7SYII6s24AaRyOr1ErfcO8hl vLX4D79whzuiGCNuPnD3t981GyKHbBmEhFIl7Sh8rpB1JIvP4Ng1vxVQ== X-Received: by 2002:a05:6a20:d489:b0:3bd:1cfc:1b9b with SMTP id adf61e73a8af0-3c0f08f8997mr22365682637.10.1784031935272; Tue, 14 Jul 2026 05:25:35 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f72a6sm96163178eec.1.2026.07.14.05.25.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 14 Jul 2026 05:25:34 -0700 (PDT) From: Biren Pandya To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Biren Pandya Subject: [PATCH 2/3] iio: accel: kxsd9: modernize runtime PM in read_raw Date: Tue, 14 Jul 2026 17:55:22 +0530 Message-ID: <20260714122520.3201-7-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260714122520.3201-5-birenpandya@gmail.com> References: <20260714122520.3201-5-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the legacy pm_runtime_get_sync() call with the modern pm_runtime_resume_and_get() in kxsd9_read_raw(). If the resume fails, we now correctly abort the read instead of carrying on and reading garbage data from the sleeping hardware. Suggested-by: Jonathan Cameron Signed-off-by: Biren Pandya --- drivers/iio/accel/kxsd9.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/kxsd9.c b/drivers/iio/accel/kxsd9.c index b3acb20441d86..680d43135e617 100644 --- a/drivers/iio/accel/kxsd9.c +++ b/drivers/iio/accel/kxsd9.c @@ -164,13 +164,15 @@ static int kxsd9_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, int *val, int *val2, long mask) { - int ret = -EINVAL; struct kxsd9_state *st = iio_priv(indio_dev); unsigned int regval; __be16 raw_val; u16 nval; + int ret; - pm_runtime_get_sync(st->dev); + ret = pm_runtime_resume_and_get(st->dev); + if (ret < 0) + return ret; switch (mask) { case IIO_CHAN_INFO_RAW: @@ -199,6 +201,9 @@ static int kxsd9_read_raw(struct iio_dev *indio_dev, *val2 = kxsd9_micro_scales[regval & KXSD9_CTRL_C_FS_MASK]; ret = IIO_VAL_INT_PLUS_MICRO; break; + default: + ret = -EINVAL; + break; } error_ret: -- 2.50.1 (Apple Git-155)