From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30C551A304A for ; Wed, 15 Jul 2026 00:25:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784075148; cv=none; b=Bifcz+FXhx+V0xNCvRuQ0z3QL2R79ct/qk+9XOH8yXlD6g12uLK4UkTTAulh6HRWJilnHn11V9pjTJ74V6SUtyhHK7+BayPnTnBEKCh3SQukdtasML09KAqoeXH8LfMxSeiYIoLa/RnIxxy4De4u4Omq8MDcsDLOu/fosbSmotg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784075148; c=relaxed/simple; bh=xnqyvUedQYL2Q7HF+/tpIMXZeGQHHtyjljd6bbNp/Rc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dmAdnSQVV5ZrQ2xbqlZ1Hm6oJS+HdgR0hV/a7VuNdmSKes2n7t36P8o33Kg4tB4gagwDU5wsPM+eE5qZe49fFRCbKG5hNzBA1963igw8wakaYcTaEpwOi/DQZkPbyYs1V9lQ4PEGdVpskZDxhhAfErGBRRCqJKspaTrTPr3GXrg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NqWjcJza; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NqWjcJza" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 374F51F000E9; Wed, 15 Jul 2026 00:25:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784075146; bh=53f5eW+C7l6xeH3yzd2fDO+7tk1iBkcC3ITRebguIpg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=NqWjcJza+Z2/82d3473NB3vUVWSxcIhLmoZPoA/HARxtKXw6LspGntZS6l5aJbYOl aTYLsApwIglx6HbKfzjAl8pR1QvAEkqirNUi64CIYvQ3taEWlbFrDAsHs3TRmqBLuK XMKIMJanpc9byQ/zhbR8WZwosxD2+wRY0zqZvqOU+iR1t0qLXAhmV9kWY+ypRRG2YF MG5SeXsfYxAjFwA61WHO+rCpoqn2qxEFfjvVujYdoBSP+E2jOjE5Vm6qhwSnsRMBQO 2lp+flBkWAP6l3k/sMyibqQZ5JAMfgDKDtBK0wGA15ftVA8sXZFPQOkvZCsg80mq9S lcfNNDGp4C6HQ== From: SJ Park To: xu.xin16@zte.com.cn Cc: SJ Park , akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev, chengming.zhou@linux.dev, qi.zheng@linux.dev, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wang.yaxin@zte.com.cn Subject: Re: [PATCH v3 2/2] mm/mm_slot.h: add comments for mm_slot_lookup/insert Date: Tue, 14 Jul 2026 17:25:43 -0700 Message-ID: <20260715002543.106162-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260714092815120Wv-CFDlLKtsTmda--97Qw@zte.com.cn> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 14 Jul 2026 09:28:15 +0800 (CST) wrote: > From: xu xin > > mm_slot_lookup() and mm_slot_insert() are the only helpers in > this header that are implemented as macros rather than static inline > functions. This may look inconsistent without explanation. > > Explain they must be macros because hash_for_each_possible() > needs the table as an array (for sizeof), not a pointer. Thank you for adding the explanation! > > Signed-off-by: xu xin Reviewed-by: SJ Park Thanks, SJ [...]