From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DE8743C056 for ; Wed, 15 Jul 2026 10:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784110266; cv=none; b=cthZ5PRWnrwxjatQyVIlRwtKEzJzp2tjxt+LcWpxYXsUJYWjTJP4PqvOkChHvMqhvSsaP3Xqssqseg3sYwhcrNPI6ybYTFt60i7QkGjybkv/LZi6vBg0GF7sGkBX5+FI6gViVfPIHkXU0dm99CKUWhPgGAYOLzprMGp4xLSkpgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784110266; c=relaxed/simple; bh=DO4pUTloSCmd0KOmrWJsUS2U9gK6DNRCgmxLFrZRTyY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aWMSgvDkacvuznoLHuY26MhofU+V+BbhivI5bhNxktn3ywZD+8uTWMYk5AvY6K2O7AVZ5cjBs0dKskv81pPaPSrV43bSqbX1+JS0o9GjhEFnW3FQSk1UE69uaRufQlxiVR40mdfjorkwCQkSga7nJ27KC64w1bwFR7CeSfi8ZX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FVTXlJC1; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FVTXlJC1" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-383adaa461fso1418039a91.3 for ; Wed, 15 Jul 2026 03:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784110259; x=1784715059; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VNXyVM0mnowONm4346tNECsZGvG1q+nnKtqJNufizQw=; b=FVTXlJC117BcjWQdJBRHKPXSTi5H9rrFFEDofRSu3aMPyn0emuR1LG5I/lFnfq6y8A hom1aVRIV9N057hMQNkvFW7ukOgJ11LzU/6vWPN/A80ddE+zFzLUoTFBgb3I4Gw8rQxj Q0ZOm7TJUkyZIczLXfP9r5l5fKbe+h5mxVYfMoof9o6bGbjy+fpq9PU2ASlN00YI/bas dGLKdIQGmv6tNInT8NIt4yocE3PtXhhF7wjD+kR9Q9u13Ov08WzfY0MeIvwICMHJias+ bfEGpm0itCMBazmuxtN5l2FY5NCGF/QAcCPvEP++NzBWBzIlG2MeB1m4WDqjNb6UiCrY JSGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784110259; x=1784715059; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=VNXyVM0mnowONm4346tNECsZGvG1q+nnKtqJNufizQw=; b=fbjLflyNOyqkRsy/fwJHXE43FylBD65TT2ycWYHgfRegUoi3xveRrDluw3w3AfHHnb 3rhxobEFFhJfLK5z10vgTOHBpHcePQlTTS27EIa1r0AK7dr8zKv2lq0ZGwPT5xSX6YVr 633kWTFhzDEmcSdQup0T32O7RINp6t+LWOJYpdyT3qf900Kokfd6eX+5tZk2vsEEddCx a9hGgujmTZWswTeU2WgbPj06h+gEfVHcENlUDsvW6A/sc2+nUcmQfRghSGAV0mdn2o+F 9rQgt7Rhkoe08woB6/LKx2sUOZ73Gy2dZoRBj3Ajw95zVCX56yc18+iJ1OeL1tCzzvBe /UWQ== X-Forwarded-Encrypted: i=1; AHgh+RovGYqMppNmjTpzKbfLrEVTtSHFB8tXs9H/FV2ybmpJzoY2gzcucSFdQLtTo1A3MuiUMADD9Zv8eOa68qI=@vger.kernel.org X-Gm-Message-State: AOJu0YzIZ7REul3SzS3kYSPAzJJDPMbkPdtrqwqXuCetXfw+ZdI3OUjT d2XsY7NT3pWYKVdP2syLF/xPKZEAyfDr7XmrVtMSlJa/QKhRsxfnazvt5WgeYA== X-Gm-Gg: AfdE7clzocbWjr0f83N4k/KgfWIxtTcTiajkp7CpfjGg8PjG0b/ej5YhilI0a3oELwJ TwmeJPtSGPPM+Ep9lNiTaflBPJHQiKTreLcC9Kt2LR+qrisRcM86FUwrBO6ZG7gIdMKVtDlzzI5 kbqiZQojms9bLL1NKHQRJ293TAe5jPkxmo3Tlt0e+pQij8HxD3DdbJmXKQnu0LOkeVdurHtyZr/ EQCGWm1HYBEkc6X6hjxth52ogmZmQA/trsqSNo8VQduIkkFN1hyRIuXKtceSb4OAcU6to7tOJL4 33Wrbh5HWBg+b7XFGFi0BS+KLVkEdZbc7hou89pj950D65AkJi5dxmkZpItlFfjb3h0NInx+hm9 a+6v0WZyvHh1CHZBMzhlsYfh9ZbAvSXuG0BWDAr9N2L/dJcFE4UirYpL+f0xZA3ktpTLuh5xY/o 4BRqckVo4sMh2MzRx3JwNa6wKdg0ZX/YN2VSMXFUrY X-Received: by 2002:a17:90b:2b43:b0:380:21b7:e727 with SMTP id 98e67ed59e1d1-38dc7a494a6mr16685376a91.14.1784110259262; Wed, 15 Jul 2026 03:10:59 -0700 (PDT) Received: from primary ([223.181.23.34]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3119c2a7bb5sm62079757eec.25.2026.07.15.03.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 03:10:58 -0700 (PDT) From: Vidhu Sarwal To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Per-Daniel Olsson , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, Vidhu Sarwal Subject: [PATCH 1/3] iio: light: opt4060: Reject integration times with a non-zero seconds part Date: Wed, 15 Jul 2026 06:45:42 +0530 Message-ID: <20260715011544.281148-2-vidhu.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260715011544.281148-1-vidhu.linux@gmail.com> References: <20260715011544.281148-1-vidhu.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When setting the integration time, opt4060_write_raw() only uses val2 and ignores val. As a result, a write such as 1.000600 is accepted and programmed as 600 us, silently discarding the whole seconds part. Since all supported integration times are less than one second, any non-zero val represents an invalid input. Reject such values instead of silently accepting them. Fixes: 0c6db4506ad0 ("iio: light: Add support for TI OPT4060 color sensor") Signed-off-by: Vidhu Sarwal --- drivers/iio/light/opt4060.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/iio/light/opt4060.c b/drivers/iio/light/opt4060.c index c391ad3271c6..cf6f69e5be35 100644 --- a/drivers/iio/light/opt4060.c +++ b/drivers/iio/light/opt4060.c @@ -632,6 +632,9 @@ static int opt4060_write_raw(struct iio_dev *indio_dev, switch (mask) { case IIO_CHAN_INFO_INT_TIME: + if (val) + return -EINVAL; + int_time = opt4060_als_time_to_index(val2); if (int_time < 0) return int_time; -- 2.53.0