From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2914843C065 for ; Wed, 15 Jul 2026 10:11:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784110266; cv=none; b=slEea1n/Mgbby1pALBO0qSawkB9Gk7QiocrRyBd4AEHSeyUe+x9VcGLJsAXAlyuDYyHwKtZ3BbwDns7NUMHtMnLV1efuOR6sS5t9+Qv/icAqmiP9R3sc9l11KmLUygaAqLw17jz0iU5Qyolem/SU9OxkLmgLxpzNYkvTuJG8zSQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784110266; c=relaxed/simple; bh=yXQameaNSRa+QXBKj6CBG0heh79Z1cjYE9sx8sHKO3w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=djsP+qv756JKiObTp/AfX9thamfq4ecdP7yMreK/YTGxA27NMFSSQ9TdgIyG0NydTir+aPnYzyGk4cWSU4x3VthYty7eMZpPBmlBK412JLJBLz0YZLGhiNWw0tu4vsz2/JNHQ2ZdRd8oRmR1Kb0OxXTIWNuhJIX8wc8wZ5Xbtm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y4/onsmn; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y4/onsmn" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-3810c5d691bso4121059a91.1 for ; Wed, 15 Jul 2026 03:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784110263; x=1784715063; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gBNL9jZr+BjLwoEnPOS4tAnKcJKl6B6YE59NAlSHzw0=; b=Y4/onsmnAskXenXpCeVxbGxc+TXpe3pIuBFrpYX7Y1kB0MGKCONi3s/d+yeh+GEqyF LndMf2Bv+Pq5oN2MWyeKdvsY+XHU0RZXVkLX1O4AGqPxLQH62i+qDED05lVFxmm9ftlH BZzWszxQgy3fPeUNdrO8PLoTmQzMxju49NZkUL+yVTrA3mQM7dZTBt6tsGLUPHjhvUyo QnxCOTQ1MEkBNJ3Nza5qsxlyUhUBRyGli5lbZIx7FyhXDw7fEeGzbwizZqkr6TygtBBI DKd351njxAWtFmm599MYrg3fVsNymSyhqaju7xlYpAlvSVjrPW3OtE2nvmo/I7e5ZMKj jLSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784110263; x=1784715063; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=gBNL9jZr+BjLwoEnPOS4tAnKcJKl6B6YE59NAlSHzw0=; b=BXsweSRCMwRc6Mer+m9VTOUYw/kOEQ87QsMGsIL/vZ6/yl/F+nAb+CNHUdb6tYYqJy FXrVdSfnDKWG8ItLvogdML4O8ybkzRL3MgE6CepwEapdnSEHTQEeFxjwwpRfvErRW85z h5DbHi4GxUgFoCCXGGb9TvbcriBQ9c1JY6SGvq9KWJIiPYNTC5S1l64ue2bAoO5ePkBp zOSPMhchh1NqjaMq98qFSanH4Reb4SZb0oxRqcKdE7N5s6J6nOHULWtNYPGGQc3IuEZg kF1FSp95bggAAtXQ3h5hKgbdyVNUJ4fVG8YoDOOSwykGQ7aK2Q7d8hj28NmIL6tSlzrp j26g== X-Forwarded-Encrypted: i=1; AHgh+RqrZFy/zovn30+FulemWV4LwDf77puWgLvyd5fqWWiYf4gRW08ydzTRLMGoYxNfh7/hU+JhLi7VHnHLH4c=@vger.kernel.org X-Gm-Message-State: AOJu0YwXqdAobZ66JcgeWo+SZerb1Fl/UTVKkk5QGtIWY/2OH6jzuLCs rbA50J7HmLnEKeCzGIelL3Aa/GY/Ld4S/XtfI2s6UdKOwTtkRU+bTjMb X-Gm-Gg: AfdE7ckRXA6Hh+0ecmZImjRwC9MsHcFjH+utY2KZBGFasBA95EnQidK8oGNzaF5Ohuv OOw8KLoB7twj9lFI4GfZm91g2CYrX7A7PPbVU3AW6dwH2twcZy/GNf5kWYUwz5yvFj++RsHcvCS 15bjY+T9+5wSgbnyNOiFWGoZ/i+NFOPywEJMmrjIIM1gGm41b4CY7JM+0nrijkUK8hAVBTr8zwW 0hxwvH4NxNYTt36F0oAO8rQBtEkLL/S0oqwk5qgeAaQl03GoHs1Bjv49omK9W+xOKj12Yp9IU2Y 1pihXDaqDVl63n8bw12vNwKS5TnTregNJxxCcO2pnlLE8g+CAxlD/wo+cLg6g8A+dUe4TCY+ryg /WEhq2FKUfIfR70QEcHx6of7xUcIufyXgxyhFlicv3U6oQ+sTm1btDTgUViv2ubpSon9js95awq AGXopExlcJarRbu6SRXhTpPCLXCCaQT9cnfd55r6fwwhF1Mht+z9w= X-Received: by 2002:a17:90b:55c5:b0:381:77cd:38d1 with SMTP id 98e67ed59e1d1-38e1ae2679fmr5266216a91.10.1784110263189; Wed, 15 Jul 2026 03:11:03 -0700 (PDT) Received: from primary ([223.181.23.34]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3119c2a7bb5sm62079757eec.25.2026.07.15.03.10.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 03:11:02 -0700 (PDT) From: Vidhu Sarwal To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Per-Daniel Olsson , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, Vidhu Sarwal Subject: [PATCH 2/3] iio: light: opt4060: Fix pointer type passed to div_u64_rem() Date: Wed, 15 Jul 2026 06:45:43 +0530 Message-ID: <20260715011544.281148-3-vidhu.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260715011544.281148-1-vidhu.linux@gmail.com> References: <20260715011544.281148-1-vidhu.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit div_u64_rem() expects a u32 * for the remainder, but opt4060_read_ev_period() passes val2, which is declared as an int *. While this has no functional impact, it triggers a pointer type mismatch. There is no behavioural change because int and u32 have the same size and representation on all supported architectures, and the remainder is always less than MICRO, so it fits within the positive range of int. Use a local u32 to receive the remainder before assigning it to *val2. Fixes: 0c6db4506ad0 ("iio: light: Add support for TI OPT4060 color sensor") Signed-off-by: Vidhu Sarwal --- drivers/iio/light/opt4060.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/light/opt4060.c b/drivers/iio/light/opt4060.c index cf6f69e5be35..e3aabfb14d5d 100644 --- a/drivers/iio/light/opt4060.c +++ b/drivers/iio/light/opt4060.c @@ -713,6 +713,7 @@ static ssize_t opt4060_read_ev_period(struct opt4060_chip *chip, int *val, { int ret, pers, fault_count, int_time; u64 uval; + u32 rem; int_time = opt4060_int_time_reg[chip->int_time][0]; @@ -738,7 +739,8 @@ static ssize_t opt4060_read_ev_period(struct opt4060_chip *chip, int *val, } uval = mul_u32_u32(int_time, pers); - *val = div_u64_rem(uval, MICRO, val2); + *val = div_u64_rem(uval, MICRO, &rem); + *val2 = rem; return IIO_VAL_INT_PLUS_MICRO; } -- 2.53.0