From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BACB4314AC for ; Wed, 15 Jul 2026 09:55:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109357; cv=none; b=JzsPzJ41zEXQycyugRSN5HZvNW+g3auwV2xM4HXBTlJz6rqpgbYu1TtCz3/c7MGfyEN7ns7JgSR/ny2w4Gcqnk4jrBb1ETh6O/AbwZ3YM/yrBe3mHMb2PbLYkGmocsgZXIDvEe8YUTiG/2NvfS4kGgBKjiNjcepzBmAhxH3OPBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109357; c=relaxed/simple; bh=k83hZbTKuOl//PgUx5fOIdMW+RR7uZ50uJTt+Avj9Nw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k2NWG368qd31bqUV/6rNz/KFSmM4AdYXVvHOtAM70NhjxN2lfqo8Ret2T4nCFh3yhYsM7ZYlxzTpG5+rbOrKTDQMQBowxLdssUbQoe0G6VMNQ1NC4EhtDQSGXShCW/7KIrKevw+uvG3LFFLxGolh8TKPxMPmQZHOIkEhAmFO3CA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X4uJBUmN; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X4uJBUmN" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ceaf8a1265so44214565ad.2 for ; Wed, 15 Jul 2026 02:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784109355; x=1784714155; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7BpJzZu2JI6YrdHbblIuBNywzFxSYtVh1mg+KZtTDf0=; b=X4uJBUmNMXD3iuHG0quhAYPzFJCDozpxfH+PNt5XCLxgIRAknzY03QX9jV2hBjMr68 gH7JpdAxU9DqNIgwPQBr3GcTQRPtLkc9gvaudwgwZrurm35vI9dBNW2POKWEY4fRuit7 mhMSYTJvzYaRwEGCb2gpdfTOGUayZQET42SDUZ8srTo+hp/ExM6aeNHgrxsK2qYykk5t 4tIRPNuxALtu5sY0Mrce2Ab1O1zoDH0LKd1JqVoN4GfBG+cLfp/EOK6EfnATvVfGwFeR BN0oC9c+LXmTc78zL9kckl7jqH+6rK+R85sedN+Y1JC+KzITVv2MuoY7KD9JpH1aswkZ cctA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784109355; x=1784714155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=7BpJzZu2JI6YrdHbblIuBNywzFxSYtVh1mg+KZtTDf0=; b=EtSGaJzmkIJHs+osMHzxgJgxwPpiudXWRUfnYB0woXFxJmPMQyaSfT08HTLJoA9iqu j15rCb65ThmK5qKJOe97WKPk8s7oL6GLxkXFuVYg50FQwbmfIRZ00oRIXs44NlijOE1f GQf11Evgf6NgZ95XOeB0dwp96AWHGrPClQddypUk3+wHo6d1ywS5cH7xUdIKAh66fVM3 1wabnFjFpq1JpeWa4uFnhQ/KuNTmlYmFvXy9xpfBzKG2kI27c0Z/5fBRf7GkZwNsnC9K 5MDtreKMhKwFZtuQFmdLH7ePWtIpMHRT7gEx/ixOzqDH3+ziegR3puxXrNkRGqJUaIN+ 8y2A== X-Forwarded-Encrypted: i=1; AHgh+RpxcuW03Bgp2waIIlbqFN8skUtca5MurbJjQ0RP0Q/U3sUqE12tzObJAAvZbV0KP4xE36uTyVh8vMVeAA0=@vger.kernel.org X-Gm-Message-State: AOJu0YzChaQ4ulEelBtrVyXGYYHejuCFS9ZH6Zsi7PSLFVaLvZAa8ILt Oi0JNxrqKZSttqwIch6XI+bOP4xRWhLeDNA4loPiO2xPYu9Blp+k6Mjt X-Gm-Gg: AfdE7cnPmdwCi82whIame+WeYNXb8773VPjpSZU2t0tkVjU2W70Xr5pa7CcW5OKTnok Vl2rb1ryoAPn0dlF5O7vzOW2emv2e0BSudhBRazjadL/Az+o2tLar4ukfCr0dGZjdbQ54eBgsIE +54Kydpk+zGuS35rdD5wx+zuc+x0tEO39YIjv/QSMlk1fhfpKW8rJ6UCdJOBOr2p/KDshd0ptPC X4CUrXqWlOUpeCuF6DrRYPeo42LxEezUuwS9H1GZIwyGApuE3s0uAMAeY3Ac0vNtJdjKHVH2lY2 I+ZZLrx/Re3UeeSfNjz4k6idAVHTuB2RZvb7Ik43gayF88Ro7MtSPgrTu7pk4rKkab4XIynh4aG 9qN2szkOjQxFm37AGGQ5yQWaLZH8lEpQGKqfw1O2YBEdTx3RrWVJMgkSoSXFTvAL2D0PurfPPqj 9vfFbGc++PGv5CjqelCoG33/G8eOnqqvBgSCl2Tdx/Exuyl9I= X-Received: by 2002:a05:6a20:3d8b:b0:3b4:931c:3c7c with SMTP id adf61e73a8af0-3c357553dfcmr7448713637.44.1784109354620; Wed, 15 Jul 2026 02:55:54 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm11628908a12.22.2026.07.15.02.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:55:54 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , Charles Keepax , Kuninori Morimoto , Chen Ni , Marcus Cooper , Bjorn Helgaas , Danilo Krummrich , u.kleine-koenig@baylibre.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 1/6] ASoC: sunxi: sun4i-codec: Use dev_err_probe() for probe error handling Date: Wed, 15 Jul 2026 16:55:20 +0700 Message-ID: <20260715095525.40668-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715095525.40668-1-phucduc.bui@gmail.com> References: <20260715095525.40668-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Use dev_err_probe() for probe error handling to simplify the error paths and handle -EPROBE_DEFER correctly. Signed-off-by: bui duc phuc --- sound/soc/sunxi/sun4i-codec.c | 70 ++++++++++++++--------------------- 1 file changed, 28 insertions(+), 42 deletions(-) diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c index f4e22af594fa..05308df3ae5b 100644 --- a/sound/soc/sunxi/sun4i-codec.c +++ b/sound/soc/sunxi/sun4i-codec.c @@ -2316,67 +2316,54 @@ static int sun4i_codec_probe(struct platform_device *pdev) scodec->regmap = devm_regmap_init_mmio(&pdev->dev, base, quirks->regmap_config); - if (IS_ERR(scodec->regmap)) { - dev_err(&pdev->dev, "Failed to create our regmap\n"); - return PTR_ERR(scodec->regmap); - } + if (IS_ERR(scodec->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->regmap), + "Failed to create our regmap\n"); /* Get the clocks from the DT */ scodec->clk_apb = devm_clk_get_enabled(&pdev->dev, "apb"); - if (IS_ERR(scodec->clk_apb)) { - dev_err(&pdev->dev, "Failed to get the APB clock\n"); - return PTR_ERR(scodec->clk_apb); - } + if (IS_ERR(scodec->clk_apb)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->clk_apb), + "Failed to get the APB clock\n"); scodec->clk_module = devm_clk_get(&pdev->dev, "codec"); - if (IS_ERR(scodec->clk_module)) { - dev_err(&pdev->dev, "Failed to get the module clock\n"); - return PTR_ERR(scodec->clk_module); - } + if (IS_ERR(scodec->clk_module)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->clk_module), + "Failed to get the module clock\n"); if (quirks->has_reset) { scodec->rst = devm_reset_control_get_exclusive_deasserted(&pdev->dev, NULL); - if (IS_ERR(scodec->rst)) { - dev_err(&pdev->dev, "Failed to get reset control\n"); - return PTR_ERR(scodec->rst); - } + if (IS_ERR(scodec->rst)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->rst), + "Failed to get reset control\n"); } scodec->gpio_pa = devm_gpiod_get_optional(&pdev->dev, "allwinner,pa", GPIOD_OUT_LOW); - if (IS_ERR(scodec->gpio_pa)) { - ret = PTR_ERR(scodec->gpio_pa); - dev_err_probe(&pdev->dev, ret, "Failed to get pa gpio\n"); - return ret; - } + if (IS_ERR(scodec->gpio_pa)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->gpio_pa), + "Failed to get pa gpio\n"); + scodec->gpio_hp = devm_gpiod_get_optional(&pdev->dev, "hp-det", GPIOD_IN); - if (IS_ERR(scodec->gpio_hp)) { - ret = PTR_ERR(scodec->gpio_hp); - dev_err_probe(&pdev->dev, ret, "Failed to get hp-det gpio\n"); - return ret; - } + if (IS_ERR(scodec->gpio_hp)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->gpio_hp), + "Failed to get hp-det gpio\n"); /* reg_field setup */ scodec->reg_adc_fifoc = devm_regmap_field_alloc(&pdev->dev, scodec->regmap, quirks->reg_adc_fifoc); - if (IS_ERR(scodec->reg_adc_fifoc)) { - ret = PTR_ERR(scodec->reg_adc_fifoc); - dev_err(&pdev->dev, "Failed to create regmap fields: %d\n", - ret); - return ret; - } + if (IS_ERR(scodec->reg_adc_fifoc)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->reg_adc_fifoc), + "Failed to create regmap fields\n"); scodec->reg_dac_fifoc = devm_regmap_field_alloc(&pdev->dev, scodec->regmap, quirks->reg_dac_fifoc); - if (IS_ERR(scodec->reg_dac_fifoc)) { - ret = PTR_ERR(scodec->reg_dac_fifoc); - dev_err(&pdev->dev, "Failed to create regmap fields: %d\n", - ret); - return ret; - } + if (IS_ERR(scodec->reg_dac_fifoc)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->reg_dac_fifoc), + "Failed to create regmap fields\n"); /* DMA configuration for TX FIFO */ scodec->playback_dma_data.addr = res->start + quirks->reg_dac_txdata; @@ -2422,10 +2409,9 @@ static int sun4i_codec_probe(struct platform_device *pdev) snd_soc_card_set_drvdata(card, scodec); ret = snd_soc_register_card(card); - if (ret) { - dev_err_probe(&pdev->dev, ret, "Failed to register our card\n"); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to register our card\n"); return 0; } -- 2.43.0