From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B44333C552B for ; Wed, 15 Jul 2026 08:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784103002; cv=none; b=EvIeb+B7PSBsPO/OXMAKCwYpPZY60XSggFBXD9Mf9eqKsTHJq5OUsZPE6o1d93thkWIa7yqk683sijQgIu46GCCA8mvLCbB5VcNrb4yvlJz/3X3UtBHc+6WlhQNTrl7cIryFW+wHh1HbvS3IaltxkDD9p/y7VRXFDpAjgRKFbCo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784103002; c=relaxed/simple; bh=hPRNYd/wHYOBqfZ0XEK7i21Zam/Mk++bMOTaJccVRsQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mcs+3C82uDKeElAyihksC2PFlKdvbUHiF4JORz7OoEK9cI/Q0kJj5FZEdIsDkB1tLsvtxUqDBlwpF2VfjQfM4uqNHweiwXhQyfTwKjM+Ev8TSlrWFDgheWxDvPOVv6FstwTfcbMc7WE2/oE8T4aRbuL3VYVzmZHFX0yEVrXjE/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OnAdGbDO; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OnAdGbDO" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493f45e20cdso30460355e9.2 for ; Wed, 15 Jul 2026 01:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784102999; x=1784707799; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=VXTUbhc4/2+6BBrpwPWy5jO4ogbjXWG+tcivgR76rdU=; b=OnAdGbDO4iO8WiHWdXcpwgUmHS5kAtVfS3EClnKBGYchhJ7TCTQ6xD0dreqk3ZpN7J 3NM+M5Faz06tYIIgUoYtVdAsnsPmK2EukdhWixTkN5Z9lXi45bxqqir16FRIhcVsCaEU QkiQBi2rJtNyndyK7BvqTDCydBDem9KLebm/cnPEj1fmjT5ZykKEw0Du/FezZIBW/6BQ JVdNGFmQAZezmUgrkUUVLW0x+F6COYmWrnf28OPd08PeTPgo1kkt6EtLuV4HzLE9AJP9 RRFZy2PyW1hEIA52JnFd3TEt1Jh1KRkt1QG4vnWwFHqcOZwxYWQZ2k15vHGSaxe4phwx 9HDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784102999; x=1784707799; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VXTUbhc4/2+6BBrpwPWy5jO4ogbjXWG+tcivgR76rdU=; b=MeqJbStnZX09tMxkB8D9F0GZHZPZsAKRuHJE7J+obORZ+t9Wr2dYvngNSmMFWAEZo8 cXumWLibNiBMpCSepaHlyVapuzIqHtGtbSep8msg2XmN5cFMZ2p4cIGJpNpBDZ0Bp4r3 /kHivHeXQ3Gc0aXfApiTLmdryzJbjrJ38lBL1bRBJjiR671v88vpJ8ogtfa8cfLbOqfX El2Z0f9D5gcjX2HgptDlAOhblGvSpifC8vb7fzRt9Nb4CfkDa90xH46pgowqDHCSYyqP 1lieqykNDu1Iz8qrtkHMLjK3++BG/YPZNs0j8iyKfJZo3dCvnUZccEHRQtPWSast047g YHOQ== X-Forwarded-Encrypted: i=1; AHgh+Rqa8/h6bzomC++ZiAvJqXgOMYE9SGZzvPhxfpc3RQ+4BuFBhXVHNL7ZLHp1OEUVzDqwf1VgwUnTIYHUlR0=@vger.kernel.org X-Gm-Message-State: AOJu0YzvfsGtsZc7pIehW8Ip73CV/F+4FfcWpRqqqaTqJfMMWjBD24Ct 7M/0tSSLPYlwyD+pV4IS7nJW4lVmNSFnCDgGnyVJHjnacp6sq5vOIXhd X-Gm-Gg: AfdE7cnh5Z1cOcSVgr0gBY/QqndHi0qBGIEpdBBv/LPToLV1EmpzYYE4+KDddUsWLq1 dZYoL0LTp32cgrc2uUxOY682JBYebm4n4nOdttO8werGdqg41pZAvKPpOmZasxL7y3JCdWVofxt 4CzYwSaxnjqNlIRKAS4QuKnmZlnf+T4a7Yzg649HSopwBUNLyDwAa4akGrTg8kGHGNLMQFAkLgp rwh2ZWzUH8OY/kfKeMrm2OgXs8i/TlsnNiKSI4/K6swp/fqxhamPIwjhb8uheHidLUmF3tR05xn TYJEPN0H2MHImayyaGoQTjbfdsp/7PcKXp1ZgTVdaIOM21C80xUMCRCmAYjIHy7dVVBP16HFOgA H27Hs6C+kvMV/86NEL6IO8kjzCr4GZow6YqFk58M9/hImMfl9BrmqF1zuE32liGFj9FnkK1uE8i zKPhb7VnfaTXSYcO5SDKEtoVK/ZYhrTAwd/CNG73wUycRIkJINIYVjFjyI9oGeWKgaYDwSc5rJV vDAn9xKu0GaNpouL8l3fLuW9CGW5sqDTQcqzlPf6gaNZkRFKvOagQg0sqnAkjNiMVBE9ry8BoMB TxUgoho/ro8f99Ye0bw7eZAjVlMuBQ93r4qDk+ExzyVmR1ywnM3yvl8GtkGi3BuKsCG+SamUeSm p3Q1i2A7ir5T/+pLX26wH7PE= X-Received: by 2002:a05:600c:4f90:b0:493:af56:8e64 with SMTP id 5b1f17b1804b1-49538a1755cmr57000575e9.32.1784102998757; Wed, 15 Jul 2026 01:09:58 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4953f643acdsm916755e9.3.2026.07.15.01.09.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 01:09:58 -0700 (PDT) Date: Wed, 15 Jul 2026 10:09:58 +0200 From: Joshua Crofts To: Andy Shevchenko Cc: Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] iio: light: opt3001: split opt3001_get_processed() logic Message-ID: <20260715100958.000046d9@gmail.com> In-Reply-To: References: <20260714-opt3001-unwind-cleanup-v4-1-7ebea805bfac@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 14 Jul 2026 20:04:10 +0300 Andy Shevchenko wrote: > > - if (ret < 0) { > > + if (ret < 0) > > At some point consider dropping ' < 0' pieces for the i2c_smbus_write_*() cases. > Read cases are different, of course. > > > dev_err(dev, "failed to write register %02x\n", > > OPT3001_CONFIGURATION); > > + > > + return ret; > Even after an 8-part patch set, this driver still needs cleaning up! -- Kind regards CJD