From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 183783AE6F4 for ; Wed, 15 Jul 2026 16:11:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784131881; cv=none; b=BTdE2MKIjE5bXOzpC338xmUdXc998oNhJPQtOvKovMMJ6j3M+nq3vJObeqzd+ocahjSInPfmC0IGRDXrIDMGwJo+f+U+ddVB9nxBV0t6TKkZBotVtVUO+cNTchJH2FQeL7BP/sQotMH+XNLMeYYdY4fZWtakuZKuF573Lf1eeUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784131881; c=relaxed/simple; bh=CgCDTCWRSJkLOMyNqmIyUWLC21lERecNvLqhW68S8k8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kKso8odZSfD4dDyYdqrs9Gnaf6U+DH2EL37AftXOiXClsc297KhN/FuDZU1Ms5SBajXhxtzXUmxi/ruhG+wF/cFkFhBHxmc5ignFwgDWBsMSho9yq3EuRUJj3zIfcZGWsBnyqwaYMPlCwHKCW04cDwmSHSiQflBwdtUURRfrN9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Cj+rKdVC; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=GfwkAb8z; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Cj+rKdVC"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="GfwkAb8z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784131879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u018p3vyJrvV+UM2lycGYWrJgbwr8WQB52QeOVOHYUg=; b=Cj+rKdVCdt8S8mBSQLEdUpqV+Un3E6e4v5glE+RHesTwIhrEUgd1ZIiY6cxJA41q8TJ6Tw OqZTjkOQhXHyLeyUdlqRNH0Zyx+TUOmULIkjyqcbHipDO3+NpakxEFDRZAMQHvcpsSY27s SvasW25mOIcuLeWJt9Zp6GDebTpWDVs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-vlB8WneYPga6zaPsl-ZfzA-1; Wed, 15 Jul 2026 12:11:17 -0400 X-MC-Unique: vlB8WneYPga6zaPsl-ZfzA-1 X-Mimecast-MFC-AGG-ID: vlB8WneYPga6zaPsl-ZfzA_1784131876 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-493ce08a6b4so50906475e9.1 for ; Wed, 15 Jul 2026 09:11:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784131876; x=1784736676; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=u018p3vyJrvV+UM2lycGYWrJgbwr8WQB52QeOVOHYUg=; b=GfwkAb8zs3O1zW+Z1SLtQZgEYt/4ozs7FVOtlT4DHWDkQD0EwgWRFVeBhSAv5wtzLm mSylsG0/gZNoIIRtLiry9TYwT+GmF8P4y30/63wz/lxSDjf9ZbwVEb+jKC3ADRPf4edK yiSFQKNAXNWkHeQ8yy3Oybf6q57acng4foxFQ7B14qCDUJUzGCPXJIp+hiB+MxWbGWmR /1C3tvezga/xp4SbpZVBfzoOiOa7SCjr2/XNgjku6u6FeziSdp1UWZXwj1ANwVaqZw9d LtLngsnem7kMs08ZbuEbUt/Kem/oov3mJKUz9r0TBoYX0PtVPSQxKGNDxakMr6ftL8hk smkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784131876; x=1784736676; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=u018p3vyJrvV+UM2lycGYWrJgbwr8WQB52QeOVOHYUg=; b=i0G8Y+si7I1ATTcOmzkEEUQZdyo1ccYbKMm+L8nVuZIttG7FhRS+teOaPQedygqRvR bIXol8GJcBqj/TYSo2yVYbEqXfWr1Dn/2B0YZiyH1QnRS+RBblG+43Ew4z0aETY2rUO8 lMY0MtJNewGlqlulQ5LEg9VylJqN6Hm1yUf/8vikT8GfC5MD3UZllfIjhaU0W9OpG3h1 GzKvCnrstFboi76isZqgfnWUzcXJaCv6HyKRNNTs6laqtMZ7hv7DTbGO55LwHxP3kZMZ cpdcod929PE2wU87Flntcp4YFgWVWXavY9P/BziO5Oa+s+S7Z2HaGRKIZx7nbO3Jx7uu +RAQ== X-Forwarded-Encrypted: i=1; AHgh+RpLCZUY3dHscFDJtMeCWgVhFcEbeEAGu93Ubg5L1suPY+kyW37vrughl0JjVlcyVpLfbw6u3MCmFv2g0eY=@vger.kernel.org X-Gm-Message-State: AOJu0YwA/8vQxZtk/DkZbgKOI1B6gMcnRI6HQTP4YMV+fsDy1xRhpO5Z HTV3ya3O6y+U/H2oBHpKY1Cfap2y/9J+yAriru26Q6ZjZ8eW7uYgCqZ272kOnairLbVJLGX/kyK kOzOjb7+BOazKJKg2bF3kqZf5HgJr0sZAwSB8PIhS2r78scbs9Wjv7EFypdDNf0CX1g== X-Gm-Gg: AfdE7cmByY4NhtWDVWMvr+VYDtFTmftpCloCUOjIWghVu3is1soL05Pyt3EzKHG5GcU SIUpQR2mO4qJlYDaGVPLijMim0pHDj+aDCuuY1XG9VJ6TeK5EJ4gaSNJcRhKG2etC1U3O3SLLZn AUDiVr8XqJ0EKF5x+P2bLpfOPA8jarH1It5vdLkskbPgXdfRMfGWwkY+Shc4Fcjlu0RTOgbPAVJ H2rFDatUH0UyjEvat858zhwl6vzAwskw9FIhJyVXlqbYlzPkK+kYK0lg4D5mUgutmvvKXlqLJHd Sa/Mtg5obPCqXHH4zhiX8wrGpr87p3LvCvwXUhRr9sY/m3kho0yovuz9baNRIWWWpv2ixco3CDK TJrcHtt/7ogY+tOze4fnhq5FRN8axNL5wrUM= X-Received: by 2002:a05:600c:6207:b0:493:e504:cbef with SMTP id 5b1f17b1804b1-495389731b5mr84415785e9.0.1784131876344; Wed, 15 Jul 2026 09:11:16 -0700 (PDT) X-Received: by 2002:a05:600c:6207:b0:493:e504:cbef with SMTP id 5b1f17b1804b1-495389731b5mr84415185e9.0.1784131875797; Wed, 15 Jul 2026 09:11:15 -0700 (PDT) Received: from redhat.com (IGLD-80-230-24-117.inter.net.il. [80.230.24.117]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4953c710facsm39394605e9.2.2026.07.15.09.11.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 09:11:15 -0700 (PDT) Date: Wed, 15 Jul 2026 12:11:12 -0400 From: "Michael S. Tsirkin" To: Hari Mishal Cc: Amit Shah , Arnd Bergmann , Greg Kroah-Hartman , Gerd Hoffmann , Jason Wang , David Hildenbrand , Henrik Rydberg , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH 2/4] virtio_input: validate device-reported multitouch slot count Message-ID: <20260715120911-mutt-send-email-mst@kernel.org> References: <20260715142337.22811-1-harimishal1@gmail.com> <20260715142337.22811-3-harimishal1@gmail.com> <20260715115018-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Jul 15, 2026 at 06:07:56PM +0200, Hari Mishal wrote: > On Wed, Jul 15, 2026 at 5:50 PM Michael S. Tsirkin wrote: > > > > On Wed, Jul 15, 2026 at 04:22:41PM +0200, Hari Mishal wrote: > > > nslots is derived from the ABS_MT_SLOT maximum reported by the > > > virtio device. A device could report a bogus maximum (e.g. -1) > > > making nslots = 0, which input_mt_init_slots() does not reject; > > > it returns success without allocating any slot storage, silently > > > leaving the device registered as multitouch capable with no > > > backing state. > > > > So let's disable multitouch instead? > > > > So rather than failing the whole probe, just warn and clear > ABS_MT_SLOT from absbit in that case, so the rest of the device > still registers? I took my lead from input_mt_init_slots(), which > has its own internal cap and returns -EINVAL when the device > reports more than 1024 slots. > Shall I modify that case to get the same "warn and disable > multitouch" for consistency, or is a hard failure better there since > it's a different type of bad device data? I don't really know enough for sure but generally if the device can kinda work it's better than not working, and adding a capability to a device that driver can't use should generally just ignore the capability, not fail probe. > Happy to fix it either way! Just want to confirm before sending V2. > > Cheers, > Hari