From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CD673B27F4 for ; Wed, 15 Jul 2026 11:40:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115658; cv=none; b=CN6GWu1K+jFUiaXmHq/S1RH23bW86tZpiIFALKW+0sw/AdhQ6YxUpJw1CRLb3P8rQvO4qwTtVgV1BBJGahupyhBRKilanq/9z899X6K+2iw47cYsjIoN8pI89rdU5mpChPR2GMJdOAck3Sygg7k9MtuDHim1egJHtqaidZ0OJ50= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784115658; c=relaxed/simple; bh=QKZH5trVhSKWAXif72FqybKEWVn65IqnVfhoul/Jomk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Z6RH/3be/vO1QzKNFKlkaEp95jDh5ZTHJu/PPaxnanXgCI6Ozap92/n59uSWJATkSQxKy+N4Iua25wx5nWXMsDQHyboy0WU9bz92doGrRhIVuJGOx+oovR1eAb/pynBZz8csQFiO8AXmeK1qcQKZ5DaZzCSlgEWpxh8rntF/1tI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mKn5s5q2; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mKn5s5q2" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493f2e39e81so21239225e9.2 for ; Wed, 15 Jul 2026 04:40:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784115655; x=1784720455; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=bte0VZC2iVWnsevsBDUvhXv3VfECX+p8ZU2vUJS74DY=; b=mKn5s5q2zouKj2xuwLkgpINMdbuPgyTbcIgFAaacOB38WtS5/nlLR0ouPJO7gMexMn AtH3caYmYvCCaMDIPuKqZxcZnjfnoVcOAFrJIoSOmws1pKRh9/wfJ+xF0lt0LSoxi6CB DyK7lsQljE8ZVk/E9fM9pHcqdpc1qOqktvcuz5jS5Q4yBvyhIc4TrHk7csJyI1y1cUGA o9q8vI4q1wKW3sotC16GHk28URGk35RlNvVB2T6RyAj6sG4jE97elqWkfBRnzMoKlyTz /+zCER6RyYquWP7ts07K5Zqepc9rBZOLTZW1ZmaKyG7tlJuuFv2bj/27o1FJmr7hzqK5 UDVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784115655; x=1784720455; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bte0VZC2iVWnsevsBDUvhXv3VfECX+p8ZU2vUJS74DY=; b=UEX97PjytK8tIrJqfPyEDYvx1o5sh3//n49n9aY5irBOSRfmp8007+4O48ieL+epUi ZfPRFxBP4pVai32DY3qGwrm3ngZzC59kZPStit/auIFN1EdfNB3gXa8ouAKUjlbGA42k as33k/mXI2levpXHy2/0faCO/AqEuLIo1SXOuPi1e/ucZiVeYzhWgUPEuSs6OaFJtrMy KhNpiTSJ0UesajzGTsBtY37yY0sb/Tu5ehrNsNTfPTvpPkY3ck2VcSPbYJb6AwA61HSm 47aKygdoOY6VPYmHTcE57aeyaZu5HONieV8szbSn0EyuUQ2YYXAWov2Ufws05tmYEWwt NsvA== X-Forwarded-Encrypted: i=1; AHgh+RpVJEBwZKtKxSE8n4kKWBXNiJn24tbnAknHcH/7eSa0VnN44pa2NAKtlDI/AMiq4b7d9s1xkO7mQ+CXSAI=@vger.kernel.org X-Gm-Message-State: AOJu0YyJJuS4hqkC1LnU1q/v5HzGYUZWQBXNrKW/DWcaiaWYTHrD/+rP IDeDjswCk69Tk1/FRGsR+tW1q4sHDpts4VbS/OxtauG7o/SjkVVTRmhd X-Gm-Gg: AfdE7ckAMpIO/JoMBUzPl0rgMPmKVILQKEnW+r0VIE/HTrzbP6Mrz2A50BWsqLBrzOf j94G4mti3E2qBG4QMbwLy2EqCFfqws6Pcxj8zcxTjNchSVcerYc7o4xuAqfL6TkirXpaL/ilP8A rhtiw2q5AEd5a+iukvCpZRvs1lkXGoNlacSZsunJvBXWPi0qyADFDEGWayzadl5SC+VI84pPBpz P4vtaauFRqqsItT7DODzXF6oJNR8Phg+V83CmIq5ARbfm2wqNBN+hHWOBekHGSwPEFF7neCsE59 5Y0c/RHhTQqDOx9Dc/+9zm9zie7l2b8Zaf/+w22OSqUd6/w6grrr580sUEfM/u1BEENW45uHLdK /47mV6iyQxcwMzbCh3KHrXBuN1+V7BrJJ8OZXEOcQs+ZxqjlBKqz7Ong9qauesJ19jhV5go+jw2 0YmUH6bzkuVHAOPDjxgoH+9uW0VT/kYzw5YdtsAIXGftWuLVM53irfHZO9RHTEM3GAKvzzhy7oh iZP0E2HzJpnZ3lxz1ey+mGwKHSA0U8Q3PcGrL2vCte/+RaszjvU64hKamZLSLezqHVO14Uod43G EAj8RmAR4D24A5Rd3TEUozBSJtTcHZNwjV+Ig7bEbDIxNvpB3zWl0mYACUqBj6f6B/2yMnAt1in 8mL8wDq/S3lHugJTb9eW2ZKLU+0G1Ln0OdQ== X-Received: by 2002:a05:600c:524c:b0:493:e890:9e0b with SMTP id 5b1f17b1804b1-4953c27e9c3mr28946715e9.26.1784115655256; Wed, 15 Jul 2026 04:40:55 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49508725c0bsm149543755e9.2.2026.07.15.04.40.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 04:40:55 -0700 (PDT) Date: Wed, 15 Jul 2026 13:40:53 +0200 From: Joshua Crofts To: Esben Haabendal Cc: "Jonathan Cameron" , "Lars-Peter Clausen" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Martin Kepplinger" , "Sean Nyekjaer" , "David Lechner" , Nuno =?ISO-8859-1?Q?S=E1?= , "Andy Shevchenko" , "Martin Kepplinger" , , , Subject: Re: [PATCH 2/2] iio: accel: mma8452: Allow open drain interrupt pin configuration Message-ID: <20260715134053.000012d4@gmail.com> In-Reply-To: <87pl0oo5iq.fsf@geanix.com> References: <20260715-mma8452-open-drain-v1-0-b1dd2a440c60@geanix.com> <20260715-mma8452-open-drain-v1-2-b1dd2a440c60@geanix.com> <20260715104542.0000433d@gmail.com> <87pl0oo5iq.fsf@geanix.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 15 Jul 2026 13:29:17 +0200 Esben Haabendal wrote: ... > >> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > >> index 7d683686dd9d..a20c02ce0b9c 100644 > >> --- a/drivers/iio/accel/mma8452.c > >> +++ b/drivers/iio/accel/mma8452.c > >> @@ -81,6 +81,8 @@ > >> #define MMA8452_CTRL_REG2_RST BIT(6) > >> #define MMA8452_CTRL_REG2_MODS_SHIFT 3 > >> #define MMA8452_CTRL_REG2_MODS_MASK 0x1b > >> +#define MMA8452_CTRL_REG3 0x2c > >> +#define MMA8452_CTRL_REG3_PP_OD BIT(0) > > > > I know that the defines are completely incorrectly aligned, but please > > ensure that at least all the defines in this block are aligned. > > > > Also, consider sending a patch which aligns all the other defines. > > How are they incorrectly aligned? > The all look perfectly fine here (visual tabs space set to 8). > Should I convert all the tabs used for alignment to spaces? > > AFAICS, I have added the defines with same alignment as the other > defines in that block. I believe the misalignment is only a visual > artifact caused by the diff format. Ah, I meant it as currently the defines look like this: #define MMA8452_WHO_AM_I 0x0d #define MMA8452_DATA_CFG 0x0e #define MMA8452_DATA_CFG_FS_MASK GENMASK(1, 0) #define MMA8452_DATA_CFG_FS_2G 0 but instead should look like this: #define MMA8452_WHO_AM_I 0x0d #define MMA8452_DATA_CFG 0x0e #define MMA8452_DATA_CFG_FS_MASK GENMASK(1, 0) #define MMA8452_DATA_CFG_FS_2G 0 I'm not sure if this was intentional or not in the original implementation. ... > After reordering member fields, I get this: > > struct mma8452_data { > struct i2c_client * client; /* 0 8 */ > struct mutex lock __attribute__((__aligned__(8))); /* 8 24 */ > struct iio_mount_matrix orientation; /* 32 72 */ > /* --- cacheline 1 boundary (64 bytes) was 40 bytes ago --- */ > const struct mma_chip_info * chip_info; /* 104 8 */ > struct regulator * vdd_reg; /* 112 8 */ > struct regulator * vddio_reg; /* 120 8 */ > /* --- cacheline 2 boundary (128 bytes) --- */ > struct { > __be16 channels[3]; /* 128 6 */ > > /* XXX 2 bytes hole, try to pack */ > > __s64 ts __attribute__((__aligned__(8))); /* 136 8 */ > } __attribute__((__aligned__(8))) buffer __attribute__((__aligned__(8))); /* 128 16 */ > > /* XXX last struct has 1 hole */ > > int sleep_val; /* 144 4 */ > u8 ctrl_reg1; /* 148 1 */ > u8 data_cfg; /* 149 1 */ > bool open_drain; /* 150 1 */ > > /* size: 152, cachelines: 3, members: 11 */ > /* padding: 1 */ > /* member types with holes: 1, total: 1 */ > /* forced alignments: 2 */ > /* last cacheline: 24 bytes */ > } __attribute__((__aligned__(8))); This looks great! -- Kind regards CJD