From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90A9A40EB9E for ; Wed, 15 Jul 2026 12:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784120392; cv=none; b=g7qoptvUtguhobxDVjNFCC8QxPTM6/5fUiNOeh14Vac1j9WWaUylhuRBIImIy8Xz4En4uSx6eQI2xFeXBROBhZiSiZyBrkBcjpVQ/fV9n4on84WVtaksgnZ/c/9CV9cO6ZRWawlVoVtmV+4pArZxdao2PC4ringMYDF0zd4uFmQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784120392; c=relaxed/simple; bh=nVcKHyPKz/W/FvJITsfshyPhXDm4WJXd509Pb5vj2ug=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=K0zsCjN+CkZFq7uyv+yHdhL8dTbFULdvEB3Zbsg5JqIFtqB6WAu5E88MZf5iQ1FDPzO8PQqYwPXEZogTRlKyXPA3NYaj0PrPEmlZ1UNFL4GiTmbz3ddvMZB3ZNvC/EYEZqyi561w9rZfYh/XFGesmwi46W7Ta9i7ktRIeocHveY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UHzw17oB; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UHzw17oB" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493ece78b0cso38343075e9.0 for ; Wed, 15 Jul 2026 05:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784120387; x=1784725187; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wXmSB/fZgpo1wJ9NHr1MARO2u1xBe0vIjZpMWVhRSx8=; b=UHzw17oBf+ApTp76TDefHfJ7TITrucW7MPXpUKVWDiXxtDURbhx0nj+umZKd+fZJE+ AdKHr8ZaVkvwkfmr8IuKHtFDaNYP0gS5G9U/pEFwOKspMWavpnhvP9BDhL+lz0fw2KMP z9qxY89xyZAh4QY56A1Um/brXtBM6K7LA8R+BdAINXQzlrR3y3XORRou6BapS0F1HRjO 5p3kSA59uBylieexkJGbIMs6ldC6Z7TcWzzxTZrrCzYK+W+Xia/R0HO4CM9yx4Bd+hy2 1DbAbkM9rDBOk4KjNQt3f1dpszBfZVptDwg9Zxw5nj3DqYdwKxVZcWmjFDHd7GKJKMUs /M1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784120387; x=1784725187; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wXmSB/fZgpo1wJ9NHr1MARO2u1xBe0vIjZpMWVhRSx8=; b=QwIfgkiM3s3070+VFZHciiz31o/MKaywd/4uaRl3NMjmaoF0OKdXNdm0lCTPaEYVm6 Kq0s8XJGZV3u6D7qtUu4UjgIu1jH3Eyg7DP1lPUBbW+lHhjM4Li9LffHdW+FJr1Za/lQ OWB3Zh8fgqjDz2LQ2LjFdnKUYgD/XnKTTr+w1LN8K3uiLU3V/6ISXBqrXNe0dOy4WrgV W0mwkMCF7uB953DsQm61/wq7Xp60QI6ugQEhL+bwwV/dsoGeWW1fqCDVVi8d3SLNCB1v E/prDhtRaCURa/ppMDQtRtD+HWXh8otoKUzRl50BAQ6hg0l6EvT9jxZ2sEIdVmYDDJtF lasA== X-Forwarded-Encrypted: i=1; AHgh+Ro8XYppGalyIZ/JDvYd4czPEPO7MzbilaiTLR9YTPOUKs0d7TVP4dfD88UrVfUdDVNE5OGUnwhbFHabumc=@vger.kernel.org X-Gm-Message-State: AOJu0YwMZgvoDutpLyD1tBddFSz6T/a7oNi2i2+34Jymj4RuF0SL37EC xYlgYmSvrWTQp5XXPfG+O/5SI5dcyptpuI7buKZdU71A9GHE/yfEpryN X-Gm-Gg: AfdE7clo2U1q1dYvu3fDDLKQTuh59JZxACdauLqzl92MpWiCwFqizMAAMptJ0zCZHRL IxrIx9Hx4Fn2Pa9ReJtmX06dZQ+Bnm1/kowjQHLJU2GgQ1f1ukLRvqmk9VeYCkT5cb9arIzpaQJ /M/JEe8YhS896f4ktujspjRCAg6QVEFOf0LR2Wynxqnwy35zpQNPnAT+iVj+9HaaPTZqycUk+p0 aBG0o0OeRAuovXNMIdKq/mM3uhA7ul7ZjTICmsebmxn0iEoDKOxEy0atFw5eLFQqhx0sjGsVUsV +372DytYt7IMxJRLUCI1nblZpt0Q6L9emskszMoqhEJkpeX0fG+YxHipGnpYH2AW4/0AnG1giJS XqaSdr+Ks8l20YxHjo0z6AQrBhKvORak4Yf4sZywZ+grVMiWj8Xsg8/pcwyOJ3Vap6Jx+tPHylA KJ6gQJ6CUvkoiO2EXjTEnBKJJ2+ac5YMUIO4e3VJI//mpB+X3y+p2tSIXM9qxqXDabyAfL9+f2b Zx1XjKwbxHw8gpr938lVYT79DHlt8rV+sI8JFoIuNAc0jONDNOK+9qsLu5+RgMndhQ0TorNWoMM VlhvUATXUYoylmDNQu5zpOhFAhVbfO8vCVXww9sqlhQ4LLJyUsf5Wpd1WEwIaBJS7JVUEUe6d5L bIZ+hCI8DnbOur379pbA9KzM= X-Received: by 2002:a05:600c:34c9:b0:492:3e44:214b with SMTP id 5b1f17b1804b1-4953905c59emr70009845e9.13.1784120386545; Wed, 15 Jul 2026 05:59:46 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4950a2f951asm157537975e9.14.2026.07.15.05.59.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 05:59:46 -0700 (PDT) Date: Wed, 15 Jul 2026 14:59:44 +0200 From: Joshua Crofts To: Esben Haabendal Cc: Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nikita Travkin , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] iio: light: ltr501: Power down chip if request irq fails Message-ID: <20260715145944.00001de5@gmail.com> In-Reply-To: <20260715-liteon-ltr329-v2-4-d18af55edab5@geanix.com> References: <20260715-liteon-ltr329-v2-0-d18af55edab5@geanix.com> <20260715-liteon-ltr329-v2-4-d18af55edab5@geanix.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 15 Jul 2026 14:27:26 +0200 Esben Haabendal wrote: > In case request irq failed, we were leaving the chip powered instead of devm_request_threaded_irq(), please mention functions and structs by their full name to prevent ambiguity. > powering it down again. + a very short explanation of what you did, 1 sentence > Signed-off-by: Esben Haabendal > --- > drivers/iio/light/ltr501.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c > index 379e57ac5f5b..9d4de798e5ab 100644 > --- a/drivers/iio/light/ltr501.c > +++ b/drivers/iio/light/ltr501.c > @@ -1571,7 +1571,7 @@ static int ltr501_probe(struct i2c_client *client) > if (ret) { > dev_err(&client->dev, "request irq (%d) failed\n", > client->irq); While you're at it, you can remove the dev_err() call as devm_request_threaded_irq already calls dev_err_probe on failure, creating duplicate messages. > - return ret; > + goto powerdown_on_error; > } > } else { > indio_dev->info = data->chip_info->info_no_irq; > -- Kind regards CJD