From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3F43420463 for ; Wed, 15 Jul 2026 13:02:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784120576; cv=none; b=gbWDBCRyMkLV41lArGUAfe4Wip6BQBlE3Xej7OM/LhQWS3ICRcYJktJeSd5bx6t7paxaTq+ecjDoeC9QUQ57TRXye9WJUcxe9PT6Rk5JRf6NPm8zq6JfXgoHT/kKbsbLrgH+qRTF/5ov1bzuAkfSAGy7S6wUwwn2JSIpivQuFlo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784120576; c=relaxed/simple; bh=N6LMn7MiHopKnkA5J0zJufKQOBomiCLsVyYHDoryQig=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Q2QA7DtdPNeHGsRGpxIT7IKpjKzyIOyvAyZhS37mnXNrDI6E1Bm8Hp5SqGMJaMBwYqUuW/UPohJ2axlZWDca9JTUZv93gO0qkRHf61ETZ/eMSUAgwYp6H/MDGCxjdQGgXhZdmUcwYfkAoUjUSr4K9fVUJ4dcgpOjXw242J7glYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h4Fd8oj/; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h4Fd8oj/" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-493c733f15aso48775795e9.0 for ; Wed, 15 Jul 2026 06:02:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784120573; x=1784725373; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QFKJnPmVhYGXGMLsUKcHXY8gMyHNPu+ws0DPBz7tk5w=; b=h4Fd8oj/vWS+9MYz3eaXTozRnMC0yVPuHYPZ+UeUNnnwtn20qA3RkNpXHi/UzZlH/P v9HxD+Pm2/s4UQCH1S2SeMkH+cXk/waW39rrjwu7EMQLJzEPm/JqDnox94yQf++mR9uY pX4DMgIqkjdTKSXYNkNyqyugBKOYMYwu8nmhsy1oLzxR5Yuu3KX/LoaWKIO2eTyjmFDd 19hWZO58VCKiJcJ/KSHQ1rwUFOxZX80Ih7Ph/b6AjJY1UV6NzdcyLptN8rU8OVenAEju 6b5vbTA0So/nJmWol/+uIU3nu6sBz8mmZLC+eYgunTrKZ6Ograd5TQFyq+hXe3ceiyng +nSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784120573; x=1784725373; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QFKJnPmVhYGXGMLsUKcHXY8gMyHNPu+ws0DPBz7tk5w=; b=pv7LcoaeN3Ah5QVWNP9BcCbrNE9TpN8t6cCSDpH721QQ1qujA5kMhOUwZeybyMo93s fRkM+C9xyDiaK97Fqpkn+SwZnaDgz0q+UmiTb+joEC3KO7/IQ856Wkp9Z+mi9LE8yYSV 4a4fk0RLe1+rkQTeEqEBwoPP4yqUkzZkXWMFsMLO/R1uaFiC0G0rsT7Cxb7lygazBZZF wg6szIbmDF2b6n0l1yY0lAYZyMVWx6gI4sab2XRDcTFwA5ajtutppmH0wcJ/Q0L8e3oB PsUlv9w1asvgbaA7w3ntTx8PowIKpiyxNSUgkVNihlrSImCaIS8XtsWgvA7tqGwI/sR9 OLLA== X-Forwarded-Encrypted: i=1; AHgh+RotRiEpgs6veirT5nlbO0uRmgiCbbrf+wsX/4f/mg8fo0qQPa801cRNtG4IXV0B8gXfZbCSd77MNCjuuCc=@vger.kernel.org X-Gm-Message-State: AOJu0YzrtzsTTjYPGXJ+hXo3cBOdzJlGkqUg767CpNs01A4Jr3f/pCRm WY7fNb0i7u7QQbBN2XPlMYHC02Jf0yXfiXOKjzx/0Q56S77zrSMBYake X-Gm-Gg: AfdE7cmBMG8NOPaAUsjUOR6LeuT4hPN1OnVNZn+cyZ1xfDl1UM3z+ohafUJA0JQS9oW ycXGp/X8BcmIakycqlv39r19tdZI8/l9lvKMTI1sgg77ryw0mBxzB6j8GTBT7ehK1Rp3rTihG8a mKUXWvetZiXrjeUkHfVL96eRWcsnEJfk5IKSia0IS2HKO0tv/i4w+uQIkMsvpRnmzuXPMIRIujF Mlm2mIUWpvNTIXRtXN6jtNuxQIzXz2n6t57ghuj+2hhVbLXl6EBtRzazX5PViKrtXbfQ6cg1GXw CVu4l1xiobFKxoGQ3jIoYUj2twJdWEiwgZ+/Pi1rq9EleKuTkcX53E0Vakyuo86go3h2ZlV2sWE FhWTuUSJYd/t3qKaIos3u+JqMw2dbF8PSyHXTWptsbuASLikv6WBRsBjIBegpBeU0Y7DXVU41rv ugFNFWcrE+wkd6mDv5kRTtXizPiVtYi/tEU1VCZSF2p7YIMKXyrObmk9YgeGWR8FjZ3EzoK87q1 7sxWCVmCbS03SzPg/74jOGQv+B2fgiSnsN7rvEqGu0jsPbQMSl/0Y9A6NyTVUI7cPcDrzywikWi 7/nJfCN0qphOB52IogsFAlU+bbwHbfwaW46k65CN94objNZ0yyrlX1XIOP7v7HymoV8OQnTqEQm KplAvO3dXGAenfGLu0bAk5iY= X-Received: by 2002:a05:600c:64c5:b0:493:be3e:cc3 with SMTP id 5b1f17b1804b1-49539824f8amr62710375e9.21.1784120572059; Wed, 15 Jul 2026 06:02:52 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4950a32a2casm219530045e9.12.2026.07.15.06.02.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 06:02:51 -0700 (PDT) Date: Wed, 15 Jul 2026 15:02:50 +0200 From: Joshua Crofts To: Esben Haabendal Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Martin Kepplinger , Sean Nyekjaer , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Martin Kepplinger , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] iio: accel: mma8452: Optimize struct mm8452_data member orders Message-ID: <20260715150250.00002307@gmail.com> In-Reply-To: <20260715-mma8452-open-drain-v2-3-95be9f5f4795@geanix.com> References: <20260715-mma8452-open-drain-v2-0-95be9f5f4795@geanix.com> <20260715-mma8452-open-drain-v2-3-95be9f5f4795@geanix.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 15 Jul 2026 14:33:29 +0200 Esben Haabendal wrote: > Reorder struct mma8452_data members to avoid holes. > > Signed-off-by: Esben Haabendal > --- > drivers/iio/accel/mma8452.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index fdf7364d7fed..537263085215 100644 > --- a/drivers/iio/accel/mma8452.c > +++ b/drivers/iio/accel/mma8452.c > @@ -108,11 +108,7 @@ struct mma8452_data { > struct i2c_client *client; > struct mutex lock; > struct iio_mount_matrix orientation; > - u8 ctrl_reg1; > - u8 data_cfg; > - bool open_drain; > const struct mma_chip_info *chip_info; > - int sleep_val; > struct regulator *vdd_reg; > struct regulator *vddio_reg; > > @@ -121,6 +117,11 @@ struct mma8452_data { > __be16 channels[3]; > aligned_s64 ts; > } buffer; > + > + int sleep_val; > + u8 ctrl_reg1; > + u8 data_cfg; > + bool open_drain; > }; > > /** > LGTM. Reviewed-by: Joshua Crofts -- Kind regards CJD