From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EF29420484 for ; Wed, 15 Jul 2026 13:08:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784120901; cv=none; b=bzxS9d8+Zis2hYaLGj5/H+Y5Pg3aYw4nYufwy1y9wdRjER1EE7vE5UG2xncDf6bpxyyKskG7CDn/Cj/i8GHw5jDQXZLmmCUOOBI8ie5mDpr6ckbYcLOcV499S8Z4BuF4zp8hPD2s/lgKFjVWeL5tJfXMJovp9OwLPvrsQ2erRH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784120901; c=relaxed/simple; bh=q7OLCL7VgoNJ870EwkW5fFPMIBWQZC0+C92RMBAqFds=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=liXTyGUdwF4gukFn5FCqXt+th53IrdAOe1JVoNzF4HSj/Wsj2dDPy7AYSpzCKEWjQu+lzWSjaLz/gcGoXMTIvfyO12c7bMejoxkigqcchqodhWjNMLwsdUTjxx90CLjEnKUwyb7i19kZJvsKJ0QI9+mgQA5glLqv9efgkq1QiPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JXzGsfw0; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JXzGsfw0" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47d70879764so3699913f8f.2 for ; Wed, 15 Jul 2026 06:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784120898; x=1784725698; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=UfonUu9ln9gTilLrABAupaUf7sQqFWMryYTmRFohNbc=; b=JXzGsfw0hYKTM3PjU+vY/5iJNETA1kJwQEClzuquNmBNkoqGZVldJNSBwgTIlpfw6Q M0EuO2POJrj6taJ47TEoKuSk49xc5L++UcEfX/2htq3Oe7vI5RghSMYoaNjj5Gil3Dc3 X0HC73R9/foXxZ2L/UkuYYmAl9uihPH/jEOkH46Qlv8kECyCKvtH95ghjI/LfmlkdbSe Ijsz942c605Lv7UAOIfv5SMrZbaQen7FRLZ/gZcEmB5zEo5pRCIeGQ1WzAkA1PMceGw1 5Kd/qkLYxM08Wr5ixCPfXtfhiJsvN2TnHtH2zPY6NymnTwLXPv5UvJgiHxbdEUWEWTvz tVJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784120898; x=1784725698; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UfonUu9ln9gTilLrABAupaUf7sQqFWMryYTmRFohNbc=; b=hLYu5onNRuwjUhLJBqXU7t+LQnzFKVyKGWB72jnAuXxxoLIwSpCHYw/42vM/sVbBlX ZH/z2Vquq+7wUnyYK0Y+t5Lufsdaj2+bVL4ItuSkQK/nwYeouJkbHuovdfcsWvGAUfTx /JUzHrztxsPM8HVddwXh5lyd6mfuNI6MVTwHKY5U49TUpHpAHBGGlr1lKyxIB5NIGwvp tjELfTB/dKknIczaQUvKxMZbhLJX0hrSAfZmAKmn/hM8l6L2c6xkuaXa3dBkVvxlneoX Dsi5gvhSOcYRXNUEUlCjrfT6mGDZ6i9WxreL97iplQCI0EhZAqeXycTUeMSQw7T96Bii +H5Q== X-Forwarded-Encrypted: i=1; AHgh+RpewXg4JhQve+fy/35z7fxtS7DGOBgnfjJ+ScLYzc0gKNeOXoBd+UGTQyyYK7xSBreHPRXLFe3X+Y3jPq4=@vger.kernel.org X-Gm-Message-State: AOJu0YwlHtPs3gp2nT+L1c0ZIH70lTrcEVrrsUDdPi/sW+Pyi4XGLQCG qeTsYd7cEao9OTR98jokvaKS2Py1cAwxtiiy6DoGRwPpublxO4NITKBn X-Gm-Gg: AfdE7ckp2pKPLE0DIes+Gmz3N94VX81BZU4zMT5rogyEu3E53yzkizOsXH+g3b4I68l CJCO3K4sAdgu0vszy3UR6qrC9k9A/mUB5ZnYMoLKnAuOyOhGR7v/+WPIvUmbvOF6Ob7Ug5vyldc unF8sV9ITEpALEyCxFN8mHYFyExjoqyROpUyY6gugr7pBJ5lTYU2GDovesbcWQOBPAYPc2vUv6a x5W6uV/BzpJUx0VphfGhSOOuNhzM8X5j/iX1s9Tqa8is0ExbcHzTQVEvpfojEs0a0kr2db2RjST t+BeWKj99KcvXlnBAli8y5019AXP1USNEbdL3u+U7wqro6GL5LZKnZF8brYX3BeQXe1M7LPP4LU 9BoVutZ24mbTKjSQqvXSyv/5H+XgZAdSdwMlK4bqZUihQ8dz/SRTyWSlBCKqvJMF3oK36iwOFbe HDsyn3Sa5EcI4qASZb6uZ1cbYEMOjqMor/f1b53wXkEBCABpCXIZGF8XQROy1Rlm07nM14DMOmz 0SCTzdWjsGXxh29m21vxCh6//dcpb0HbV78LETy2LDMn/qmj2JfJrfoTFLRBOgMoxKe5mjqDLGr mHpVR2+dQMUHCMzGQOZn0RmMWA14zs4m2BOKf0EwMoFxsGqp+oUionvz66M0rQJNVfNrAZOPfbN IkPbNWqPExH+Es78m7+R2gxKynIImdDsW2Q== X-Received: by 2002:a05:6000:1841:b0:47f:4e42:6f1 with SMTP id ffacd0b85a97d-47f4fceef3amr3279570f8f.41.1784120898478; Wed, 15 Jul 2026 06:08:18 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f4634e0e4sm17579561f8f.4.2026.07.15.06.08.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 06:08:18 -0700 (PDT) Date: Wed, 15 Jul 2026 15:08:16 +0200 From: Joshua Crofts To: Esben Haabendal Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Martin Kepplinger , Sean Nyekjaer , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Martin Kepplinger , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] iio: accel: mma8452: Optimize struct mm8452_data member orders Message-ID: <20260715150816.00007d7f@gmail.com> In-Reply-To: <20260715-mma8452-open-drain-v2-3-95be9f5f4795@geanix.com> References: <20260715-mma8452-open-drain-v2-0-95be9f5f4795@geanix.com> <20260715-mma8452-open-drain-v2-3-95be9f5f4795@geanix.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 15 Jul 2026 14:33:29 +0200 Esben Haabendal wrote: > Reorder struct mma8452_data members to avoid holes. > > Signed-off-by: Esben Haabendal > --- > drivers/iio/accel/mma8452.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index fdf7364d7fed..537263085215 100644 > --- a/drivers/iio/accel/mma8452.c > +++ b/drivers/iio/accel/mma8452.c > @@ -108,11 +108,7 @@ struct mma8452_data { > struct i2c_client *client; > struct mutex lock; > struct iio_mount_matrix orientation; > - u8 ctrl_reg1; > - u8 data_cfg; > - bool open_drain; > const struct mma_chip_info *chip_info; > - int sleep_val; > struct regulator *vdd_reg; > struct regulator *vddio_reg; > > @@ -121,6 +117,11 @@ struct mma8452_data { > __be16 channels[3]; > aligned_s64 ts; > } buffer; > + > + int sleep_val; > + u8 ctrl_reg1; > + u8 data_cfg; > + bool open_drain; > }; Also quick thing, in order to prevent too much cruft, could you please move this patch before patch 2? You introduce the bool in 2 and then move it to the end in 3, better for you to reorder it first and add the bool after, otherwise you get these "ping-pong" style changes (Andy's words). My reviewed-by still stands either way, so feel free to add it once reordered. -- Kind regards CJD