From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B96AA3D7D87 for ; Wed, 15 Jul 2026 23:55:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784159718; cv=none; b=p4Lh+aWfZyw+3G4AwE7eTbWCZRN07hEss9hTv64AYt+qU6rYF2uEBltXFXiAcoQIUZoTY7/8J7CM1KFXlaOWQJRwVPoqVCB6q1t9dFDnxjgkULIw3zsilyRlnjHxkc67ldnxWvKasY5TgPKiLb098kSoD8dbsQnVKG3t9J+Xe70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784159718; c=relaxed/simple; bh=is1pW2HuG81gcCJFv7FSgdB2gm4dZ36chPReSl96KrE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C/ERc/juaKRVf7omMFux5bkYlnc2e6gmbWvylxkul6aFz4aNDFwmCglfB6Gs84nfvAWOXJx2wdVFztDTvNPBQkTmZVMkugJefg40Zr/5GYiJrK6FQlQVrjzgSwzJ8hqWLntV2qeYslZA734oVvga+36rVbqzXvb+dsXORPKNzK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b85gm3Yj; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b85gm3Yj" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-38dfe7eb825so2517616a91.0 for ; Wed, 15 Jul 2026 16:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784159716; x=1784764516; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BPaYRuKfVlAHIk2YkEvf4Nb9gfPYqcQWIb2PtQaeYYw=; b=b85gm3YjaXa7X2r/DzwYEbFwB1gSbfHkWjNvCLnxpc2NlbWY0yL7a6bB0WpetlV+BP wZp4kS5LcqVb8Txme19qgZt5vKfrrf6lZshgjv68n5ndJj1+vwwKAVuQOA39d9Lwqcdi KIXz700VHHNN8XyxQlVTIFVGWyiZ7ntMyz2sZovNnnvO3SbsYxHtJcRCuLpCsLYjj/MU BNmXRzNccRPzlPd6vqn7Bw1AG+6z5wL549CSsZMcXES/sT/FgqSFprKvMlbFLHCUQKrE CW+DhImnXd9GKn0sM1gM1Li1bpcA6HjmQ786ZCQMS6xmO6BUxtxF1ph99fs4KBReEK/q SJkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784159716; x=1784764516; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BPaYRuKfVlAHIk2YkEvf4Nb9gfPYqcQWIb2PtQaeYYw=; b=BNy2H2pyKjjblNMImICk2KFFDbA+E+VBHBxj3k9fx0aJaCiG1NVH7ifkPhxruXraDu 7NPliBX1gsjyhZKIPdQh8Eys8XYvLlI9U17xWOPMYQ5kvzPoLFTPBQKlO9cW8KY/tMD3 tB+4CRjCFO2vTk7E+fVia7vCCa4DXOolcRI6ECP9vCDBMSuQ0ygAjV5eGI12b96KhpAt JjHenQdOQLqDSVkZ70KBswNdP7Y4UKFsq3y+x3PfzPD2v05EsFawqAdnpPFGRkNbwTcR Un5lsrWYL7zkkKJYph5VObdFVl04hx2yctuPtyOK9kUTRnltjF4Qmg5+vsyk5rX7n/Cs El+g== X-Forwarded-Encrypted: i=1; AHgh+RomTl+Mt9XBZS7fHXfNeVS42PLN1+NIZFWDbTp/22aU4FWbG8SmGG6CZHoUc678uT/PpwvItm2Z1FTwy6k=@vger.kernel.org X-Gm-Message-State: AOJu0Yxdu2R9VsfaT/fz4zqIjhhLbG6eyjsBPhz2oiZA8cfdzEBIy1mL pvSC9gUBPOQASwn/rBbVxhgvP55BGSY8a1phA+Nlb9DV9tWPW7s6Fs+I X-Gm-Gg: AfdE7clBJ0EeEWHBWE+Cc/il5jmi1RexrgPkyQv3rozpWk+e0dw92w2jQYadBYj0dmr uqXOGK/tHvFm0JDTgbAAotCy00hYw25hXsx17baFzD+ussl0YrvKeEFEImDbDwsHCkUlV1SW8t2 fZb7XoVzP0FS8bqc7yxVuwIbwiLhKXA6WQvjI9oW+QDpdYqbV4pG4aiEJQJWAwEdHPQNCUMrLi8 wVtY5M9+G6VgNoFV9iYrHCufLjolaNc4fyA2SCvwznvOzXgMHmJTYONRqQbKLl6HXZs9gZBkibe uxxIJcBCGZ1T+gHmGSMivVBO+DgGZrU17WOZBGitgQuW4Sei+j5Hm7hkQn33sf+oTuhxO62mZl8 hArnfisYGhqdzM1WYFtj/Yy8fZleUcktW0rbSk+wp5opLk68nraxpcexQ66dxeGcfU7DdSKgEk0 d132bT+zGtn07EwW+OT5gDYyt1niEFHgSiEHDsjj2TRzQJn1dPNigjh2lgtZyaOKfOrlYFgL7MX A== X-Received: by 2002:a17:90b:2d4e:b0:387:e0db:bc29 with SMTP id 98e67ed59e1d1-38dc77d79e0mr18418496a91.41.1784159716059; Wed, 15 Jul 2026 16:55:16 -0700 (PDT) Received: from bloom.localdomain ([2604:3d09:178e:e100::9dab]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf100e3946sm10223245ad.4.2026.07.15.16.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 16:55:15 -0700 (PDT) From: Ivy Lopez To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ivy Lopez Subject: [PATCH] staging: rtl8723bs: use kfree_sensitive() for key material Date: Wed, 15 Jul 2026 17:55:11 -0600 Message-ID: <20260715235511.7357-1-skunkolee@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260713233401.48262-1-skunkolee@gmail.com> References: <20260713233401.48262-1-skunkolee@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The set_stakey_parm struct contains a 16-byte encryption key. Use kfree_sensitive() instead of kfree() to ensure the key material is zeroed before the memory is freed, preventing potential information leaks. Signed-off-by: Ivy Lopez --- Changes in v2/v3: - Remove unrelated ftmac100 changes accidentally included in v1 drivers/staging/rtl8723bs/core/rtw_cmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c index b932670f5d63..a34ee407285b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -899,7 +899,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 unicast_ if (enqueue) { ph2c = kzalloc_obj(*ph2c); if (!ph2c) { - kfree(psetstakey_para); + kfree_sensitive(psetstakey_para); res = _FAIL; goto exit; } @@ -907,7 +907,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 unicast_ psetstakey_rsp = kzalloc_obj(*psetstakey_rsp); if (!psetstakey_rsp) { kfree(ph2c); - kfree(psetstakey_para); + kfree_sensitive(psetstakey_para); res = _FAIL; goto exit; } @@ -918,7 +918,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 unicast_ res = rtw_enqueue_cmd(pcmdpriv, ph2c); } else { set_stakey_hdl(padapter, (u8 *)psetstakey_para); - kfree(psetstakey_para); + kfree_sensitive(psetstakey_para); } exit: return res; @@ -958,7 +958,7 @@ u8 rtw_clearstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 enqueu psetstakey_rsp = kzalloc_obj(*psetstakey_rsp); if (!psetstakey_rsp) { kfree(ph2c); - kfree(psetstakey_para); + kfree_sensitive(psetstakey_para); res = _FAIL; goto exit; } -- 2.55.0