From: Leon Romanovsky <leon@kernel.org>
To: Abhijit Gangurde <abhijit.gangurde@amd.com>
Cc: jgg@ziepe.ca, kuba@kernel.org, davem@davemloft.net,
allen.hubbe@amd.com, andrew+netdev@lunn.ch,
brett.creeley@amd.com, edumazet@google.com, pabeni@redhat.com,
nikhil.agarwal@amd.com, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dwmw2@infradead.org
Subject: Re: [for-next v4 0/5] ionic: RDMA completion timestamping support
Date: Thu, 16 Jul 2026 12:19:16 +0300 [thread overview]
Message-ID: <20260716091916.GC357857@unreal> (raw)
In-Reply-To: <7b5f02bb-26db-175e-34cc-40318b0752b2@amd.com>
On Thu, Jul 16, 2026 at 02:26:22PM +0530, Abhijit Gangurde wrote:
> Thanks Leon. This is already addressed in https://patchwork.kernel.org/project/linux-rdma/patch/20260617132605.1888205-3-abhijit.gangurde@amd.com/
> which was sent after this series. Happy to rebase if needed.
You need to rebase this, as we moved ib_respond_empty_udata()
from the end of the function to the beginning.
Also, please send this as a separate patch or series.
Thanks.
>
>
> On 7/16/26 13:31, Leon Romanovsky wrote:
> > On Wed, Jul 15, 2026 at 06:38:06PM +0530, Abhijit Gangurde wrote:
> > > Hi Jason, Jakub,
> > >
> > > Gentle ping — if there are no further concerns, could this series be merged
> > > through the rdma tree?
> > Jason requested converting any driver that extends udata to
> > use uverbs_robust_udata.
> >
> > https://lore.kernel.org/linux-rdma/13-v3-bd56dd443069+49-bnxt_re_uapi_jgg@nvidia.com/
> >
> > Thanks
> >
> > > Thanks,
> > > Abhijit
> > >
> > > On 6/10/26 21:12, Abhijit Gangurde wrote:
> > > > Hi,
> > > >
> > > > This series adds RDMA completion timestamp support for ionic.
> > > >
> > > > It enables PHC registration for RDMA timestamp capability, exposes a PHC
> > > > state page for safe user-space reads, maps that PHC state through RDMA
> > > > ucontext mmap, and extends the RDMA CQE format to carry completion
> > > > timestamps.
> > > >
> > > > With this, user space can read completion timestamps and convert them to
> > > > wall time with low overhead.
> > > >
> > > > Provider's PR: https://github.com/linux-rdma/rdma-core/pull/1724
> > > >
> > > > v4:
> > > > - Added alias mapping of mlx5_ib_clock_info to ib_uverbs_clock_info
> > > > v3:
> > > > - Renamed ib_uverbs_phc_state to ib_uverbs_clock_info
> > > > - Moved mlx5 to use the common clock info structure
> > > > - Addressed review feedback from Sashiko
> > > > - https://lore.kernel.org/linux-rdma/20260606050003.3648306-1-abhijit.gangurde@amd.com/
> > > > v2:
> > > > - changed ionic_phc_state to ib_uverbs_phc_state and moved it under
> > > > ib_user_verbs.h
> > > > - https://lore.kernel.org/linux-rdma/20260512092623.1157199-1-abhijit.gangurde@amd.com/
> > > > v1:
> > > > - https://lore.kernel.org/all/20260401102501.3395305-1-abhijit.gangurde@amd.com/
> > > >
> > > > Abhijit Gangurde (5):
> > > > net: ionic: register PHC for rdma timestamping
> > > > net: ionic: Add PHC state page for user space access
> > > > RDMA/ionic: map PHC state into user space
> > > > RDMA/ionic: add completion timestamp to CQE format
> > > > RDMA/mlx5: move mlx5 clock info to common struct ib_uverbs_clock_info
> > > >
> > > > .../infiniband/hw/ionic/ionic_controlpath.c | 34 ++++++++++
> > > > drivers/infiniband/hw/ionic/ionic_datapath.c | 43 ++++++-------
> > > > drivers/infiniband/hw/ionic/ionic_fw.h | 12 +++-
> > > > drivers/infiniband/hw/ionic/ionic_ibdev.h | 2 +
> > > > drivers/infiniband/hw/ionic/ionic_lif_cfg.c | 2 +
> > > > drivers/infiniband/hw/ionic/ionic_lif_cfg.h | 1 +
> > > > .../ethernet/pensando/ionic/ionic_ethtool.c | 12 ++--
> > > > .../net/ethernet/pensando/ionic/ionic_if.h | 1 +
> > > > .../net/ethernet/pensando/ionic/ionic_lif.c | 5 +-
> > > > .../net/ethernet/pensando/ionic/ionic_lif.h | 3 +-
> > > > .../net/ethernet/pensando/ionic/ionic_phc.c | 63 ++++++++++++++++---
> > > > include/uapi/rdma/ib_user_verbs.h | 33 ++++++++++
> > > > include/uapi/rdma/ionic-abi.h | 1 +
> > > > include/uapi/rdma/mlx5-abi.h | 15 ++---
> > > > 14 files changed, 179 insertions(+), 48 deletions(-)
> > > >
prev parent reply other threads:[~2026-07-16 9:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 15:42 [for-next v4 0/5] ionic: RDMA completion timestamping support Abhijit Gangurde
2026-06-10 15:42 ` [for-next v4 1/5] net: ionic: register PHC for rdma timestamping Abhijit Gangurde
2026-06-10 15:42 ` [for-next v4 2/5] net: ionic: Add PHC state page for user space access Abhijit Gangurde
2026-06-10 15:42 ` [for-next v4 3/5] RDMA/ionic: map PHC state into user space Abhijit Gangurde
2026-06-10 15:42 ` [for-next v4 4/5] RDMA/ionic: add completion timestamp to CQE format Abhijit Gangurde
2026-06-10 15:42 ` [for-next v4 5/5] RDMA/mlx5: move mlx5 clock info to common struct ib_uverbs_clock_info Abhijit Gangurde
2026-07-15 13:08 ` [for-next v4 0/5] ionic: RDMA completion timestamping support Abhijit Gangurde
2026-07-16 8:01 ` Leon Romanovsky
2026-07-16 8:56 ` Abhijit Gangurde
2026-07-16 9:19 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260716091916.GC357857@unreal \
--to=leon@kernel.org \
--cc=abhijit.gangurde@amd.com \
--cc=allen.hubbe@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=edumazet@google.com \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikhil.agarwal@amd.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox