From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 879993F4853 for ; Thu, 16 Jul 2026 09:32:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784194364; cv=none; b=PFzW6wh0fRJQmS+FYrl1raus4z3So0nofnf3M7oVMn9QYMGHVA+J/Yem6bI2qNJ9jPoR6qicJvFcVb48Jxeklv+tLCaabJEl7DWom2dgRwYj6cAAf66ixiOw0IGK1cWdDZ7y7M78CpEDkf2Q5UbvYbr5vCtyZgMpZndaNJEW6BU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784194364; c=relaxed/simple; bh=cPmpmx+T5sAWycdpqF364kuymZ/P1B9n9CUUBg6crMU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uhsO1rMfX84EtrcWP8B5M0B9aVZ2U8QOvaUo26werag+5U6dKQnlehwSK7WfJmcb9w7ajO1s+zdldXnEIgEfho7jzOPcC/lp2a3b6i6P6aPooQbGYsNmYbVfr5JvbV3av/eQDLzdpLRB+5+yUNHFOrkAfvaTndrcBh8WMd8h04E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K/y3csxw; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K/y3csxw" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493b966dd74so25907895e9.3 for ; Thu, 16 Jul 2026 02:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784194359; x=1784799159; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=zMCp06Fn7LM1KbKjNDRyvgq+gIPkw0ShH7Q56EFQy0E=; b=K/y3csxwNu4Fd3RqfPYeUBRGDZFXvvuEx2hKSB8qibeBokcxFISgRcIb5LB075dCW6 YIwSBVFxgLRokj4VbeS1y6s08JefvE2btKkwvT2dlWtdOqi4wwruVFd6GsTbVHZWrw6c d7VR0cnHBejI2XuPiDBvWM3qr8z3AEEmj0lxNviGaMj9/BSy6eOGhSf7VPbQFaBvX9Yi 9UHEp8CtF+/a2cfectVTJ8qVZ9OjGB9HbtjNNoJRIPJJmAASPPmQNy6GcQPQdClAnSjj +jBNL7eTSAQaOMCdozRdaYwssyXZs00a7yAZQ7TJ2HyRRrjQjwU05z39HRQlrWblFv3q dr+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784194359; x=1784799159; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zMCp06Fn7LM1KbKjNDRyvgq+gIPkw0ShH7Q56EFQy0E=; b=qVB9LKod4DSfFZD3utC1uK+wnF3sXU+Kf3q8WsT6zHcjf1MTllgGDwIsbjYmkCTmF2 Wn9VCb7alkzf27NrdbfwwI3ejlV95NrfpfO2RFpe3SvQvuJxvKX+s8FvVvoK5k4L9dKn LFwtcs0MPlMfepB0FfdtHakxeE1BEaFfaiQ2fqoN88UYVVuQYe2GlACTTabMwlfelZ1y 5dd09FnhVCksRdcvOuQ5FwBQ0qt3/yHREgaBeGUckqITMmSM/HEhSCvNMiL+V7ipk7M6 R0LDOxNlELeRDk7S3lcRItfLgbC6/PYUfWXQvI3kQlOA591vlByZuLEMhve1+4zf0fn6 ULSg== X-Forwarded-Encrypted: i=1; AHgh+RoSP6ZXpFT3WANabVadlsTH+iKU3waFH4z4nOEIp+/FB5USiHVyr2CHeQh7CZajlsjVP+8yTdrSUg/UNTM=@vger.kernel.org X-Gm-Message-State: AOJu0YwatSrvODyTVADBypswJngtCOp99YJIO6GmkLuHQWApjwPGX6Y/ 16La/DwY6zBlgENPDZkH5oxtsY4Y4on05RNEhN27mwHz/1xVsMHAiLv6 X-Gm-Gg: AfdE7ckS/DKp12PPMCydFPlDlrC9WpM/309owQyh0CT1HHUvNIJ9ZJ7gbx9FbIWVmMz qjJuiq0YBVs5w2UX4ytQxW6TwP1s2YxLsIpT+LovWfuo7UHhtWnoZVRYaQiXvRvpcAgBw1bCZsr HUS0VEBaYsPv9KFHXk0NYor8krn1wlPir9+EVsMrMO8FhZOJvPjhYcVEjW/M+wV31Q7nxW7V+Lz /ip7RdeIQrYQqWsI25GZnMkFgAdGn5FNsgkWzVY7boV0HUBcLEn352HR+LCqPr3g1SICOrCbAwk Bqj0TdOkj6icC4mlKslrvaGJnAqcCAn/7tc5s50kNv8RMt9bYrvg9AlaK5kpexGq+NVHctaGDZi 1oQhM95Dm+2dW/3JbYb0t1TMoHeuLSE+AY0SJlN1MwNa6fK263DKASfjWAVGrExwRJQW+km8gER QqqKr6J/LlR/JHCnObFzI0Vm0MhiE7sTP3q+9+k75FMtr+Qgqi9A== X-Received: by 2002:a05:600c:1e0f:b0:493:b03c:5650 with SMTP id 5b1f17b1804b1-4953c280b8amr61833475e9.19.1784194358954; Thu, 16 Jul 2026 02:32:38 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49541e83d05sm40799655e9.6.2026.07.16.02.32.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 02:32:38 -0700 (PDT) Date: Thu, 16 Jul 2026 10:32:36 +0100 From: David Laight To: Ian Bridges Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] Input: wacom_w8001 - replace strlcat() with a strscpy() helper Message-ID: <20260716103236.28c1b5bb@pumpkin> In-Reply-To: References: X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 14 Jul 2026 20:22:41 -0500 Ian Bridges wrote: > In preparation for removing the strlcat() API[1], replace its five > uses with a small append helper built on strnlen() and strscpy(). > > The five calls append device name fragments to a basename buffer > that grows in place across the setup functions. The helper takes > the same arguments as strlcat() and writes the same bytes, including > when a fragment is truncated. You can do much better than that... Change w8001_setup_touch/pen() to return the 'const char *' name, then put everything together in the final snprintf(). David