From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4761363086 for ; Thu, 16 Jul 2026 20:29:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784233798; cv=none; b=aWm8pJkbMMG28EUIpwUbhmNn8g5InlA9uEE3VrwEmSyd+XZ1P9ODbnBuVKNCiNoRrhuMJe3C3tH6QLhg4xzk6xXBc2lL2c49VOwBDFcMa8yMh33ubwkXKnFT42mQUB6E28ni0GPQC5dK5Zw3z+es6hU9u4uONaN5UJ3m+6xtPn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784233798; c=relaxed/simple; bh=IJeXEkvaYFI2ijYHmji3XnM2xTV5dy+jj6rf7SrwbqI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n8QpFU/kPcAcRQMZrqqvGVkLkRWGkkuGEBIbqCDn5WFdcX+uVMdQJU5Td8D9vz3hDnj6VpfJcMdCUbppCzHRhPEmqBYBqLXwKfJ2pxL4bEdenEHaqH5M98w0W617F0bEmA3tCc9k7egzbETnvAa17c57SsDaelRvPAQjIoCz7Ao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MLCgeyW1; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MLCgeyW1" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-8484a0b998fso5800096b3a.2 for ; Thu, 16 Jul 2026 13:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784233795; x=1784838595; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fq5+Et8VCLx3YNlIRBYElnfSV6kqx1OSwg8TLAZrMWc=; b=MLCgeyW1elEKq4u6vnf07npCC6EEOIPz2PU0jDlk1gGKvOqctznswNDBBfwdN13IuC RLVjUk+o0KkcVqG3xOn3voCScfBJi5j8Lfmwz0vvNi7UkX0+p5lk3xh7PO1Py+ECP/1O k2/3XH0qXiQlqgj0q44xpKvVlU1WbkvCQDtJniJN7Gwg61DucumQXqyt02ycVlhI5B5V HaDBJC3f7MIlGgroq1IAhaIUeyskpMkc3uJdkwGuUrrCxdbgYcddGaorf+5yLs/A/Bit n+ZUYTgaC0H9s/FfEF/oqzIMETDp9LOVlF0H0ZeLeycbM4SZweDtGKcRNeMFeJGcD25n +KUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784233795; x=1784838595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=fq5+Et8VCLx3YNlIRBYElnfSV6kqx1OSwg8TLAZrMWc=; b=AqyV8ZKWD8xRRpVTd0HiwjV9/HeWwQLsnkZSLZziTj0G36/pZ6rJfcFPvyO1jqv31b /8KGbRmSTKlyg2rAk1kHj9syuYgWLECwjY2Q7b9wqFqGJJSRhxQofEJkEitUpgmgrvUf rln6B6jmBd4UkDw+UgasQCdsD9kRiaZitJjYJ/Z+BtfRsQC+XHUHp+Lwc6YvbdW2chxH B0Fl7PVs7a0rrqDq0TFlrVUgNY4CNUaH27xbVVsCY/oe7iPGkpJJdM1mgL4a+c0zbewm oGlk+iQXP3rEYz16kSKaJTqavFDUO8QxPQHhfyzG7v37OQ7E543k3gNcxNmsi9+xWozH aGwA== X-Forwarded-Encrypted: i=1; AHgh+RoU2r97TjgvifdGkD9zxF8F7Cw5RcILCyflmJWFSqhdgY3O+zNKM+aQust1FGzVJw8gTKC2IvOcy5TNjXw=@vger.kernel.org X-Gm-Message-State: AOJu0YwWoy2vUaKblqRc89CdlSxHzMrL2hPrQlzpSvT1CuVdk2mbcukT Df+s6U9FQIruIFcxDrgsDK/debm/ze2q3uS1GYQ6+jN9VK3QFRVnoYsH X-Gm-Gg: AfdE7cnnBZVvF84nthsRIGpGimiiKjCLvyhRa3G3jSAyZIyQWQUfuAxWbm4TeV2l6SW H8842rfSdiTQCSI3PTJkxW0Adt0GdRqmpvWUZbqJcRyJizghs4t8bVl4duQMdYEArEEuSPU4MV6 9plPLe/1wIQiqrUj0FqmY2b4l5EP4mZhTlux94bo071jgsiKcNe50GWdNRLkKF980tq3vzzEoGJ VnLu+5vXwdRZdbZcnoBPxNGe1JLSyLC02tdjsRZ7/LblpcYglHSK1RGfH++X1HYzkPEn/5vKxth Z5+3ICz4Cb4jjiWmupINlD5kixzahdYS0rlLQ2Of8RRxQEz89jqPymWp5T+Qd5dTGm190F9pzYS CBmj0QJ9IPYrmsXQ9kr+6U7HR9VLM8zrdAyyy2ldNicVsbIyV1jq8Z+OjAVx/uNcAdV9ArpLqdA vMN3BcnnKYxubYC/ajhxSo1QxwEyE0jplMKY6joIFD1fes86jy1L+8lc8uFCffJoKH8d/SJokvJ x96Fq/0/r0nhTqiZ7e2c8qfQ1SeOIhIGM56+6ctKxb31dVvuz74HfM= X-Received: by 2002:a05:6a00:4388:b0:82f:50cd:e586 with SMTP id d2e1a72fcca58-84c234f913fmr859680b3a.13.1784233795193; Thu, 16 Jul 2026 13:29:55 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f26f703sm5536776b3a.17.2026.07.16.13.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 13:29:54 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 1/4] dma: fsl_raid: convert descriptor stores to big-endian Date: Thu, 16 Jul 2026 13:29:46 -0700 Message-ID: <20260716202949.677290-2-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716202949.677290-1-rosenp@gmail.com> References: <20260716202949.677290-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The descriptor structs (fsl_re_cmpnd_frame / fsl_re_hw_desc) are in-memory but their fields are __be32, because the structures are handed to the device as big-endian. The driver stored CPU-endian u32 values into them directly, which is both wrong (the engine would see byte-swapped lengths/addresses) and flagged by sparse as a base-type mismatch. Wrap those stores in cpu_to_be32() so the values are little->big converted. Reported-by: kernel test robot Fixes: https://lore.kernel.org/oe-kbuild-all/202008111749.yy85rFMD%25lkp@intel.com/ Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- drivers/dma/fsl_raid.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c index 99945845d8b5..2778d07a05e8 100644 --- a/drivers/dma/fsl_raid.c +++ b/drivers/dma/fsl_raid.c @@ -242,9 +242,9 @@ static void fill_cfd_frame(struct fsl_re_cmpnd_frame *cf, u8 index, u32 efrl = length & FSL_RE_CF_LENGTH_MASK; efrl |= final << FSL_RE_CF_FINAL_SHIFT; - cf[index].efrl32 = efrl; - cf[index].addr_high = upper_32_bits(addr); - cf[index].addr_low = lower_32_bits(addr); + cf[index].efrl32 = cpu_to_be32(efrl); + cf[index].addr_high = cpu_to_be32(upper_32_bits(addr)); + cf[index].addr_low = cpu_to_be32(lower_32_bits(addr)); } static struct fsl_re_desc *fsl_re_init_desc(struct fsl_re_chan *re_chan, @@ -256,9 +256,10 @@ static struct fsl_re_desc *fsl_re_init_desc(struct fsl_re_chan *re_chan, dma_async_tx_descriptor_init(&desc->async_tx, &re_chan->chan); INIT_LIST_HEAD(&desc->node); - desc->hwdesc.fmt32 = FSL_RE_FRAME_FORMAT << FSL_RE_HWDESC_FMT_SHIFT; - desc->hwdesc.lbea32 = upper_32_bits(paddr); - desc->hwdesc.addr_low = lower_32_bits(paddr); + desc->hwdesc.fmt32 = cpu_to_be32(FSL_RE_FRAME_FORMAT << + FSL_RE_HWDESC_FMT_SHIFT); + desc->hwdesc.lbea32 = cpu_to_be32(upper_32_bits(paddr)); + desc->hwdesc.addr_low = cpu_to_be32(lower_32_bits(paddr)); desc->cf_addr = cf; desc->cf_paddr = paddr; -- 2.55.0