From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02237346E55 for ; Fri, 17 Jul 2026 08:04:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784275461; cv=none; b=hGytzCq2+WsxOobIiarvMNaTjbwIegINvbJ6pXm+te8pK1Netko4lv+Nf5LH3mFnvBc5WAk6t+ljFzMNAf+1itQ/xDYIJJBeByq+5vgycbO4cYzHFVNPQcCSoQEmtnzwm6DauAvFaZ4a6w5HfZaUf5BSmucjLlASuPjJs9lvrOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784275461; c=relaxed/simple; bh=bCSGhR4DxbYBnc1MiMyq1DyDQDRo3jRJWoVzeOkDWWM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WYDYywVtqNqyFknKT1InW1+8adMuq0gAXms0bqB3d7BcR3VKVbOO3qwzDiWA/HXiFt5cNvjAJAnjobQd7nX/qPhJWAhugGQ27zQsWTkS45kUCHbhYTRhW3H7rkV7gCDrwNmjAxTV709xjEUq8J2USYuav2WWFBDSCSLxAe+BDb0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iFdZB3+C; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iFdZB3+C" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-493f25d47dcso26039835e9.1 for ; Fri, 17 Jul 2026 01:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784275458; x=1784880258; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Q4OAkmNxhp6Rm8jcMCdidsG/dyC+Qqj5a9o/3Z1ag28=; b=iFdZB3+Cm2GpWNpsuUM1eDhlXJOxRFsPqYIUJ/tQ+vdcqBQEeCYMkWHX8hsMy8Am+2 FJWlK5GW+m82eM1d35ziLpuWT1bTTMPP6aXVbLGANLEHmfUkTdht4Zy8L2GhR66neilc ywrjWwc0Q8N/cdeQ+jkmrrbYnyAnstq95HOD0md4UfY1+TyRGSmYetP8qW8Yvq83xkvr aDC5R4ZsGHqAe4XiJnTmtjX0+B4/N5h9H/f1GQ7ISSSgkQzPca5Ipn6IPZF4lxO6ILZz xBvG10++OdT0sqdW2c2bpGeVvg6er7FAn60NAQ6rAMyVuujmUz1yqKUgLRtbd+Xbh/d9 8LBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784275458; x=1784880258; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Q4OAkmNxhp6Rm8jcMCdidsG/dyC+Qqj5a9o/3Z1ag28=; b=GXqmAJTUI3EonvIp/JAHFoAmPF1fwip9qdsIAH9lcgBfdehaQbi4VhkaESfl8BHzMy jQwEXa/ob5z+U0+x7NbtmQoEkYVw85TACuQPQ8qovEXcwqeqUll6PI9M2HUWAi9Udyr2 uUpniXGNZMbKmBm2u2WDqxkMAzMSBdQ8VHrbADmMu1VtRYJguIYlMfS6Piklux3k5PZ+ 77+CNbNOgc59slNjaRkUa/ex5sfuRXeI1TiPk3KmqszUtELHCBIpHkEUkan5LB1hInA5 Ma5N8LrXKWAUuZAorRICNV7QHv1f/r6khnTA35dxmlZJu9BoCS7Ba/YNy4m7Pi8QtQmP xoUA== X-Forwarded-Encrypted: i=1; AHgh+Rp+sw58AE0WAczk1fHOpXmuZNOOxf/m9qDpeKF5hTVv156YmaIEclgQEll99HBCT5W3cykdjUHMGJ5fFwM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxc/UeQcwPczbJYVjNaGYiWaRwV5SxL1BjASN6aE9lNwKtpvFwX t++snSZ6FJ8tXPZudLsonUEEpinCji+t+zvsOjl/6h+DMxrODpQuX47F2uWilIx6 X-Gm-Gg: AfdE7clUv/34zGn3nvFPAnnvl2aenlG2bSpFbEp33KwVAj/L1Ot6C6g6rC6Oc2zywus q7rWncXDoEd1/qrI10UTAqUGwnTxV8UmSFyjr1mRdMd3l35/W+Nw0DyLXFeaQbp9ys1AYieBKo0 7x0yfl69QWKJReLbzF4m5DxM0ISZ6UUu3gE1Bs7aVQQz3cAN/CVZG5AYzst9ixA5YNN6zRT6Mzm BS6f1Uhs/utG6EMR9Iye5VlVpZeX0xJdWFU60e2oqd9X22y2z7SsnJ8nDk9bAWmBqbp6Yrlk1mU 9AFLJticbLz0CgS0xRv2FvossI9VHMG+lJmGzhKFZTkQhBHdSwd/5hTwbbjmu6FVR8+MFHTpF/n EOyh4k+qNK39kZ4zAkyCjoyNe3/4cacurPoFCF1fZyYByLpWDI0AS6jHV5GDgCpYArM+8mudfnv vCzcepWqCubW/6fWwFVisUTX2NhrKWoB7ZK4azFy8= X-Received: by 2002:a05:600c:4e88:b0:493:ee4d:5c5d with SMTP id 5b1f17b1804b1-4954a40be25mr16065435e9.31.1784275457797; Fri, 17 Jul 2026 01:04:17 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2f210csm30955275e9.15.2026.07.17.01.04.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 01:04:17 -0700 (PDT) Date: Fri, 17 Jul 2026 09:04:15 +0100 From: David Laight To: wangdich9700@163.com Cc: tiwai@suse.de, broonie@kernel.org, wangdicheng@kylinos.cn, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 3/4] ASoC: fsl_easrc: Use div64_u64 for 64-by-64 division Message-ID: <20260717090415.07b0e46c@pumpkin> In-Reply-To: <20260717070252.525545-4-wangdich9700@163.com> References: <20260717070252.525545-1-wangdich9700@163.com> <20260717070252.525545-4-wangdich9700@163.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 17 Jul 2026 15:02:51 +0800 wangdich9700@163.com wrote: > From: wangdicheng > > Fix a compiler warning about do_div() truncating a 64-bit divisor: It's not a compiler warning. > > sound/soc/fsl/fsl_easrc.c:2061:2-8: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead. > > do_div() truncates the divisor to 32 bits, but val1 is u64 and may > exceed the 32-bit range after (u64)in_rate << frac_bits >> 12 with > frac_bits up to 39. Use div64_u64() to perform a proper 64-by-64 > division and avoid potential truncation. > > Fixes: 955ac624058f ("ASoC: fsl_easrc: Add EASRC ASoC CPU DAI drivers") > Cc: > Signed-off-by: wangdicheng > --- > sound/soc/fsl/fsl_easrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c > index 114a6c0b6b73..d0bbe9f71e36 100644 > --- a/sound/soc/fsl/fsl_easrc.c > +++ b/sound/soc/fsl/fsl_easrc.c > @@ -2058,7 +2058,7 @@ static int fsl_easrc_m2m_calc_out_len(struct fsl_asrc_pair *pair, int input_buff > /* right shift 12 bit to make ratio in 32bit space */ > val2 = (u64)in_samples << (frac_bits - 12); > val1 = val1 >> 12; > - do_div(val2, val1); > + val2 = div64_u64(val2, val1); Are you sure the domain of val1 can exceed 32 bits? There is a comment in the patch block that implies otherwise. David > out_samples = val2; > > out_length = out_samples * out_width * channels;