From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D40213E00BE for ; Fri, 17 Jul 2026 08:06:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784275623; cv=none; b=bdzQXMB6nSOpyu6++sr6bCsUM5+EFRhANbeD0+TB6LjrgJL9+LYeqEAQFfd9tjUlWLbsPXHNex+ByBTy0dgkmDekwJT3zP50n9EiuzJJmGxKGjfPD/a3mNVpymTH/OU9HSO2PWQDcNpldwKq5lou67oRhChbvHhMvHVN7vDNjE4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784275623; c=relaxed/simple; bh=t79G/LYMwsAfhRbBxWdx/4uZ2p2LpvRja3Ft/eWpBlw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QDBE2mbn85q34VPoiMmGQo1E061Og6cAscHBP8OTx/HKS0gxT4hv0WsO4d48ScKX7JpdoIUmbODcipYwPsyFzu3faoYA+5ooodRWL+BuQdS4MABEthUdTGs8XAB/PV4Fp3WV5wiwmCJzd1HwmNE5+CwbHL20tdKdnlgeqlEaLIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e5cr6cRz; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e5cr6cRz" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-493ae59eca6so21416555e9.1 for ; Fri, 17 Jul 2026 01:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784275614; x=1784880414; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hku7lsn7Y8coCKFT6sYY6u36fZf6kr/SG26MYxf+TCk=; b=e5cr6cRzz5e4GI/zlKWasQxmrWohH2YvDzAhuA7NCIZt+i2LmOKMF/0ke42iLicACl rY6nOO2dF2K9IVDe/9tHytKkPP+J8H+35Dqtc8xQD/9CE0sQZQL2V/W/dTAlnr6mrw87 dRhK3wzu8mIma4SUoZPzgmDBGrixOfgV/pZPAOokH5ZcmwETbshOodnuggtKhaSIjuLV rW0+SliaExGfe+PVkFAvtt+y6Tj897ef1BvymqyR8PSsMtaUUR9CQgNKZIXFvlTFKIAJ WZnCe7ToWbXQz3++ueYZIBBgkLC5xSkhmbfGCWuteFGIdKDStVqjOfkthJTf2Aox7Vd9 i7xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784275614; x=1784880414; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hku7lsn7Y8coCKFT6sYY6u36fZf6kr/SG26MYxf+TCk=; b=m2tiT/OEMuPuITauJ+DNldZOd+WwHgIscJzjM1UBcRjJDr2d8l1Gvhpi9cy1577Riq edR7LqCzxPzD8ZsxO1mdlkysRujfMQun4DBglyHySQnmxOvSGTCGQfuGtCnfVimeJi0e Nrcr3hUE6YxGFrLm9L/ihYXZVitYBEldjbzvRfXHuquiqooGmxGfkgbQ4wLrBNj0m5XF lE2icEzPd3yhPfIUCsHFlHiz+R3W70Vccv1DJxgvob5TmSWrdueXsf8CSLcPd5rMgcQD EZspj/PkQCMgxefFtH9xn8oCaJbsN1+sATZpVDs5ebdLDO0wGbEde3xcGu+jjH4d0Edo 5ehA== X-Forwarded-Encrypted: i=1; AHgh+RprFM46xtk1pl/H77sfUHx+nrJtDOfhbS6yOJyiWzoXb54P2IgFRF5+kEB0vxJ9BUSz3KOLTObtuDYYorY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywvxenog8RptvpiBYMUU3gKSVortPHG+RP+M9dyWYA8LNGb5PEW yoFzPILj+iVjabKMJ11rCdNN5Vow7s1GJH+Of4PcksRkgm75V7mW0JlQ X-Gm-Gg: AfdE7cke1n/BeW/cIIYQxlbF0CPz20LGiinpvnFdkrVPUFqIsbF/DY7FvXt/0MINKfd m8hq1HxNOwRVOi673j7iOe0z8l9yNb4liEnuHTf+4+K6oj23rWEWvuVtcHLDVivvHrD60StGD6h rWOHo2e1aJ6r9UbMLJFb22KNGMiQT/a6jym1dTWi/qAMirwdN01EhdnpvbCGbKqE7UD+5k3vE6i ttUXmtNaQGtPJykP1QD8FfYyz2XnKwjhRd5bEqCz2ESteRbFz3tWOlGmfBZ09BerN4ArWpqHbSW wwUTyvxqKWV4fkLsle2R+/KgfiXRhw7tZ6Iohbcef80liB8akDnlqV35i5RMcZSMbJP2tXmOGKc GdkecacSev6nrkVXdzUDB7pnTVPJENVtIVxxWeHQQzUgucNpyKgoYKcxlxpHmltoOIuIMMfbl13 ExlO54UThlt1ia9x57O4CSgt0MuqZ52k9U6CX6FqU= X-Received: by 2002:a05:600c:4753:b0:493:bc4b:b8c with SMTP id 5b1f17b1804b1-4954a413024mr16451125e9.38.1784275613708; Fri, 17 Jul 2026 01:06:53 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49549a47e64sm38939555e9.8.2026.07.17.01.06.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 01:06:53 -0700 (PDT) Date: Fri, 17 Jul 2026 09:06:52 +0100 From: David Laight To: wangdich9700@163.com Cc: tiwai@suse.de, broonie@kernel.org, wangdicheng@kylinos.cn, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 4/4] ASoC: tlv320aic32x4: Use div64_ul for division by unsigned long Message-ID: <20260717090652.6fccc633@pumpkin> In-Reply-To: <20260717070252.525545-5-wangdich9700@163.com> References: <20260717070252.525545-1-wangdich9700@163.com> <20260717070252.525545-5-wangdich9700@163.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 17 Jul 2026 15:02:52 +0800 wangdich9700@163.com wrote: > From: wangdicheng > > Fix a compiler warning about do_div() truncating an unsigned long divisor: > > sound/soc/codecs/tlv320aic32x4-clk.c:169:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead. > > do_div() truncates the divisor to 32 bits, but parent_rate is unsigned > long which is 64-bit on 64-bit platforms. Use div64_ul() to correctly > handle the unsigned long divisor across all architectures. And the code has to process the same values on 32bit. So the value must fit in 32bits and do_div() is fine. Doesn't 'fix' anything. David > > Fixes: 514b044cba66 ("ASoC: tlv320aic32x4: Model PLL in CCF") > Cc: > Signed-off-by: wangdicheng > --- > sound/soc/codecs/tlv320aic32x4-clk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/tlv320aic32x4-clk.c b/sound/soc/codecs/tlv320aic32x4-clk.c > index 5c0a76a4a106..9359492051ad 100644 > --- a/sound/soc/codecs/tlv320aic32x4-clk.c > +++ b/sound/soc/codecs/tlv320aic32x4-clk.c > @@ -166,7 +166,7 @@ static int clk_aic32x4_pll_calc_muldiv(struct clk_aic32x4_pll_muldiv *settings, > * math in the kernel. > */ > multiplier = (u64) rate * settings->p * 10000; > - do_div(multiplier, parent_rate); > + multiplier = div64_ul(multiplier, parent_rate); > > /* > * J can't be over 64, so R can scale this.