The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Pan Chuang <panchuang@vivo.com>
To: "Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
	"Li peiyu" <579lpy@gmail.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	linux-iio@vger.kernel.org (open list:TI HDC302X HUMIDITY DRIVER),
	linux-kernel@vger.kernel.org (open list)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 07/13] iio: humidity: Remove redundant dev_err()/dev_err_probe()
Date: Fri, 17 Jul 2026 17:42:30 +0800	[thread overview]
Message-ID: <20260717094408.509583-8-panchuang@vivo.com> (raw)
In-Reply-To: <20260717094408.509583-1-panchuang@vivo.com>

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/iio/humidity/hdc3020.c       | 3 +--
 drivers/iio/humidity/hts221_buffer.c | 5 +----
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/humidity/hdc3020.c b/drivers/iio/humidity/hdc3020.c
index 1ae8702ada54..75971c19624a 100644
--- a/drivers/iio/humidity/hdc3020.c
+++ b/drivers/iio/humidity/hdc3020.c
@@ -843,8 +843,7 @@ static int hdc3020_probe(struct i2c_client *client)
 						IRQF_ONESHOT, "hdc3020",
 						indio_dev);
 		if (ret)
-			return dev_err_probe(&client->dev, ret,
-					     "Failed to request IRQ\n");
+			return ret;
 	}
 
 	ret = devm_iio_device_register(&data->client->dev, indio_dev);
diff --git a/drivers/iio/humidity/hts221_buffer.c b/drivers/iio/humidity/hts221_buffer.c
index 4d03db19063e..df12c7a25b2e 100644
--- a/drivers/iio/humidity/hts221_buffer.c
+++ b/drivers/iio/humidity/hts221_buffer.c
@@ -122,11 +122,8 @@ int hts221_allocate_trigger(struct iio_dev *iio_dev)
 					hts221_trigger_handler_thread,
 					irq_type | IRQF_ONESHOT,
 					hw->name, hw);
-	if (err) {
-		dev_err(hw->dev, "failed to request trigger irq %d\n",
-			hw->irq);
+	if (err)
 		return err;
-	}
 
 	hw->trig = devm_iio_trigger_alloc(hw->dev, "%s-trigger",
 					  iio_dev->name);
-- 
2.34.1


  parent reply	other threads:[~2026-07-17  9:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17  9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17  9:42 ` [PATCH 01/13] iio: accel: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 23:21   ` Jonathan Cameron
2026-07-18  6:30     ` Andy Shevchenko
2026-07-17  9:42 ` [PATCH 02/13] iio: addac: Remove redundant dev_err_probe() Pan Chuang
2026-07-17  9:42 ` [PATCH 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 22:05   ` Maxwell Doose
2026-07-17 23:24     ` Jonathan Cameron
2026-07-18  9:11       ` Maxwell Doose
2026-07-20  7:45         ` Pan Chuang
2026-07-18  6:28     ` Andy Shevchenko
2026-07-17  9:42 ` [PATCH 04/13] iio: common: Remove redundant dev_err() Pan Chuang
2026-07-17 23:26   ` Jonathan Cameron
2026-07-18  6:35     ` Andy Shevchenko
2026-07-17  9:42 ` [PATCH 05/13] iio: gyro: Remove redundant dev_err_probe() Pan Chuang
2026-07-17  9:42 ` [PATCH 06/13] iio: health: Remove redundant dev_err() Pan Chuang
2026-07-17  9:42 ` Pan Chuang [this message]
2026-07-17  9:42 ` [PATCH 08/13] iio: imu: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17  9:42 ` [PATCH 09/13] iio: magnetometer: Remove redundant dev_err() Pan Chuang
2026-07-17  9:42 ` [PATCH 10/13] iio: pressure: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17  9:42 ` [PATCH 11/13] iio: proximity: " Pan Chuang
2026-07-17  9:42 ` [PATCH 12/13] iio: light: " Pan Chuang
2026-07-17  9:42 ` [PATCH 13/13] iio: temperature: " Pan Chuang
2026-07-17 10:30 ` [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260717094408.509583-8-panchuang@vivo.com \
    --to=panchuang@vivo.com \
    --cc=579lpy@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox