From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70EB83914FF for ; Fri, 17 Jul 2026 20:19:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784319583; cv=none; b=I+LLSc9biTuVOBppbTOCWfFa5Vwi6L5mumxthZx/KaHHg/17929kipVJ+8eO3b3AL+cdidMV5nBpMZyRyN7+LPjnvHDZac3Lzyo1e3E9hIavEBSDIoOylXKKQuD8hHy7uonD2eG3AiWG/AeNcZGReWYRse9JCqcN5G1nMhtyeC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784319583; c=relaxed/simple; bh=PbNViWUgj3WBUCT3/UpmOD/6P42BeZf6CSc/xOU4GB4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Vwl6SjzYy9pAJsc2oHFOpt7YVeUVHCEwiTWIStswLH0CrPvXDMhpPNSP70JFEke7C2fSdq6t/m0fNtRNXPjGyUT/45uuGiGknC31JtCjTp0r3lwDO3m4i9Z6F3AQtklSS9SqysHTzJ56+em5fDwteNd+swuZUtmh7UROIbCsoS8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=nxDCdeL7; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="nxDCdeL7" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-92f0b5ed131so447685685a.3 for ; Fri, 17 Jul 2026 13:19:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1784319579; x=1784924379; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=M2hbpzf52w+esSVkF8QFMW+oo8Oyq13jDlcvDql6gbs=; b=nxDCdeL7I7YfexVFnMm/ygiGxhax4KwIP07v1eSNxhQ9V87DIaidreAITQGVEv+1cf QeIxWppl+iQPMLfI22sc38VcegAWgvY40n45JfMm9AiUBh7EQ8n3pNA/S+Y7ZHs8cbLP UXJtfxomJUJzzMG4R2OtaMkETa4A5DKpXHAG4SsAZ3BbCkCt3KmxkLAY1FzhbPHy5wj5 2jtmN3uQ6UZPtTS089gq8dyp2mM1XTi3cXQLvkskJWnsNcdhdirz/PkZ84pW55tbcbZQ Q1w+t/4dBcNGUhwzFMbV8iPZI6HpiLZMF5Gix1+a0MJ/hQg0t97Gh5XzKEzXPsfnldQ4 17qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784319579; x=1784924379; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=M2hbpzf52w+esSVkF8QFMW+oo8Oyq13jDlcvDql6gbs=; b=N92gvB65+Mbr2Oq4tr/WBRhzb2Jnk2AK3kXe/tDftR+wA1vUI35fya8ozekxUnCJve JiWkPnqi5eaBSg4PA2Z37rw6N83QIIV8mfM9RQnMJL0UQjtKrtcQuyHnKR2u7GIrxDiY 5qB5Am97K5kB9OwEf3BnieB1iCX83CwhrlH2DtrAaqFGrsejbOZDZ6W/1WPQA22QoBPG HbIhtAVzgAwyYX2aouhbSyn4M3s9k8j/5T0QT0oKKihyUd+Szwa6/Pb42m5bkg9aD2R/ rRSu+HjRhUOIuUfPR2LcoU/5dflXYfABnhOF0ZBJ3YKAcQlih2IT4qeinLjt5H6n3zNB Ck6w== X-Forwarded-Encrypted: i=1; AHgh+RqUBTF6uH1dqAArhu9L4WWAByeeNj3l4GK6yC61lNqPXxZq2EQ4NxsBSLMd3RlXUjaJyQJ50yy29nucpfM=@vger.kernel.org X-Gm-Message-State: AOJu0Yyx8Yxdp1giDkurVQ9sjP4sfJa+92sXnTRg9QacktrVcMntWYbO 3J8EGJSzVBgKZ7oVD7rKJsnIwKY2qg/AHX63GzKPG6mOxxVBIsPjzD2cuJ83/qTu7Fg= X-Gm-Gg: AfdE7cn14qB+1RCOSCcXsL+TYpOsJNdKP8zBCCBPQiYgZPU/ujCmCeqgvlzRwzIq3to 3qrDa6zbhTPxlldrxklhFSn3e+ThksfQGlHwUc2FuBuXBQDLSTYtm+QZlMNny09eVGNObp2m5nx L+BCJccJ9rFfjldwKWxDRKy1iuE6M9Y1ZYnDh84Tr2+aQtp9xftIy1LGQhxFH0ca79gRrtGaQ1E AOisrFIX5CsFH5MtmAa9ADySLcXfkiniVEyW84jORxKF24n/oJNY8BfdAlZQwPh5S87zvbqtEt8 u5cu8WMVIGtsKgcq6ewbI47v8C1tWYsCx/BdKvUWhiJ4PxiJwSs4EcNfe/4q4YXwilvSaUjEvu+ hWbN/jMUxi0BfzZI3ldGqjx+4JcnTqNxYAtIo/a3FxwLEryJPfg== X-Received: by 2002:a05:620a:4588:b0:92e:e2a4:9d40 with SMTP id af79cd13be357-930b3f4547cmr452740585a.27.1784319578518; Fri, 17 Jul 2026 13:19:38 -0700 (PDT) Received: from ziepe.ca ([159.2.72.92]) by smtp.gmail.com with ESMTPSA id af79cd13be357-930b542b300sm245589785a.26.2026.07.17.13.19.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 13:19:37 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wkp20-000000052xd-3lLn; Fri, 17 Jul 2026 17:19:36 -0300 Date: Fri, 17 Jul 2026 17:19:36 -0300 From: Jason Gunthorpe To: Ashish Mhetre Cc: catalin.marinas@arm.com, will@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, robin.murphy@arm.com, joro@8bytes.org, nicolinc@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH v7 3/3] iommu/arm-smmu-v3: Enable CFGI/TLBI-repeat workaround on Tegra264 Message-ID: <20260717201936.GD701389@ziepe.ca> References: <20260714104202.1664187-1-amhetre@nvidia.com> <20260714104202.1664187-4-amhetre@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260714104202.1664187-4-amhetre@nvidia.com> On Tue, Jul 14, 2026 at 10:42:02AM +0000, Ashish Mhetre wrote: > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -5357,8 +5357,10 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev, > if (of_dma_is_coherent(dev->of_node)) > smmu->features |= ARM_SMMU_FEAT_COHERENCY; > > - if (of_device_is_compatible(dev->of_node, "nvidia,tegra264-smmu")) > + if (of_device_is_compatible(dev->of_node, "nvidia,tegra264-smmu")) { > tegra_cmdqv_dt_probe(dev->of_node, smmu); > + static_branch_enable(&arm_smmu_erratum_repeat_tlbi_cfgi_key); > + } It is a bit of a big hammer to not have the per-instance FEAT but it probably doesn't matter Reviewed-by: Jason Gunthorpe Jason