From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FC2A27FB1C for ; Sat, 18 Jul 2026 22:19:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784413200; cv=none; b=XRtacGb35Mv7s18+W/6Cofq4+NvQY6UBV6jQxS5WHoh4/jeAnHgpM/so4WgRDaqRSyhKMXsCGth5CNLFl+nsnptpqmYQzM4uJm5s+imJoZ/V3Ekf503W3kyo0GQ31pRCKYf4mX/YgzStzQAMP4rudVvmQ57j9SOqhyIOVv98brw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784413200; c=relaxed/simple; bh=uBQ8XlnqOMtNKgZqtoqvdpfI4CIFQ2BHelfCbW+fGw0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TxFCMxJyEk7GKO3gddwkpOgYuefggCqvBO+BMM+sJU69Ri0aerAvWVtWwcLf9pCmjGn+5R4WhW2RDG9eBIpQWi3ZnUDc8NXaI4cAhsR+NT6gDqR5r04pE9dH7mWA04ZX9olwsCH1hsD4LvymdhwyFHj13aacQoij4ZVcOL/xr2o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IHKXe/yR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DbgUTvSX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IHKXe/yR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DbgUTvSX" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66IJpg7I1517889 for ; Sat, 18 Jul 2026 22:19:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OSIoHX29BzBjnIxq4ol7lBXbSbHoZ60LqztgJWDtdzA=; b=IHKXe/yRaHMq1eKf iUOY+J0bLWQGmFRD4VkHY1ft2Y2SMgFE7ONLhZOq0WJMCvWPcCHEuFXxqkjARsTs 8sqP9K52dEGalJvRHOo/+q8KBcaDZezZMzY6P2A+gd6jMQEV4g2L4w5apQ/NpLrt 1LUWoSYJlrTZXgUHebAyo85ueTRmN3G+zSOYN9Ak8zl+XJKOQB2BbTJy1e9eOMpW oqhd3BUN2Y7JFZ6N48T50lz29sJj1VJtmtpeVgOwJSOo0gXRD7cyg5tUKDUAXGRo B7VDSurJIbiAP9SDwBT6LZQj6zuruXAmO7KfPd5qUgjQcPcSPWLSTFvVXk+L+lDN Ulydog== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fg2bnhn4k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 18 Jul 2026 22:19:57 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38e7131849bso120485a91.1 for ; Sat, 18 Jul 2026 15:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784413196; x=1785017996; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=OSIoHX29BzBjnIxq4ol7lBXbSbHoZ60LqztgJWDtdzA=; b=DbgUTvSXMGrUqBw4szZ64Gj33aUwlMsxfMdbcQHKHwdgsv/ugyew0nWOv0geRN9zG0 kNth8PTc4udeH70DE7M2aNCV4URAsRZa7KIx40vEe/4y4iwuwaGy941TiEVbU3g01wjL vpGCssscxWYK3n7toF0NRd68+hPOJUi/ev+soBBJd51NJpS6dv31NU2UuCszL2vhn7e1 kWBiihM0Sy5YFtwo/z5pC+dYGa46WxnSGfLz9f9yxhuJv4r6njum++CYinLfFHau5qbp KH3hzrlWYDidOO7RHnmee3Ux25CcbjhBGB43E1cTAYXV/8ZOM/NN1SLbMYKZmv6FQ5Lg g7zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784413196; x=1785017996; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OSIoHX29BzBjnIxq4ol7lBXbSbHoZ60LqztgJWDtdzA=; b=XLlH/1vVfx38zBLZ7ZYBYxVdm8vZc9CD+NDTFZHoPkAAF4hFwhjDmzQaG9CY/qx0ZC S9pWYcJ2OssVEQg3FgA3QrJnCwNYfkbMPOriSqVOncoT6Orrx1GKOmSuvo/vaVYc3xVJ 3RfYLd78Toxlknjr62VTyIOsoTHYHLoVtwlxa/7PnILCoCjote8vhQV+I3AvXsBY+hTt fJcwmcDf66IgRhnN3VNo4p2pKOAKm/A2jVNlN8a6bazYeBys4KvtWsV/zDoGsRvaNbQU i6oO/JoFvBRR+78QYJuIIFgvWOR0Mt5FaEyJaCjJ9l9jylZX4Caw67AgZriwAoLznonn XnDg== X-Forwarded-Encrypted: i=1; AHgh+RrlMN2tVR89RSyVs0J/QKSiy5VY73dP2PGUHq3BdZZWDYeHx5xLnJTe3dVAi2IAdn27JY221J6OFPx/AP4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1joMQ2LvryedFFXaP08OQZHElNhM4nfySaVPotFb9aQ+yuDap b8TZfJe3de/NRDEeF8monzr/VjCQomUSFlJIjwFFdMRbOtTukLur2lLEFreEsnpw7we76ouoSHB u7NCoxCzWdiaWWJUf9gp/cNbeVWanPT/av+QtGEj2xq+IRNxuVDLigECaIGZNJfRVnx4= X-Gm-Gg: AfdE7ckMQAJAmwrdPXtZjAQG3t9DleFgl9whasPcKj5Lh+3bHuK7Kxvg3fpIdRFo48w Qu1jKjjgkQWZn0de6UBpr6yAoEDW1hxUH9AEMbJg9wl2BkZULazzAKip3+jMzlNl8UQIvSkE9qi mr9UnK5BsE48NJYhweQeJ7zz9uuvdMqanaxEYQtAXKduVObsB6T+SliSBOva8NwzDTMva+kjTzU IUdi09NghApeAd+gGcLsZbY7/yzmZzNfzuBdZnaLxk6F9i7ylwj60aNU8I0U6D94+mHEciyJ6BY L8xLhez8W1+cAQbL4vOYtnOJ+j/PcQ/TKWfB8YEeMhTyO7rxAxd92qrFmjHQiARl2NKOgx3eZrx PGSs2YLElzc/vQzFd X-Received: by 2002:a17:90b:58ee:b0:37f:9ce0:af32 with SMTP id 98e67ed59e1d1-38e4b595a3dmr8487149a91.29.1784413196364; Sat, 18 Jul 2026 15:19:56 -0700 (PDT) X-Received: by 2002:a17:90b:58ee:b0:37f:9ce0:af32 with SMTP id 98e67ed59e1d1-38e4b595a3dmr8487134a91.29.1784413195919; Sat, 18 Jul 2026 15:19:55 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e39de785dsm5062346a91.4.2026.07.18.15.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 15:19:54 -0700 (PDT) Date: Sat, 18 Jul 2026 23:19:49 +0100 From: Jonathan Cameron To: Md Shofiqul Islam Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andriy.shevchenko@intel.com, u.kleine-koenig@baylibre.com, joshua.crofts1@gmail.com, nuno.sa@analog.com, Michael.Hennerich@analog.com, dlechner@baylibre.com, linux@analog.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 1/2] dt-bindings: iio: health: add adi,max86150 Message-ID: <20260718231938.54f41543@jic23-huawei> In-Reply-To: <20260717201138.1078019-2-shofiqtest@gmail.com> References: <20260717201138.1078019-1-shofiqtest@gmail.com> <20260717201138.1078019-2-shofiqtest@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: USZ3f85Zabkm3RyYQkXFMcsg1POLs5lW X-Proofpoint-ORIG-GUID: USZ3f85Zabkm3RyYQkXFMcsg1POLs5lW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE4MDIzNCBTYWx0ZWRfX0wshPCCOQw49 5+eJ9yGDEFC56vdcfiyiK75cLBNCtkG9f8zobkOQfIdkwyL6qsoFQNgKePy3BePPBQro5I5r2kQ hDBfVGD0l7q6/3QewwZ90nKtrnTUCkR5CwkFl3Gq+B5YPJiDtOWrw492k6OogE9564mmPali832 ze3al4pKJO1YO6GhQzOD065icOc4Oud8BXANBAKhl3UiDe9KEat2BNdZfh0B1pTS/k8PyeKcP8e aIox9ZRazif67ySknCDfNzpy9HbagmzE/r2CpJ+VXx185c7OKrbqmk9jhDj0zuZcGAsQyQdGb7k TtStHVSZjNdwVaWEV1zK553NeclmHbifle/yhMaC68CEXUQdOnJQ5FTTmej2O4AV6YyVlpv9VKn WUM8VFg3KZ5C5AdeHKjFEkZ7zGJfJcaJHRw3uyUlRVBXv43fcA+/jDlEu2wep21GKOpfY4Kn3Qc rMnwO6G1DnN4ak2CeSA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE4MDIzNCBTYWx0ZWRfXwveBWiMSH7Qm QgSszJjc7HC9bpJn9gF/xNtUtpqRqrpxYaTNfhDea92zTcU2iyEbtqO1rYtoXRTkZ5mOJGMS4jR gV2fm617YlqDTWFQR2tryDGCo4vFPbY= X-Authority-Analysis: v=2.4 cv=YsQ/gYYX c=1 sm=1 tr=0 ts=6a5bfc0d cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=gEfo2CItAAAA:8 a=gAnH3GRIAAAA:8 a=pGLkceISAAAA:8 a=KgpIswxficZqQvW3BnAA:9 a=CjuIK1q_8ugA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-18_06,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 spamscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607180234 On Fri, 17 Jul 2026 23:11:36 +0300 Md Shofiqul Islam wrote: > Add the Device Tree binding schema for the Analog Devices MAX86150 > integrated biosensor, which combines two photoplethysmography (PPG) > channels (Red LED and IR LED) and one electrocardiogram (ECG) channel > in a single I2C device. Samples are buffered in a 32-entry hardware > FIFO with a configurable almost-full interrupt. > > The device requires four independent supply rails per the datasheet > power tree: digital core (vdd), analog core (avdd), ECG reference > (vref), and LED anode (leds). > > Assisted-by: Claude:claude-sonnet-5 > Signed-off-by: Md Shofiqul Islam A few small things inline from a fresh look. Thanks, Jonathan > --- > .../bindings/iio/health/adi,max86150.yaml | 78 +++++++++++++++++++ > MAINTAINERS | 6 ++ > 2 files changed, 84 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/health/adi,max86150.yaml > > diff --git a/Documentation/devicetree/bindings/iio/health/adi,max86150.yaml b/Documentation/devicetree/bindings/iio/health/adi,max86150.yaml > new file mode 100644 > index 0000000000000..da2ff9b0ada2b > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/health/adi,max86150.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/health/adi,max86150.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices MAX86150 ECG and PPG Biosensor > + > +maintainers: > + - Md Shofiqul Islam > + > +description: | > + The MAX86150 is an integrated biosensor SoC that combines: > + - Two PPG (photoplethysmography) channels: Red LED and IR LED, > + for heart rate and blood-oxygen saturation (SpO2) measurement. > + - One ECG (electrocardiogram) channel for biopotential recording. > + > + The device communicates over I2C at up to 400 kHz and raises an > + active-low interrupt when the 32-entry hardware FIFO reaches its > + configurable almost-full threshold. For this the 32-entry fifo bit is good but maybe move ti to the interrupt description. The rest of this paragraph is a repeat of detail below where it is more useful. Hence I would drop it. > + > + Datasheet: > + https://www.analog.com/media/en/technical-documentation/data-sheets/MAX86150.pdf > + > +properties: > + compatible: > + const: adi,max86150 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + description: | Formatting not needed so drop the | > + Active-low interrupt line. Asserted when the FIFO almost-full > + threshold is reached or when a new PPG sample is ready.