From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7751E37883C for ; Sat, 18 Jul 2026 23:36:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784417764; cv=none; b=A78U9aaM/zzuMPj2Pc4a5LNIkcIhODeGsOg+DvLyAy8/vzZfrlWfT1jQG3C6729r54Q2x9bSA5mSLCeDGhMuFw4DTTKucr56yo+SghmfDGTwYON1pOuPEf3gtMG/Wk+cRqoi1izhoyFTFa7a/YDMadank7BqyAGuURVFjxoeMZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784417764; c=relaxed/simple; bh=/ymnttl7oB89lytF5t8kzEi7A56W5KOk4Klf25QHF00=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oJlPSarnZEXGW5/iJSbmkC9NZ2Ni9HcnEVQsz/edbRevDOv4iUFpkRYEJcCcLPxIEb6WENV77AkCLWUlQ8tEuM+J7NOW9pdb4UOsgTG88OIQeSzRm4Z9XYJeFbPTGJQxs5tl5ECgLYac+wQlhhNDwdr/PyOnOky3i29kFOeeL8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DvDhn5JD; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DvDhn5JD" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-47c2b362ee2so7853085f8f.1 for ; Sat, 18 Jul 2026 16:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784417761; x=1785022561; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qVQM0So1MCL7ilj5LYZg6mzfa82XvkJyQz/kOpkAFIY=; b=DvDhn5JDkdXyNJ5ZgSx9AlEXMAQx1WXI6Tv80KNd5mTCAiRnoBMB5KfWVxR2crGT37 sIni4pkG6g0qGE0IqvsXDN+WtulNk9Pxufaw11gHo0Bmej9RhYjkPAB82y3Al32tRCMn x7wKjVvHmvm9Dq8ckqllj4DzZR+wNeAbUbiGwH7hrY2L36EKDolryfQo9TPAeIDPdSUF TyzQ53c6OeGoNZy0TYcYUks8rfSBlHAo5KBO9x04/tslRVCET9eq6giVs4av6l9cafw7 VtRPJYv6wNT+QD01uc5osY8ywRZzBUq9fbbB0q4xUhABvY4ZJuBKgr/Mc3lCMZyoy57X 7Wbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784417761; x=1785022561; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qVQM0So1MCL7ilj5LYZg6mzfa82XvkJyQz/kOpkAFIY=; b=FJW2CC5Knw73M85qsWp3lRaRG6HcD6P3byONsqdgjss5bZN6gcsjCRDBRcERZzR541 hvB0itflCp98x1zXmrWr/gIrPWOdnHIraD2fSgR+jjhkc+dT+XeDUnBGBD+iZLsfBnBI WzCIkr19neX3oymxLlRNPqYUCobKTdoCHGIiHxCInJIriBeygniilDjT2csxElvU/fIi 6ZaVbevGTx3MeHf7RivxhfI/VLa0MNiROf07mawdVDsPGXNVzjae7VQSlPc9GeSiiRfs u2PgoeGbDxDmMAHFNy6mcDCDan7kK/sSfOnfGj39eqTBA2/4Rqody1IjgvNLpI8wjeeJ mrDQ== X-Forwarded-Encrypted: i=1; AHgh+RrKFVPTpgZ3X7yCadC4amiJrXGR36Z86vpSalrOqaOAq/GHPtzGptnaQ4P/jC6YH3MbNIaJupEzSkVdGKc=@vger.kernel.org X-Gm-Message-State: AOJu0Yyo9LUlJIwnrutRcMwOsahxXeKE0Zlhxl9wOuDWzw5vJSQtSLg4 rrMCdOaFNK4VQ8uKzhFEg5/Ev+aXKZL5KnQSLSy7j5MQIq6wTuwkI7vI X-Gm-Gg: AfdE7ckHiGOW6YnhZUufmHuuvZw7kNlRArTZnMT2EDNaTiCCyQsw8xU/8nrCTDQtRi+ DyIi7JWF+c290YC6NJScN42nAAcfwas6oxXwaOEfqST1qovjNi7Ko86djp3CVUB9TbGSp5J30ql b/cGApSGuz0nhRCpo1nXOzAsy0EAxJ1D7mXUFN1j2DAi4jrJ1TnnHCyT1WTnMVAZ54vkJiRNisJ IpbzyPhnRB7F81lw0PWN9/kjM8wBkOwcaiuIhuy+dqru/9INivNWXWWHoLyNgUkzIKfLJwB1Qzm 0JOQ0yy5mcfjPXCDchPAtnpmynPNtzJoUuXDM3gyCnpCVZFnJseE7C/TBn8pMipsDBaHkAStP6V lzIHfdKlJ5O+uD5bPZAwNsLZ6scixyIVN0iFORiAuRL8yo/aIwQsU+tH1XeH33oBIjjHnEVtEGp 5haSO4yOsf3g== X-Received: by 2002:a05:600c:4e94:b0:495:571e:e5d3 with SMTP id 5b1f17b1804b1-495571ee75fmr14134205e9.36.1784417760679; Sat, 18 Jul 2026 16:36:00 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:645b:9e5c:7fe3:c09f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2a24b6sm160964675e9.3.2026.07.18.16.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 16:36:00 -0700 (PDT) From: Diogo Silva Date: Sun, 19 Jul 2026 01:35:32 +0200 Subject: [PATCH 01/15] drm/exynos: remove dependency on DRM simple helpers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260719-drm_simple_encoder_init-v1-1-a78c509e3062@gmail.com> References: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> In-Reply-To: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/exynos/exynos_dp.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 14 ++++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 11 +++++++++-- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 14 ++++++++++++-- drivers/gpu/drm/exynos/exynos_hdmi.c | 15 +++++++++++++-- 5 files changed, 57 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c index b80540328150..1598892c602b 100644 --- a/drivers/gpu/drm/exynos/exynos_dp.c +++ b/drivers/gpu/drm/exynos/exynos_dp.c @@ -24,11 +24,11 @@ #include #include #include +#include #include #include #include #include -#include #include #include "exynos_drm_crtc.h" @@ -79,6 +79,10 @@ static void exynos_dp_nop(struct drm_encoder *encoder) /* do nothing */ } +static const struct drm_encoder_funcs exynos_dp_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs exynos_dp_encoder_helper_funcs = { .mode_set = exynos_dp_mode_set, .enable = exynos_dp_nop, @@ -95,7 +99,12 @@ static int exynos_dp_bind(struct device *dev, struct device *master, void *data) dp->drm_dev = drm_dev; - drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS); + ret = drm_encoder_init(drm_dev, encoder, &exynos_dp_encoder_funcs, + DRM_MODE_ENCODER_TMDS, NULL); + if (ret) { + dev_err(dp->dev, "Failed to initialize encoder\n"); + return ret; + } drm_encoder_helper_add(encoder, &exynos_dp_encoder_helper_funcs); diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c index 0dc36df6ada3..4e42a1da81d1 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c @@ -12,10 +12,10 @@ #include #include +#include #include #include #include -#include #include