From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA1EE379C35 for ; Sat, 18 Jul 2026 23:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784417790; cv=none; b=h1RI8CKKleFktwjJ2pltD2IlzFdeXikUmiNW6PeYphUvq1RIwnsjh+rnCCxOaI0EN9Odq2pi0V5PNIz/JY0dYPtN0sZPB6WSp9U5E/heZ2rKdB+nrO/5PlQkae4gW/unJ36/okbyrx1WPW9RSUfSWbIGI3mrtOSCG9aZ2M2G9Z8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784417790; c=relaxed/simple; bh=BI9R2SvxdH2gwqK0B92kFqt0y5mZiDZk7s7kVtduUr4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=U6jgPDY+QNaxqbBENcqsMKG7kYzXuuLlhWhiJ8cElSXueYQ88tvcbWWcLEpeI85LhFf1/MrZBJapEivQa4afPc+KUVEMH/+wihQNQfGy76X01/JqsQxonOo02xu4/nfBNxnrDLsRMIUtmhBnLYo0wYxm8XJIlIk2znJcmjQGfl8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FxgDemHd; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FxgDemHd" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-495590dde14so1121965e9.0 for ; Sat, 18 Jul 2026 16:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784417787; x=1785022587; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3qoMRiXvV6BHSei+lkJBYDW1cqZXXpht0BCmlOitIE4=; b=FxgDemHdYPBSdjRAr29JlhnFVw0SxTQRYEm6Bm2Gq9gYuwyIukjW/2myzjgq9QUP8/ pO+pijVqCOCwRDLUeCj1zp++bTgtjNyw60Vq7118qR6XGCztOHcY/VNeBHm8QsJYHHQg rq4+ZLQVpDeAtU5T+dPDTRkxXlUFWKyhGxR/X+vvr6UO3d5cVOIJrOl4l0NZLEzSLlho GJk5IjyPnDTmHYxFtsGGotNyekYeA1RxKB4Z5twNIdPLaAeqOBopBVn7rX6VzDF8tqUD Lrs9QAsDfJwyvPyhsB2oO1zQjQNDSpzEutcbKpvnAbvQ4CHqyGFqKXK/qsYRbd/ooP1l F05w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784417787; x=1785022587; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3qoMRiXvV6BHSei+lkJBYDW1cqZXXpht0BCmlOitIE4=; b=IS3xLAt/nONyrRbycM2/vEUHQdrG0j+r/Cwj+S07Q6JBRHmrobroXqhH3CDdgXKn+0 Bco92MLuCTcyGd3HvPSBS18dE1u31dyNO/yMygdiqW4iCwCMTiPMu4y5dlYCdqgrn23m ff82RqT+6ZphtPm69MV3cGmBvFjHVDMmr7UkOCfK7zXRrk46z0GBlf6GvxKsJ0yv3d+P oVcSqNHpo1ZO4HKCg9ERD/3KsgPuWe/zMjykaEx9fqJUHQEQuKzYjJYaNGUDtv4ICEAB y23RmLB23MahS0ceZkdCmA/y17Rctg3b2MFyywEi5n2bSpWMys53D5P9sNe4IVp/ufm3 sFGA== X-Forwarded-Encrypted: i=1; AHgh+Rql6KZEVALzFNmnYo6RuZ0r3P19O++kH7FivphbLjxd/8SUlLGG6z8p1cSqO6ieNEWMFQoz0HogjFZP0t8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2MbvX2FsaUY3uZhI/J/L2esV9toJt97e0zzqGDPSxumlmfBsZ pQCG4Eo9eiLKz0rmpCq+arW8+0obI5NsI6YzoJ6+IdW9TuQL69Bsh9dc X-Gm-Gg: AfdE7ck4jlPT30ZlrNJEAuRElbicigqVdL66mOZjde0krCZELqL3xhJzeXulT/rS4WF BY+ftwm/UcIRIhl8fBWE005ABIO+ZygGWDdfV6HLKI4hIFfWXDbr0ZjIPZGk4CDk2Zu0SP/QlUC K/A18wj1G/q1WSYj0Bjg50khjPaCzvmD4JVoaR6umsuH3Rt/JlJVlKHKW9f2gXxESrpKO6KHrMZ 3AlcWNLDDliPlgPgPj+9cpeg/9pHGk9MReJrvRo2oaRJKiq5XoNK4PKgPMx7f9/GT0pjVAdAXSe JltoLrkW/QnlIQrYSxDAyGH5rfANLLJrLhqzi5phaHB3yf09r+ZFOM1/rM+XEdxDvpE02ZthVZx g4AdJ5a5BiZlnV/v4CS82A5OELofmGoutpKRDEPY4/qhs9Tad1zHNfXTwFJltYnnhHQEYKga75W fvAh9EvmUx3Qw7EapZbZ8X X-Received: by 2002:a05:600c:a42:b0:493:e983:806e with SMTP id 5b1f17b1804b1-4954a3ee98emr95800615e9.3.1784417786829; Sat, 18 Jul 2026 16:36:26 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:645b:9e5c:7fe3:c09f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2a24b6sm160964675e9.3.2026.07.18.16.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 16:36:26 -0700 (PDT) From: Diogo Silva Date: Sun, 19 Jul 2026 01:35:39 +0200 Subject: [PATCH 08/15] drm/imx: remove dependency on DRM simple helpers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260719-drm_simple_encoder_init-v1-8-a78c509e3062@gmail.com> References: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> In-Reply-To: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Signed-off-by: Diogo Silva --- drivers/gpu/drm/imx/dc/dc-kms.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imx/dc/dc-kms.c b/drivers/gpu/drm/imx/dc/dc-kms.c index 0f8cfaf4c4d1..a9adcfc68b84 100644 --- a/drivers/gpu/drm/imx/dc/dc-kms.c +++ b/drivers/gpu/drm/imx/dc/dc-kms.c @@ -17,7 +17,6 @@ #include #include #include -#include #include #include "dc-de.h" @@ -30,6 +29,10 @@ static const struct drm_mode_config_funcs dc_drm_mode_config_funcs = { .atomic_commit = drm_atomic_helper_commit, }; +static const struct drm_encoder_funcs dc_kms_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static int dc_kms_init_encoder_per_crtc(struct dc_drm_device *dc_drm, int crtc_index) { @@ -55,7 +58,8 @@ static int dc_kms_init_encoder_per_crtc(struct dc_drm_device *dc_drm, } encoder = &dc_drm->encoder[crtc_index]; - ret = drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_NONE); + ret = drm_encoder_init(drm, encoder, &dc_kms_encoder_funcs, + DRM_MODE_ENCODER_NONE, NULL); if (ret) { dev_err(dev, "failed to initialize encoder for CRTC%u: %d\n", crtc->index, ret); -- 2.54.0