From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D19E73BB48 for ; Sun, 19 Jul 2026 12:56:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784465786; cv=none; b=BhB13EEw1LN8hFWtYOLjsdrRwiVRvcs3obTxBkOub3vxZ7p8MavrQhY4cOz25EnA4iaUuWaWkKUbEErRbqRVvJ7RGkuKkD63sOMJC+2+N/72BAVejI2j6MbioSzT3JZXKjL0Q9G4QuurZM0gdR14k80M3PAZ/ij9oB9fTP9ZluU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784465786; c=relaxed/simple; bh=5zvKnd0JD5ih/+cLM7K1dUL0S6yC1cEB7EpZtuHweFE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qLbiVH0HSMhG69GtcIEMXi+dkWDKNeOsfk94pnI7NUiJJmfQ+Li0ONqHjWsiYdBgkxdJnPBwmay6xGsGM88Bt3zS6FuD0XGqjJ/fegpJqsQNRbDHmiXj8Ri8q3eNFPud0Qw/ILRu2neG/pwm/v99cRIE4wynN0K0F3JZz1FZlfw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jztYGRF8; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jztYGRF8" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-38e3efab7e0so2087314a91.0 for ; Sun, 19 Jul 2026 05:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784465783; x=1785070583; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PaeHrzDwq749xNqEBv7Hp6+uBqLf+sS5NmRKMPCInEA=; b=jztYGRF8x/pCoppTkp/2pgMTocATSWQQ+qA3aIDJYhIID8e/k6zCtz1N/JaY38mtiq oZlHqTns/A05IXOOHW9Qfvc9fyppJoISOEVeIxNMpTdMUEXD2upXwrUl6+4/iR8gDahZ xrlTYoXpxyqo2XmcG2FNQ5o+OuaaR8izR29o3KVJG5xQe1GS8iab4YfwAu3+wrzaKn4k 3WNDwtLe2BJJv4FO21Gjtd6RJcoAUX+WMRfuCHStGTfqVI91KsqXjSSBjKfugWtbZ4dL nCvAQYGKxI4P+XpL3+zx3c5StLzJGRWzSF+UFNKWVcL9d+ADCJ57gASkmhtnko6Ev/jJ oo0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784465783; x=1785070583; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PaeHrzDwq749xNqEBv7Hp6+uBqLf+sS5NmRKMPCInEA=; b=kcXGmbKq26zYN3h5CI9EJXf/n2Y7NFYPNutUTZP9k+xQQh1xP1TOc7vh+/18DIWBPC yQPORxc7vui8KMdHyMwqsH6dL6nu8Z7xcei3eDG7FZu3v66uftKSPslFY1xi2S6Oo5VF 4oA6wrGg/r9WMflOfxT4vqj26kQepWCUhBQs8LMKTR0PQT1yY8gg4ZmiYipxuCvspMau 1fsOlaxGtALitCtkTC3MofUiXKm0y+LmlEtZl7fmqcJaxfsH+eZoTQW/YeUCKxah8OmH SNsP3zfxbaI3OlcEdfN4OdBL3xrS6h8BEpDKpi7yQIK21R82ySjNJnp7WFW78970lDyj wDNQ== X-Forwarded-Encrypted: i=1; AHgh+RoYZW4IoAECwgnbkELTQxRiv2GScU6mFcdwZGc09aVqmqnv3xWgjY3Z5xrLWa7YSIBSlpDMXH+CijLzDbs=@vger.kernel.org X-Gm-Message-State: AOJu0YxFlzKTns2HvvZGMsNBgU6tiUjO7of8UZupEhKI/f05FqypyFv0 zUibj8/u0ngwipkhst8ZeFz8OdUOsSC2U3MCPg4KQtvcyt7R9sl8FBhB X-Gm-Gg: AfdE7ckJn4kpxglaXs9AYSbsWwonk8tOE/cFSbOvGoRKPc1UMEvStAUHwz8oaXMa+tp 89PrNK0a9unUtJT7A/7oI2uxpreTx4eUcLf4sKrg0IWT82O4MnpCzJBms/khxOmCQvhgGN/UXhn OYqx6y7yDUHw++4ikIF3xfJoLEoZ7qRN4/uKDxjYezAemOuk/3yaNgio2vDKFWlO9LPBWHQEupt TftHMZ9pxInSJoz+qlrN6u3bOmJDACpH8Vov3dl0uNK3hGoKafZP1iSSfC8JgN5Bt4vuPyE3EKt mR9QFyRhYwTZM4dktSmAhUFMClBVrgSBV85/2fH25ThPXkdZOvDtX67PCzoiSa1agoz5YOgf9/7 LgE3MEAHBM4SKTtyBfVxKULhsQgs0oPtYE+/5XnibczsyiEWhOkJV1exuPoLMkziWYmiMOLYNk5 4d97Nzrmj+1Bctww== X-Received: by 2002:a17:90b:1fc3:b0:387:d9cc:7dc3 with SMTP id 98e67ed59e1d1-38e3d2b11dfmr16744203a91.21.1784465783164; Sun, 19 Jul 2026 05:56:23 -0700 (PDT) Received: from [127.0.1.1] ([2404:f801:8028:1:edd:423c:25d9:f95a]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ce2cbb6e8sm20990052c88.9.2026.07.19.05.56.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 05:56:22 -0700 (PDT) From: Subasri S Date: Sun, 19 Jul 2026 18:25:47 +0530 Subject: [PATCH 2/3] usb: misc: Use %pe to print error pointers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260719-usb-ptr_err_patchset-v1-2-85f7f2e4fefb@gmail.com> References: <20260719-usb-ptr_err_patchset-v1-0-85f7f2e4fefb@gmail.com> In-Reply-To: <20260719-usb-ptr_err_patchset-v1-0-85f7f2e4fefb@gmail.com> To: Peter Chen , Greg Kroah-Hartman , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Duncan Sands , Chas Williams <3chas3@gmail.com>, Minas Harutyunyan , Hans de Goede , Heikki Krogerus , Badhri Jagan Sridharan Cc: linux-usb@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Subasri S X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784465765; l=3927; i=subasris1210@gmail.com; s=20260709; h=from:subject:message-id; bh=5zvKnd0JD5ih/+cLM7K1dUL0S6yC1cEB7EpZtuHweFE=; b=ql28qsE4EWaYsxnuq4JZUcJCPFY2lrNmFjQWb9Rd/+w5VfSlKcXCXOhlFyrJi7M80qTF8IpCY OaddRPOw0BcCS0eedCYsSCCl31WLSBEf+wArxIm7CVH02A31l4uhy6q X-Developer-Key: i=subasris1210@gmail.com; a=ed25519; pk=6C4wavGFy/OsR8yQQKNWuDXoYPHp2L3sfgNfyzTruTk= Use the %pe format specifier instead of %ld with PTR_ERR() for printing error pointers in various drivers across usb subsystem. This prints symbolic error names (e.g.-ENOMEM) instead of errno numbers (e.g. -12), making error logs more readable. This patch fixes coccinelle reported warnings: ./misc/usb3503.c:206:5-12: WARNING: Consider using %pe to print PTR_ERR() ./atm/usbatm.c:983:14-21: WARNING: Consider using %pe to print PTR_ERR() ./core/hub.c:5675:6-13: WARNING: Consider using %pe to print PTR_ERR() ./gadget/function/u_serial.c:1315:24-31: WARNING: Consider using %pe to print PTR_ERR() ./dwc2/pci.c:72:3-10: WARNING: Consider using %pe to print PTR_ERR() Compile tested only. Signed-off-by: Subasri S --- drivers/usb/atm/usbatm.c | 4 ++-- drivers/usb/core/hub.c | 4 ++-- drivers/usb/dwc2/pci.c | 4 ++-- drivers/usb/gadget/function/u_serial.c | 4 ++-- drivers/usb/misc/usb3503.c | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c index 9600e1ec0993..c78caa1b57c9 100644 --- a/drivers/usb/atm/usbatm.c +++ b/drivers/usb/atm/usbatm.c @@ -979,8 +979,8 @@ static int usbatm_heavy_init(struct usbatm_data *instance) t = kthread_create(usbatm_do_heavy_init, instance, "%s", instance->driver->driver_name); if (IS_ERR(t)) { - usb_err(instance, "%s: failed to create kernel_thread (%ld)!\n", - __func__, PTR_ERR(t)); + usb_err(instance, "%s: failed to create kernel_thread (%pe)!\n", + __func__, t); return PTR_ERR(t); } diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 5262e11c12cd..5e33e3984499 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -5671,8 +5671,8 @@ static void hub_port_connect_change(struct usb_hub *hub, int port1, descr = usb_get_device_descriptor(udev); if (IS_ERR(descr)) { dev_dbg(&udev->dev, - "can't read device descriptor %ld\n", - PTR_ERR(descr)); + "can't read device descriptor %pe\n", + descr); } else { if (descriptors_changed(udev, descr, udev->bos)) { diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c index f3a1e4232a31..9845327f95c5 100644 --- a/drivers/usb/dwc2/pci.c +++ b/drivers/usb/dwc2/pci.c @@ -68,8 +68,8 @@ static int dwc2_pci_probe(struct pci_dev *pci, phy = usb_phy_generic_register(); if (IS_ERR(phy)) { - dev_err(dev, "error registering generic PHY (%ld)\n", - PTR_ERR(phy)); + dev_err(dev, "error registering generic PHY (%pe)\n", + phy); return PTR_ERR(phy); } diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c index cdd1dfc666c4..da31e5cea0a5 100644 --- a/drivers/usb/gadget/function/u_serial.c +++ b/drivers/usb/gadget/function/u_serial.c @@ -1311,8 +1311,8 @@ int gserial_alloc_line_no_console(unsigned char *line_num) tty_dev = tty_port_register_device(&port->port, gs_tty_driver, port_num, NULL); if (IS_ERR(tty_dev)) { - pr_err("%s: failed to register tty for port %d, err %ld\n", - __func__, port_num, PTR_ERR(tty_dev)); + pr_err("%s: failed to register tty for port %d, err %pe\n", + __func__, port_num, tty_dev); ret = PTR_ERR(tty_dev); mutex_lock(&ports[port_num].lock); diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c index 759770a13260..3ac57d31376c 100644 --- a/drivers/usb/misc/usb3503.c +++ b/drivers/usb/misc/usb3503.c @@ -202,8 +202,8 @@ static int usb3503_probe(struct usb3503 *hub) hub->clk = devm_clk_get_optional(dev, "refclk"); if (IS_ERR(hub->clk)) { - dev_err(dev, "unable to request refclk (%ld)\n", - PTR_ERR(hub->clk)); + dev_err(dev, "unable to request refclk (%pe)\n", + hub->clk); return PTR_ERR(hub->clk); } -- 2.43.0