From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A52EC377EC2 for ; Sun, 19 Jul 2026 06:36:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784442995; cv=none; b=f1XS9jS58TAXKd242trCUYSjJYBcSnAyHPEFM96/RFHI6Yo/7+PtWf8QQEncsHfhCAXCoj7S+luKsuxdhttyk4FoeihmiqkERYtGx3zTJHOIXJA4aU4c56NECDc25sNVCOr66TBoA2fYswef6lcFmqV7QScoBi3x6JXOp3W/biY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784442995; c=relaxed/simple; bh=1xGW+5OPXtzQAk5+Pyyb09mDv2qTxs5kQSXDGy4qmJ8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jMFS+G9jL9azQB7wUrO6LZuhDpUYps7Kx7DuUw7LtTZ1vb+IBW6TREKD8BcuZa3z9JyE/7s3UZOFqrhiVLTYSZJ7vnloIkagd/TrlXF3JcdNXMEYGVVNw8/xJTRJZJqhmwA31Sf8F9G9PWOTzWdNILS7z/cjob4fUSJHt7eV8MQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AMyAYIYs; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AMyAYIYs" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-49554ebb87dso6506585e9.3 for ; Sat, 18 Jul 2026 23:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784442992; x=1785047792; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cxs6c/h7vM3D54wuYMS02bOf2z2hWYR7//TmGe3XwKk=; b=AMyAYIYs4SuRsaKaJwu16VZ+pG4F999MQ8PGurcXHE+Bo3SGI8x9xwXJaaiAQ6lOkO MsCjUSxNbYsuxUeGv4yCpescEvZxGtpByRFOpBMmWs6LDoxDHiMi45XbQV9XGtpZYq0p Xg9r5TsrFJegDZbZ2cLZQYP9AyzTJIrcJOWPnXMKU2iH8L2YcWK6OOfMERuXF6wOGt1d NUnZBuY9vbXvSCd/CSV1eF1F563FuDnRZ+Lzutmth4xhz1R84oEFEi4/C529HXMFbFmF kh61bOExxIOCoP1Yvpyn2v3gE+1AH7JvrKfrLug29cL5LXy98QJB+o/CXkubTBL44dU5 JbDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784442992; x=1785047792; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cxs6c/h7vM3D54wuYMS02bOf2z2hWYR7//TmGe3XwKk=; b=kbDpQl6WqCB43l1RfcRVHeN/C9DGQeZ/JaY2Be5AK85gpp2K0kTMeR7gKWaq6MOCnt TcXQxAAJbG2rGvtMskWTXuE/BePD+3GgmoWrUXf9K3ljfCaPzBoQmYEjjOvFx47H64JJ O+iJA8eKidov+JlWxlZT4htkhjFZ78QxCYQSU/S2R7DNE9tcAQ84RtS88NyBQ1CsbC4o dtg3qxdOYborsIYz0F7OQxVe3VyeqE8pGEVsr4FwzsjHiqaqYC+Gi7Cx5T2vb0rGMQOB tX/fms4Gal92ojubMMyrFO6A/SNlyjaeO75Vg1CHwED8RwvVBpEdWgOd6lH6SACLfs2h XTNg== X-Forwarded-Encrypted: i=1; AHgh+RpUBUkilg7O4fQfEQIyPShRWXZDJPmoRILWJoUoue6b3uq2Q83+ee33VWL32VlcltlXmx/AOqQKNmVSSu8=@vger.kernel.org X-Gm-Message-State: AOJu0YwEB2V9pUXSAcrtKgoPsxuzskpRDTxaO1+ZJMoVPI+qiNuT3LfC D2jbraJ00qzDQ61g6h8tFKvfifkoS7GkmwJW3P2683LEIsaFz+Jx0GSK X-Gm-Gg: AfdE7ckA2gOQPQz9zZU6emQedFNX2EmdfEWMe0gUDnR9r8ghyuPTW0HqnK8TZWf2xr4 TbnyBA3udmE9FVSq+3vgpFPS9fU6XquP2XP3TlpBXll2j1WW/Gw7mq0pTf52h/MyCrAYGT5xlND 7Ra3lvchNuf/VkEkEXbI9yrfzTbIPRlnYG0Zl/p8CxwFjbOCvHLsNqCy0HXSWSYkExkleCpwMtN 1Kjc1AxFS7zsb9Qbf5wHkvRbN/GtVuUePyuBVcNdspCF576tkYFvW83npXiO+dsb/q7eUKRzQXa /P/Ra0pdpz7P6UGz0e+Yj4Axz5R9A7fi7ckabsUT21jyRC22vS/q810X9E9+HRuIZ8W8ifNXBlS ChudOZ2Q1Pt4dRv0DETTeHHccB77gkSyJCEHWnWaYZrYVAV0AMZ0mOw1aFvcgO14mcoLr3NShfd DAX42IYkPlR1x/xBkFhxVVUtv3Tu5m5rjCzskhYzq8OcY1VEtoALSiURP7Pxygfs71dK7vAdoUc uFpF+SPHJh8yQxfEFLcRDTD5llkQZ3rSfAMrv0= X-Received: by 2002:a05:600c:5657:b0:493:f442:3dd4 with SMTP id 5b1f17b1804b1-4954a516af8mr59398075e9.39.1784442991787; Sat, 18 Jul 2026 23:36:31 -0700 (PDT) Received: from localhost.localdomain (dynamic-077-007-018-194.77.7.pool.telefonica.de. [77.7.18.194]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49549c96f19sm193053245e9.9.2026.07.18.23.36.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 18 Jul 2026 23:36:30 -0700 (PDT) From: Karl Mehltretter To: Russell King , Greg Kroah-Hartman , Jiri Slaby Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , linux-rt-devel@lists.linux.dev, Toshiyuki Sato , Petr Mladek , John Ogness , Karl Mehltretter Subject: [PATCH 1/2] serial: amba-pl011: unprepare console clock on unregister Date: Sun, 19 Jul 2026 08:35:01 +0200 Message-Id: <20260719063502.18852-2-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20260719063502.18852-1-kmehltretter@gmail.com> References: <20260719063502.18852-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit pl011_console_setup() calls clk_prepare() on the UART clock, but the console provides no matching teardown, so the clock is never unprepared when the console is unregistered -- via the sysfs "console" attribute or a driver unbind. Each re-registration prepares the clock again, leaking one prepare reference per cycle. Even where preparing the clock has no hardware effect, the stale reference leaves the clock framework's prepare count unbalanced. On providers whose prepare operation enables hardware, the leaked reference may also keep the UART clock running after unregister. Add a console .exit() callback that clk_unprepare()s the clock, balancing the clk_prepare() in pl011_console_setup(). Fixes: 4b4851c65d92 ("clk: amba-pl011: convert to clk_prepare()/clk_unprepare()") Assisted-by: Claude:claude-fable-5 Signed-off-by: Karl Mehltretter --- The i.MX console had the same missing teardown, fixed in 9768a37cec37 ("serial: imx: disable console clocks on unregister"). Measured on QEMU raspi (bcm2835), whose UART clock is a real gateable CPRMAN clock: recycling the console via /sys/class/tty/ttyAMA0/console, the uart clock's prepare_count (/sys/kernel/debug/clk/uart/ clk_prepare_count) climbs by one per cycle -- 2 -> 8 over six cycles -- without this patch, and stays at 2 with it. drivers/tty/serial/amba-pl011.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c index 8ed91e1da22b..1aa43994a3cd 100644 --- a/drivers/tty/serial/amba-pl011.c +++ b/drivers/tty/serial/amba-pl011.c @@ -2552,6 +2552,15 @@ static int pl011_console_setup(struct console *co, char *options) return uart_set_options(&uap->port, co, baud, parity, bits, flow); } +static int pl011_console_exit(struct console *co) +{ + struct uart_amba_port *uap = amba_ports[co->index]; + + clk_unprepare(uap->clk); + + return 0; +} + /** * pl011_console_match - non-standard console matching * @co: registering console @@ -2705,6 +2714,7 @@ static struct console amba_console = { .name = "ttyAMA", .device = uart_console_device, .setup = pl011_console_setup, + .exit = pl011_console_exit, .match = pl011_console_match, .write_atomic = pl011_console_write_atomic, .write_thread = pl011_console_write_thread, -- 2.53.0