From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EACFD37CD48 for ; Sun, 19 Jul 2026 08:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784451078; cv=none; b=B+vpat+p11kiC/Dz97VYYaqhWc2Qxl6YETwbN3ghbR6SKSszKF/vmajB953mP5ssubvrJSt7a7AkMMNb56gI8UofTPftfC0z4LGuuuJNGqj2mmIhvK56AXvP9V6jViaLDwS+YFg5LE+efKZNWnjT3d4eNXLL8WIp18vPui6OEeo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784451078; c=relaxed/simple; bh=ULkEzKgd3xGiRR2agZhshXQt8AHLqFg8bpQwn0FoXq4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=a/6okuCOPmUzpdRyi5G5hx+sqX0SKZZrQ2I+nYzO38cLljFwRe239lcRHRRwPc5D9gzSzjbb3F0mvbjNtgKB0Eqgjayubt/LwTpi75r2kUbHVMmphxGCul31SjPmFDoV4PAYzhmmCh2wQgZNm/Cy5efy8IuVh4UUnpRn8WIOG/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MTonoDYW; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MTonoDYW" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-ca7bea5e5b3so6544615a12.1 for ; Sun, 19 Jul 2026 01:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784451074; x=1785055874; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=6gIhz0RnnzBJMwFWCdOqu4dcEl507nyEs5TW2S/nD58=; b=MTonoDYWs0hSjiMBZe1m4iCiDy9sA634BIn6uhDllQz9Kvmkqj3IzP66S0BeUwUl7F IZbNTLQZw+dRJxkABlYRMtkyW3R8v8IgBe6XuwmL7QPc7SxOxJqXWSEjWGC2s3TFmBEv 9VAZjlmW41cbvTQTcTHIsMTGgPwbrJS3PiSM0CuAFgIH9Tc4MiUQmnnYJ66GWQoK5XZ0 4jmW14b09ZVcGCahFWHQHL0tSVsJev0o/vQi0VoNOy0U9DRmpsTm2UrxKyEDc7LbZmPL meMldsbaGBEVaHpUVS3/v5gm1HC7DKfL8MpfmapUq0s9V2VnQPTSR6jRWB/JcIgKodRB Z0rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784451074; x=1785055874; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6gIhz0RnnzBJMwFWCdOqu4dcEl507nyEs5TW2S/nD58=; b=XtwLt3HzXDCmi5PolF3BhhGWD17YLchLs0QWPEcCgweU2QXJH7dPpufhhCZlrc7y1v 39FP+DJr+NvEEYHOUWeCVrpEmlbVMq3+03wNXJF9zhrw9KUWCLYgD5s0/OEwhdvm95O6 VEANjbfLKMBRvJnGajtpnIcqnOgZwgysSvu6+IUv6AUxgy+VXVxn8HELRBTq9n24LwC2 OJnMFyq/bNrubWnsHeqcoHetXz6hp0+0Px+8f0XZQHp8VDb2U9rBF3dlTeE1d73pmXPi XEr7/e2W3vaEN7ntIABI3JkPJtq5EC2a95tlPApytO72ZqGIDenN2adIab/R72tsVR9y GPDg== X-Gm-Message-State: AOJu0Yx8+eXBRz/8fm0nurUsjze28eUWsca/Q7zihpWHFnX2QuWyA/3H NILdnay8z7BNPrkPhwhv1WRT3MjQ2SmYJdqY/bQXfTwnSA1dgBwznmDC X-Gm-Gg: AfdE7cmDeOuH/OqabcuOBA6GNqoVX6Cc1qbU/WRqMGzOqy9HKef0hy9GXrCDP7uQPr0 1YTdOukQmox4RJUpZpx+TbwGT7BADUETngSxkwG3dUY9RtVWETqivJ2ppRnBtxj//AaufFvIb/n 9XZLIvu5J3ZsA7c2TGXyFYD21rRAqqoidhF2teeXinZyfLeAMcdhkNqt0RApbjJVNDoWb26ad64 VfNX2Nbg1NwvEjwvEH9M/wKXi4+bEgw1dtMIXY7EmEX6UTYWmXcMD3fiiTGKYpalgu5Dsy1gkQk Qrdigcev9oiGyIWcmNyj/X9nSvvqAlIrqIRhw7eVSnCeBeZFChQrzEv8QZmyB+YYRd03/mX0c+M TFqwVDmLi133kquS9tn47wKXjnKyBs3gH4zMiAUNSjACud8kAT3Jk0RCHUFqecPyFcoKuWmNd9H 5gl+J6YYTGLTg= X-Received: by 2002:a05:6a21:1506:b0:3c3:9a7f:7309 with SMTP id adf61e73a8af0-3c3ad6779d4mr10584459637.26.1784451074509; Sun, 19 Jul 2026 01:51:14 -0700 (PDT) Received: from gmail.com ([58.84.62.121]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429f9d444sm28544079eec.6.2026.07.19.01.51.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 01:51:14 -0700 (PDT) From: Sumeet Pawnikar To: rafael@kernel.org, rui.zhang@intel.com, linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, sumeet4linux@gmail.com Subject: [PATCH v2] powercap: intel_rapl_tpmi: Handle PMU registration failure during probe Date: Sun, 19 Jul 2026 14:20:59 +0530 Message-ID: <20260719085100.145555-1-sumeet4linux@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit intel_rapl_tpmi_probe() invokes rapl_package_add_pmu() but ignores its return value, so a PMU registration failure would leave the driver reporting probe success despite the PMU being absent, with no log trace. Since PMU registration is an optional auxiliary feature for perf energy counters, its failure should not break the primary powercap functionality. Check the return value and log a warning to ensure graceful degradation. Fixes: 963a9ad3c589 ("powercap: intel_rapl_tpmi: Enable PMU support") Signed-off-by: Sumeet Pawnikar --- v1->v2: * Since PMU registration is an optional auxiliary feature here, treat it's failure as a non fatal error and log a warning and continue, similar to other RAPL drivers like intel_rapl_msr, to ensure graceful degradation (Based on Sashiko feedback: https://sashiko.dev/#/patchset/20260515184250.228062-1-sumeet4linux%40gmail.com) * Add Fixes tag in changelog. --- drivers/powercap/intel_rapl_tpmi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/powercap/intel_rapl_tpmi.c b/drivers/powercap/intel_rapl_tpmi.c index 7f41491d9cd1..078a85158ce4 100644 --- a/drivers/powercap/intel_rapl_tpmi.c +++ b/drivers/powercap/intel_rapl_tpmi.c @@ -414,7 +414,10 @@ static int intel_rapl_tpmi_probe(struct auxiliary_device *auxdev, goto err; } - rapl_package_add_pmu(trp->rp); + ret = rapl_package_add_pmu(trp->rp); + if (ret) + dev_warn(&auxdev->dev, "Failed to add RAPL PMU for Package%d, %ld\n", + info->package_id, ret); auxiliary_set_drvdata(auxdev, trp); -- 2.43.0