From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF7F32E06E6 for ; Sun, 19 Jul 2026 19:04:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784487848; cv=none; b=TktrIXxGLIs0+av3KH6cv+GgrT2XQqDE8EE6+hhS8Gq7NcChX233PqNQ9QCfU2YiIxMqh9758TQuravdrrb9rp8C/+OFdzvMq493E2ODLebn0gejf+Z42FWaSRmUpO5B0IjnM41A4wkxufN7zzQ3fgtmcu0yM2sDEgpN0n4Q+CA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784487848; c=relaxed/simple; bh=Nq3R0jr3WrHzJE3MbSdm+d1RS4jstkYAGdFX8FueSAE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LniC41atzkHZuLoo28Wigu1qJNuh8yfXengfCcIIadNzAwWRy4zWZsWjGQD0QlCNgmq0dp+aFY3Xh9wa8ItC5FYcJ4ztWF4j77u461vN+CGgwuzvKmnJHkwWGjl1KvjkGS9PWXz9fU4QWTpky8tGLFtFmg3Zr9LMtEIfwUb80bA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=edvdQDLU; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="edvdQDLU" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-493f6de72faso21482405e9.0 for ; Sun, 19 Jul 2026 12:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784487845; x=1785092645; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bDZJF2FHgZ0pc0vw2vaEItundHS+IICtSs7RbOX6+08=; b=edvdQDLUXp4S00PmMu+lbCYYw0d6c6GPZvtmBV1AZeeJZnpARfwJ7+hBP6KiAjAQYl YIWV3EcA15vsgeE84JVpp/08RJqijCCc7LkZh9O9PR5iP1bYyxZam4eqdh5tH3Fd3b3F Acs8Z7+qajzDxIX7d+XWLJ/5eh1Js4xhOZOHg4Cu5ePSBZNCqAKXy8J0wKN6XKrHK+Hb 4UcP8+tmhHISalRbK/LivIMYWr3jiTjt/I3rMubjau+Bpx3eN+cvA1k+boRCTuEJXa17 mio+TgcsD0gObUOZc4zGoYXDC8VDrV3UOYmYXetZe6Q4evbo3yElEckDJwYye3nSb0Er cr/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784487845; x=1785092645; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=bDZJF2FHgZ0pc0vw2vaEItundHS+IICtSs7RbOX6+08=; b=pyJKTDzmXIqc9tzbBIpZiPuMZjsLy9n8ktJSPB05tsUhKQo+xn9uJdIt9UKxEvOpyi Bd/3DDLmQu/LFOQJu8hZ7J/dkIQl0Asxmj0Ewv7PoVuksDQcbWxwvjDZS+p5nxHx+hR/ bZBC3rrFjrzRqZzGAJODAMx/YfqJ0wdFkBCM/AP/HkLYGqskYrjc4ffEi5l/FJgtZcbB roCDlL4GX+UsA+47UaeUhcdfGxXfHVF2w5VGJp6wQ/zXKaY7S9LgR3B6hOJmmBkH+Isa rOhqjUF+c8aEYi42oDOqBygia9xkoTWdt/l0ZyHTZovMoQalk8/m+UNDQHHfetkbSHQv V+WQ== X-Forwarded-Encrypted: i=1; AHgh+Rrmmc4LKs5ZAEEa892Agv24MSKmz+M8wCo19KWolnikrvGyV4BckWIL5WUR/+4zc/2fNmyePS4OjJU7qhA=@vger.kernel.org X-Gm-Message-State: AOJu0YyDf2ZqOshXc3LQ4pWsf+v8WwvvgR6eC+bwm0sTjkCeRKTHXMha 5gUHCo8W9Svvi9dDPNUErN/SUDJ1oMNtiH4IEQLuE597klEw1rXri7u2 X-Gm-Gg: AfdE7ckRZcc9HSyBt9u7H2A9UD4soPOgvuSMHxtvNm4m+lAa/v+wJt6NKK7tM6XsadX Gtsr+blITgBqkvzzXuo6k4Iij1h66vukzAXjZyH5770dwb6RN8Shdsibz/SyFYrCZCbFMabtsJR HJYuuMC6+HHlD10Ro7/QAc/UFDi4Kf7I4njRCZ1KfoqjWce5krvL4o/pC+mFcVsqPVQmP6acyLu aDHMCi+QB0RXB/ClEqovi9YVwedTLXaIfzBL3mp27oGp3/YkqsxiF3NPqLMdNtwNp6bq7ZFCVzU qHyuLdXUPhl4gKzKBajHVKZVjA6wNhNoXyMjbNgh20FX1Bo4kk1VIxPNjd1YnKFRBqD5VGC0EjR pLFWNdUd8kJnNcgbBD4hDM/vSTl4/ByjuX5nTXXdlkFSfbtRsxYdwnoKa0vhocJAg8Wkm4yr2W7 e6vInGBsmKcGvh1oZZ5hFr1OvTBIeX+LaXqE8FQg== X-Received: by 2002:a05:600c:3b88:b0:495:495f:bc30 with SMTP id 5b1f17b1804b1-4954a3391femr121619125e9.12.1784487844829; Sun, 19 Jul 2026 12:04:04 -0700 (PDT) Received: from michalis-linux (adsl-75.176.58.251.tellas.gr. [176.58.251.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2a2504sm241425285e9.2.2026.07.19.12.04.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 12:04:04 -0700 (PDT) From: Michail Tatas To: michael@amarulasolutions.com, neil.armstrong@linaro.org, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dianders@chromium.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Michail Tatas Subject: [PATCH v2 1/3] drm/panel: ilitek-ili9805: Use _multi variants Date: Sun, 19 Jul 2026 22:03:55 +0300 Message-ID: <20260719190358.438699-2-michail.tatas@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260719190358.438699-1-michail.tatas@gmail.com> References: <20260719190358.438699-1-michail.tatas@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert functions mipi_dsi_* to mipi_dsi_*_multi as per the gpu/todo file. The multi variant of these functions include improved error handling. Signed-off-by: Michail Tatas --- drivers/gpu/drm/panel/panel-ilitek-ili9805.c | 51 +++++--------------- 1 file changed, 13 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c index e6c483851f1f..7e9587afebbe 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c @@ -159,36 +159,23 @@ static int ili9805_power_off(struct ili9805 *ctx) static int ili9805_activate(struct ili9805 *ctx) { - struct mipi_dsi_device *dsi = ctx->dsi; - struct device *dev = &dsi->dev; - int i, ret; + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; + int i; for (i = 0; i < ctx->desc->init_length; i++) { const struct ili9805_instr *instr = &ctx->desc->init[i]; - ret = mipi_dsi_dcs_write_buffer(ctx->dsi, instr->data, instr->len); - if (ret < 0) - return ret; + mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, instr->data, instr->len); if (instr->delay > 0) - msleep(instr->delay); - } - - ret = mipi_dsi_dcs_exit_sleep_mode(ctx->dsi); - if (ret) { - dev_err(dev, "Failed to exit sleep mode (%d)\n", ret); - return ret; + mipi_dsi_msleep(&dsi_ctx, instr->delay); } - usleep_range(5000, 6000); + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); + mipi_dsi_usleep_range(&dsi_ctx, 5000, 6000); + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); - ret = mipi_dsi_dcs_set_display_on(ctx->dsi); - if (ret) { - dev_err(dev, "Failed to set display ON (%d)\n", ret); - return ret; - } - - return 0; + return dsi_ctx.accum_err; } static int ili9805_prepare(struct drm_panel *panel) @@ -211,25 +198,13 @@ static int ili9805_prepare(struct drm_panel *panel) static int ili9805_deactivate(struct ili9805 *ctx) { - struct mipi_dsi_device *dsi = ctx->dsi; - struct device *dev = &dsi->dev; - int ret; - - ret = mipi_dsi_dcs_set_display_off(ctx->dsi); - if (ret < 0) { - dev_err(dev, "Failed to set display OFF (%d)\n", ret); - return ret; - } + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; - usleep_range(5000, 10000); - - ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); - if (ret < 0) { - dev_err(dev, "Failed to enter sleep mode (%d)\n", ret); - return ret; - } + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); + mipi_dsi_usleep_range(&dsi_ctx, 5000, 10000); + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); - return 0; + return dsi_ctx.accum_err; } static int ili9805_unprepare(struct drm_panel *panel) -- 2.43.0